New issue
Advanced search Search tips

Issue 685355 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 685657

Blocking:
issue 623160



Sign in to add a comment

Convert AudioParam tests to testharness

Project Member Reported by rtoy@chromium.org, Jan 25 2017

Issue description

Convert the tests in the AudioParam directory to testharness.
 

Comment 1 by rtoy@chromium.org, Jan 26 2017

Blockedon: 685657
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec0443b5eca883e0cdeb2f8940cf8faa34dc9868

commit ec0443b5eca883e0cdeb2f8940cf8faa34dc9868
Author: rtoy <rtoy@chromium.org>
Date: Fri Jan 27 23:08:16 2017

Convert AudioParam Audit tests to testharness

This were converted automatically using the script

for f in `grep -l Audit *.html`
do
  # Replace js-test with testharness and add testharnessreport.js
  sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\
\1\2testharnessreport.js\3 ;' $f
  # Remove old js-test methods that no longer exist.
  sed -i '/^[ 	]*\(description(.*)\|finishJSTest()\);[ 	]*$/d' $f
  # Remove jsTestIsAsync stuff
  sed -i '/^[ 	]*window.jsTestIsAsync *= *true;[ 	]*$/d' $f
  # Remove expected results file.
  base=`basename $f .html`
  git rm $base-expected.txt
done

The following files needed to be updated manually to remove the uses
of testPassed/testFailed:

audioparam-automation-clamping.html
audioparam-large-endtime.html
audioparam-linearRamp-value-attribute.html
audioparam-method-chaining.html
audioparam-nominal-range.html
audioparam-sampling.html
audioparam-setTargetAtTime-continuous.html
audioparam-setTargetAtTime-limit.html
audioparam-setValueCurve-copy.html
audioparam-setValueCurve-duration.html
audioparam-setValueCurve-exceptions.html
audioparam-setValueCurveAtTime-interpolation.html
audioparam-update-value-attribute.html

BUG= 685355 
TEST=

Review-Url: https://codereview.chromium.org/2658703002
Cr-Commit-Position: refs/heads/master@{#446814}

[modify] https://crrev.com/ec0443b5eca883e0cdeb2f8940cf8faa34dc9868/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-automation-clamping-expected.txt
[modify] https://crrev.com/ec0443b5eca883e0cdeb2f8940cf8faa34dc9868/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-automation-clamping.html
[delete] https://crrev.com/59734505205095774d8696ebfeca11e7cc368331/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-initial-event-expected.txt
[modify] https://crrev.com/ec0443b5eca883e0cdeb2f8940cf8faa34dc9868/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-initial-event.html
[delete] https://crrev.com/59734505205095774d8696ebfeca11e7cc368331/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-large-endtime-expected.txt
[modify] https://crrev.com/ec0443b5eca883e0cdeb2f8940cf8faa34dc9868/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-large-endtime.html
[delete] https://crrev.com/59734505205095774d8696ebfeca11e7cc368331/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-linearRamp-value-attribute-expected.txt
[modify] https://crrev.com/ec0443b5eca883e0cdeb2f8940cf8faa34dc9868/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-linearRamp-value-attribute.html
[delete] https://crrev.com/59734505205095774d8696ebfeca11e7cc368331/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-method-chaining-expected.txt
[modify] https://crrev.com/ec0443b5eca883e0cdeb2f8940cf8faa34dc9868/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-method-chaining.html
[delete] https://crrev.com/59734505205095774d8696ebfeca11e7cc368331/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-negative-exponentialRamp-expected.txt
[modify] https://crrev.com/ec0443b5eca883e0cdeb2f8940cf8faa34dc9868/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-negative-exponentialRamp.html
[modify] https://crrev.com/ec0443b5eca883e0cdeb2f8940cf8faa34dc9868/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range-expected.txt
[modify] https://crrev.com/ec0443b5eca883e0cdeb2f8940cf8faa34dc9868/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-nominal-range.html
[delete] https://crrev.com/59734505205095774d8696ebfeca11e7cc368331/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-sampling-expected.txt
[modify] https://crrev.com/ec0443b5eca883e0cdeb2f8940cf8faa34dc9868/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-sampling.html
[delete] https://crrev.com/59734505205095774d8696ebfeca11e7cc368331/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime-continuous-expected.txt
[modify] https://crrev.com/ec0443b5eca883e0cdeb2f8940cf8faa34dc9868/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime-continuous.html
[delete] https://crrev.com/59734505205095774d8696ebfeca11e7cc368331/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime-limit-expected.txt
[modify] https://crrev.com/ec0443b5eca883e0cdeb2f8940cf8faa34dc9868/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime-limit.html
[delete] https://crrev.com/59734505205095774d8696ebfeca11e7cc368331/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime-sampling-expected.txt
[modify] https://crrev.com/ec0443b5eca883e0cdeb2f8940cf8faa34dc9868/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime-sampling.html
[delete] https://crrev.com/59734505205095774d8696ebfeca11e7cc368331/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-copy-expected.txt
[modify] https://crrev.com/ec0443b5eca883e0cdeb2f8940cf8faa34dc9868/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-copy.html
[delete] https://crrev.com/59734505205095774d8696ebfeca11e7cc368331/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-duration-expected.txt
[modify] https://crrev.com/ec0443b5eca883e0cdeb2f8940cf8faa34dc9868/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-duration.html
[delete] https://crrev.com/59734505205095774d8696ebfeca11e7cc368331/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-end-expected.txt
[modify] https://crrev.com/ec0443b5eca883e0cdeb2f8940cf8faa34dc9868/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-end.html
[modify] https://crrev.com/ec0443b5eca883e0cdeb2f8940cf8faa34dc9868/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions-expected.txt
[modify] https://crrev.com/ec0443b5eca883e0cdeb2f8940cf8faa34dc9868/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurve-exceptions.html
[delete] https://crrev.com/59734505205095774d8696ebfeca11e7cc368331/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurveAtTime-interpolation-expected.txt
[modify] https://crrev.com/ec0443b5eca883e0cdeb2f8940cf8faa34dc9868/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurveAtTime-interpolation.html
[delete] https://crrev.com/59734505205095774d8696ebfeca11e7cc368331/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-update-value-attribute-expected.txt
[modify] https://crrev.com/ec0443b5eca883e0cdeb2f8940cf8faa34dc9868/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-update-value-attribute.html

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa102cf589f1db56e94cd4fc2493d5c26b4c9c91

commit fa102cf589f1db56e94cd4fc2493d5c26b4c9c91
Author: rtoy <rtoy@chromium.org>
Date: Mon Jan 30 21:04:32 2017

Convert AudioParam tests to testharness and new Audit

Manually convert all tests using createAudioGraphAndTest to use
testharness and new Audit.

BUG= 685355 
TEST=audioparam-exponentialRampToValueAtTime.html
audioparam-linearRampToValueAtTime.html
audioparam-setTargetAtTime.html
audioparam-setValueAtTime.html
audioparam-setValueCurveAtTime.html

Review-Url: https://codereview.chromium.org/2657033002
Cr-Commit-Position: refs/heads/master@{#447058}

[delete] https://crrev.com/8576e703d22ac09c939415b9e7eb9cc0323b2ebe/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-exponentialRampToValueAtTime-expected.txt
[modify] https://crrev.com/fa102cf589f1db56e94cd4fc2493d5c26b4c9c91/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-exponentialRampToValueAtTime.html
[delete] https://crrev.com/8576e703d22ac09c939415b9e7eb9cc0323b2ebe/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-linearRampToValueAtTime-expected.txt
[modify] https://crrev.com/fa102cf589f1db56e94cd4fc2493d5c26b4c9c91/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-linearRampToValueAtTime.html
[delete] https://crrev.com/8576e703d22ac09c939415b9e7eb9cc0323b2ebe/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime-expected.txt
[modify] https://crrev.com/fa102cf589f1db56e94cd4fc2493d5c26b4c9c91/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime.html
[delete] https://crrev.com/8576e703d22ac09c939415b9e7eb9cc0323b2ebe/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueAtTime-expected.txt
[modify] https://crrev.com/fa102cf589f1db56e94cd4fc2493d5c26b4c9c91/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueAtTime.html
[delete] https://crrev.com/8576e703d22ac09c939415b9e7eb9cc0323b2ebe/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurveAtTime-expected.txt
[modify] https://crrev.com/fa102cf589f1db56e94cd4fc2493d5c26b4c9c91/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurveAtTime.html
[modify] https://crrev.com/fa102cf589f1db56e94cd4fc2493d5c26b4c9c91/third_party/WebKit/LayoutTests/webaudio/resources/audioparam-testing.js

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 30 2017

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 30 2017

Comment 6 by rtoy@chromium.org, Jan 31 2017

Owner: rtoy@chromium.org
Status: Verified (was: Available)
grep js-test *.html in AudioParam directory returns nothing.

Sign in to add a comment