New issue
Advanced search Search tips

Issue 685354 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rebaseline tools: The "copy-existing-baselines" step should copy to virtual test baseline locations

Project Member Reported by qyears...@chromium.org, Jan 25 2017

Issue description

Example case:
After the change in https://codereview.chromium.org/2642193011, the baseline for paint/invalidation/control-clip.html needed to be updated but the original baseline should have been kept for virtual/stable/paint/invalidation/control-clip.html.

The "copy-existing-baselines" stage (https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py?l=136) normally copies existing baselines for a particular platform X over to any baseline directories that would use the baseline directory for X as a fall-back.

Proposed change:
Suppose we're going to download a new baseline for mac10.11 for test x/y/z.html which has a virtual test in the virtual test suite "foo". The old baseline should be copied over to both platform/mac-10.10/x/y/z-expected.txt as well as virtual/foo/platform/mac/x/y/z-expected.txt

Then, in the "optimize-baselines" stage, all of the platform-specific baselines in platform/*/virtual/foo/x/y/z-expected.txt could be de-duplicated, perhaps leaving behind a baseline in virtual/foo/x/y/z-expected.txt, or platform/mac/virtual/foo/x/y/z-expected.txt.
 
Labels: -Pri-2 Pri-3
Summary: Rebaseline tools: The "copy-existing-baselines" step should copy to virtual test baseline locations (was: Rebaselining process: The "copy-existing-baselines" step should copy to virtual test baseline locations)
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 22

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: robertma@chromium.org
Status: Available (was: Untriaged)
robertma@, marking this available. Do you know of wpt importer issues we've had that might have had this as the root cause? It seems to me like baselines for virtual tests are actually working just fine?

Sign in to add a comment