OAuthRequestSignerTest.DecodeEncoded (google_apis_unittests) failing on chromium.win/Win7 Tests (1) |
|||||||||||
Issue descriptiongoogle_apis_unittests failing on chromium.win/Win7 Tests (1) Type: build-failure Builders failed on: - Win7 Tests (1): https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29 Sample failure: [ RUN ] OAuthRequestSignerTest.DecodeEncoded c:\b\c\b\win\src\google_apis\gaia\oauth_request_signer_unittest.cc(70): error: Value of: text Actual: "\b^\x80\x1E\xE7\x92\xAA\x88,x\x1E\xFF\x8F" "3\x7Fg\xF5h\xED" "0\x9E\xA2\xDA\xD7\xA0\xF5\x19\xB0\x94\xE2" "8\xE2\x8F{\x10\xB3T\xC7\x9A\x6\xC7h\x5!\xA5{\x5\xB4s\xC0m\x17\xB4\xFB\0\xD4_\x9A\x84" "e\x90\x97\x19?~\xA0\xC9\xF\xADv`Ce\x93~\xCC" "b\xF\xEA\"\xCD\xC4)\x89k\xB1P\x94\x15\x9C\x16\xE7h\xFB-@\xBD\x15\xD3\xB9[e\xA4G\xEC?\xB2\x87.\xB6\xD7\xBA\xEB\xBCJ\r+\x8Bq\x1F\xA8" "D\xF6\xBD\x82\xD6\x1D\xF0" "4\"U" Expected: decoded Which is: "\xF0" "Fh\x6\xCFz\x92p\x14x\x6\xE7w3gg\xDDh\xD5" "0\x86\x8A\xC2\xBF\x88\xDD\x1\x98|\xCA" "8\xCAwc\xF8\x9BT\xAF\x82\xEE\xAFh\xED\t\x8D" "c\xED\x9Cs\xA8m\xFF\x9C\xE3\xE8\xBC_\x82lex\x7F\x1'~\x88\xB1\xF7\x95vHCe{~\xB4" "b\xF7\xD2\n\xB5\xAC\x11qk\x99P|\xFD\x84\xFE\xCFh\xE3-(\xA5\xFD\xBB\xA1" "Ce\x8CG\xD4'\x9Ao.\x9E\xBF\xA2\xD3\xA4J\xF5\x13sq\a\x90" "D\xDE\xA5j\xBE\x5\xD8" "4\nU" With diff: @@ -1,3 +1,1 @@ -\xF0" "Fh\x6\xCFz\x92p\x14x\x6\xE7w3gg\xDDh\xD5" "0\x86\x8A\xC2\xBF\x88\xDD\x1\x98|\xCA" "8\xCAwc\xF8\x9BT\xAF\x82\xEE\xAFh\xED\t\x8D" "c\xED\x9Cs\xA8m\xFF\x9C\xE3\xE8\xBC_\x82lex\x7F\x1'~\x88\xB1\xF7\x95vHCe{~\xB4" "b\xF7\xD2 -\xB5\xAC\x11qk\x99P|\xFD\x84\xFE\xCFh\xE3-(\xA5\xFD\xBB\xA1" "Ce\x8CG\xD4'\x9Ao.\x9E\xBF\xA2\xD3\xA4J\xF5\x13sq\a\x90" "D\xDE\xA5j\xBE\x5\xD8" "4 -U +\b^\x80\x1E\xE7\x92\xAA\x88,x\x1E\xFF\x8F" "3\x7Fg\xF5h\xED" "0\x9E\xA2\xDA\xD7\xA0\xF5\x19\xB0\x94\xE2" "8\xE2\x8F{\x10\xB3T\xC7\x9A\x6\xC7h\x5!\xA5{\x5\xB4s\xC0m\x17\xB4\xFB\0\xD4_\x9A\x84" "e\x90\x97\x19?~\xA0\xC9\xF\xADv`Ce\x93~\xCC" "b\xF\xEA\"\xCD\xC4)\x89k\xB1P\x94\x15\x9C\x16\xE7h\xFB-@\xBD\x15\xD3\xB9[e\xA4G\xEC?\xB2\x87.\xB6\xD7\xBA\xEB\xBCJ\r+\x8Bq\x1F\xA8" "D\xF6\xBD\x82\xD6\x1D\xF0" "4\"U [ FAILED ] OAuthRequestSignerTest.DecodeEncoded (1 ms)
,
Jan 25 2017
Patch to disable test on OS_WIN: https://codereview.chromium.org/2652363002/
,
Jan 25 2017
Well I'm stumped. https://cs.chromium.org/chromium/src/google_apis/gaia/oauth_request_signer_unittest.cc?sq=package:chromium&dr=C&l=57 The test and the code being tested are both pretty simple. I don't see how it could be failing only on Win7 and not other platforms.
,
Jan 25 2017
nodir@, can you take a quick look at this to see if I'm missing something obvious? I'm pinging you since you're a Trooper. I can't find anything in the blameset that I think would cause this failure. Is there a way I can see if anything in the bot's environment changed between builds 62850 and 62851? (default character encoding maybe?)
,
Jan 26 2017
Today trooper is katthomas
,
Jan 26 2017
I tried a speculative revert of https://codereview.chromium.org/2653773003 in https://codereview.chromium.org/2656953002/ since it touches SSL and stuff. The trybots for that CL only runs Win x64, while the breaking bot is 32-bit.
,
Jan 26 2017
The revert did not solve the failure: relanded as https://codereview.chromium.org/2651303003/
,
Jan 26 2017
,
Jan 26 2017
I'm landing the disabling maniscalco@ created in https://codereview.chromium.org/2652363002/ now, to green up the builder.
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee727fc9a40f5c579dc729c55f0118bfeb146812 commit ee727fc9a40f5c579dc729c55f0118bfeb146812 Author: maniscalco <maniscalco@chromium.org> Date: Thu Jan 26 08:23:26 2017 Disable OAuthRequestSignerTest.DecodeEncoded on OS_WIN Test is failing on Win7. BUG=685352 TBR=msarda@chromium.org Review-Url: https://codereview.chromium.org/2652363002 Cr-Commit-Position: refs/heads/master@{#446276} [modify] https://crrev.com/ee727fc9a40f5c579dc729c55f0118bfeb146812/google_apis/gaia/oauth_request_signer_unittest.cc
,
Jan 26 2017
,
Jan 27 2017
mnissler@ can you take a look and/or triage this bug?
,
Feb 10 2017
,
Feb 10 2017
,
Feb 10 2017
,
May 15 2017
Sorry, I no longer work on these things. Assigning to msarda@ per src/google_apis/gaia/OWNERS I wouldn't be surprised if it turned out that nobody is using OAuth1 any longer and this test and the code it tests can just be removed. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by manisca...@chromium.org
, Jan 25 2017