New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 685343 link

Starred by 1 user
Status: Verified
Owner:
mattreynolds@chromium.org
Closed: Jan 2017
Cc:
█ mmo...@chromium.org
█ animohan@chromium.org
█ scottj@chromium.org
ios-bugs@chromium.org
█ cco3@chromium.org
mattreynolds@chromium.org
█ rzhao@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Physical Web omnibox logo on iOS uses wrong shade of gray

Project Member Reported by mattreynolds@chromium.org, Jan 25 2017 
Chrome Version: ToT
OS: iOS

What steps will reproduce the problem?
(1) Enable the Physical Web
(2) While near a Physical Web beacon, tap the omnibox to show suggestions
(3) Observe the color of the icon displayed next to Physical Web suggestions

What is the expected result?

The Physical Web logo should match the grays used by other icons, eg the "append into edit" arrow.

What happens instead?

The logo is rendered too dark

Comment 1 by mattreynolds@chromium.org, Jan 25 2017 

Attached image showing the different shades of gray
20170125-pw-omnibox-ios-logo-bug.png
165 KB View Download

Comment 2 by mattreynolds@chromium.org, Jan 25 2017 

Before and after screenshots showing the new Physical Web logo image
20170125-pw-omnibox-ios-icon-before.png
89.3 KB View Download
20170125-pw-omnibox-ios-icon-after.png
89.1 KB View Download

Comment 3 by mattreynolds@chromium.org, Jan 26 2017 

New "after" screenshots with the rebuilt icons (thanks Scott)
20170125-pw-omnibox-ios-icon-after-v2-normal.png
89.4 KB View Download
20170125-pw-omnibox-ios-icon-after-v2-highlighted.png
89.4 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9896346c3c7b07539e00668b9967a6e714dfeeac

commit 9896346c3c7b07539e00668b9967a6e714dfeeac
Author: mattreynolds <mattreynolds@chromium.org>
Date: Thu Jan 26 02:14:16 2017

Update Physical Web omnibox icons to match Chrome's theme

An icon with the Physical Web logo is shown on the right end of Physical
Web omnibox suggestions. Previously, these icons used colors that looked
out of place with the other omnibox icons. This CL replaces the PW icons
with new ones that match the theme.

BUG= 685343 

Review-Url: https://codereview.chromium.org/2645403010
Cr-Commit-Position: refs/heads/master@{#446206}

[modify] https://crrev.com/9896346c3c7b07539e00668b9967a6e714dfeeac/ios/chrome/app/theme/default_100_percent/omnibox/physical_web_highlighted_ios.png
[modify] https://crrev.com/9896346c3c7b07539e00668b9967a6e714dfeeac/ios/chrome/app/theme/default_100_percent/omnibox/physical_web_ios.png
[modify] https://crrev.com/9896346c3c7b07539e00668b9967a6e714dfeeac/ios/chrome/app/theme/default_200_percent/omnibox/physical_web_highlighted_ios.png
[modify] https://crrev.com/9896346c3c7b07539e00668b9967a6e714dfeeac/ios/chrome/app/theme/default_200_percent/omnibox/physical_web_ios.png
[modify] https://crrev.com/9896346c3c7b07539e00668b9967a6e714dfeeac/ios/chrome/app/theme/default_300_percent/omnibox/physical_web_highlighted_ios.png
[modify] https://crrev.com/9896346c3c7b07539e00668b9967a6e714dfeeac/ios/chrome/app/theme/default_300_percent/omnibox/physical_web_ios.png

Comment 5 by srikanthg@chromium.org, Jan 31 2017 

Grey color icon is displayed in omnibox suggestions for physical web results.
Verified in M58.0.2998.0 Dev
Device: iPhone6 plus, iOS: 10.1.1

Comment 6 by mattreynolds@chromium.org, Jan 31 2017

Status: Verified (was: Started)
►

Sign in to add a comment