New issue
Advanced search Search tips

Issue 685339 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Fixing-touch


Sign in to add a comment

Arrow icon is missing during touch calibration

Project Member Reported by malaykeshav@chromium.org, Jan 25 2017

Issue description

The hint box during touch calibration does not have an arrow icon to match the UX-specs.
 
Expected.png
37.4 KB View Download
Actual.png
88.0 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f2db51fbe14e281613fa054a650a314464125e1

commit 6f2db51fbe14e281613fa054a650a314464125e1
Author: malaykeshav <malaykeshav@chromium.org>
Date: Sat Jan 28 01:53:23 2017

Adds arrow icon and updates exit label color for touch calibration

 - Updates text color for exit label, to make it brighter.
 - Uses bubble border to add arrow icon.

Screenshot
https://drive.google.com/a/google.com/file/d/0B_WkX8bSkoT1Yi1IOHNwbUpwSzQ/

Screenshot RTL
https://drive.google.com/a/google.com/file/d/0B_WkX8bSkoT1RWNTM2VQQkVSS3c/

BUG=634166,  685338 ,  685339 
COMPONENT=Touch Calibtation, Chrome OS

Review-Url: https://codereview.chromium.org/2655003002
Cr-Commit-Position: refs/heads/master@{#446878}

[modify] https://crrev.com/6f2db51fbe14e281613fa054a650a314464125e1/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc

Status: Fixed (was: Started)
Labels: Merge-Request-57
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 30 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 30 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f231fcbfad6cabf21d31ce1c11d761a627360820

commit f231fcbfad6cabf21d31ce1c11d761a627360820
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Mon Jan 30 23:32:26 2017

Adds arrow icon and updates exit label color for touch calibration

 - Updates text color for exit label, to make it brighter.
 - Uses bubble border to add arrow icon.

Screenshot
https://drive.google.com/a/google.com/file/d/0B_WkX8bSkoT1Yi1IOHNwbUpwSzQ/

Screenshot RTL
https://drive.google.com/a/google.com/file/d/0B_WkX8bSkoT1RWNTM2VQQkVSS3c/

BUG=634166,  685338 ,  685339 
COMPONENT=Touch Calibtation, Chrome OS

Review-Url: https://codereview.chromium.org/2655003002
Cr-Commit-Position: refs/heads/master@{#446878}
(cherry picked from commit 6f2db51fbe14e281613fa054a650a314464125e1)

Review-Url: https://codereview.chromium.org/2663933002 .
Cr-Commit-Position: refs/branch-heads/2987@{#200}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/f231fcbfad6cabf21d31ce1c11d761a627360820/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc

Status: Verified (was: Fixed)

Sign in to add a comment