New issue
Advanced search Search tips

Issue 685338 link

Starred by 2 users
Status: Verified
Owner:
malaykeshav@chromium.org
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Fixing-touch


Sign in to add a comment

Exit text is not very readable during touch calibration

Project Member Reported by malaykeshav@chromium.org, Jan 25 2017 
During touch calibration, the exit label is unreadable and dim.

Screen grab:
https://drive.google.com/file/d/0B_WkX8bSkoT1RmhTcnl5NjZSV0VieXd1cjZEa2o0VF9VOFA4/view
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f2db51fbe14e281613fa054a650a314464125e1

commit 6f2db51fbe14e281613fa054a650a314464125e1
Author: malaykeshav <malaykeshav@chromium.org>
Date: Sat Jan 28 01:53:23 2017

Adds arrow icon and updates exit label color for touch calibration

 - Updates text color for exit label, to make it brighter.
 - Uses bubble border to add arrow icon.

Screenshot
https://drive.google.com/a/google.com/file/d/0B_WkX8bSkoT1Yi1IOHNwbUpwSzQ/

Screenshot RTL
https://drive.google.com/a/google.com/file/d/0B_WkX8bSkoT1RWNTM2VQQkVSS3c/

BUG=634166,  685338 ,  685339 
COMPONENT=Touch Calibtation, Chrome OS

Review-Url: https://codereview.chromium.org/2655003002
Cr-Commit-Position: refs/heads/master@{#446878}

[modify] https://crrev.com/6f2db51fbe14e281613fa054a650a314464125e1/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc

Comment 2 by malaykeshav@chromium.org, Jan 28 2017

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 30 2017

Labels: merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f231fcbfad6cabf21d31ce1c11d761a627360820

commit f231fcbfad6cabf21d31ce1c11d761a627360820
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Mon Jan 30 23:32:26 2017

Adds arrow icon and updates exit label color for touch calibration

 - Updates text color for exit label, to make it brighter.
 - Uses bubble border to add arrow icon.

Screenshot
https://drive.google.com/a/google.com/file/d/0B_WkX8bSkoT1Yi1IOHNwbUpwSzQ/

Screenshot RTL
https://drive.google.com/a/google.com/file/d/0B_WkX8bSkoT1RWNTM2VQQkVSS3c/

BUG=634166,  685338 ,  685339 
COMPONENT=Touch Calibtation, Chrome OS

Review-Url: https://codereview.chromium.org/2655003002
Cr-Commit-Position: refs/heads/master@{#446878}
(cherry picked from commit 6f2db51fbe14e281613fa054a650a314464125e1)

Review-Url: https://codereview.chromium.org/2663933002 .
Cr-Commit-Position: refs/branch-heads/2987@{#200}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/f231fcbfad6cabf21d31ce1c11d761a627360820/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc

Comment 4 by abod...@chromium.org, Mar 29 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment