New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685337 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 669967



Sign in to add a comment

[Sync] Move crypto state out of PSS and SBHI into a separate object.

Project Member Reported by maxbogue@chromium.org, Jan 25 2017

Issue description

Both ProfileSyncService and SyncBackendHostImpl track some crypto-related state and logic. As part of removing SBHI and cleaning up PSS, this should all be factored out into a separate object (tentatively called SyncServiceCrypto).

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80b39191c5d7cbe798092d33e15f2118d658dbf1

commit 80b39191c5d7cbe798092d33e15f2118d658dbf1
Author: maxbogue <maxbogue@chromium.org>
Date: Thu Jan 26 20:43:32 2017

[Sync] Calculate active types and track catch up in DTMI not PSS.

This change is in preparation for factoring encryption-related logic out
of ProfileSyncService. It moves the calculation of active data types
from PSS to DTM (which makes sense since it's where we know which types
are active).

It also removes redundant tracking of the catch_up_configure_in_progress_
state from PSS, since this is already tracked in DTMI. Instead it's
passed as a boolean in the ConfigureResult object.

BUG= 685337 

Review-Url: https://codereview.chromium.org/2649133012
Cr-Commit-Position: refs/heads/master@{#446433}

[modify] https://crrev.com/80b39191c5d7cbe798092d33e15f2118d658dbf1/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/80b39191c5d7cbe798092d33e15f2118d658dbf1/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/80b39191c5d7cbe798092d33e15f2118d658dbf1/components/browser_sync/profile_sync_service_unittest.cc
[modify] https://crrev.com/80b39191c5d7cbe798092d33e15f2118d658dbf1/components/sync/driver/data_type_manager.h
[modify] https://crrev.com/80b39191c5d7cbe798092d33e15f2118d658dbf1/components/sync/driver/data_type_manager_impl.cc
[modify] https://crrev.com/80b39191c5d7cbe798092d33e15f2118d658dbf1/components/sync/driver/data_type_manager_impl.h
[modify] https://crrev.com/80b39191c5d7cbe798092d33e15f2118d658dbf1/components/sync/driver/data_type_manager_mock.h

Status: Fixed (was: Started)

Sign in to add a comment