New issue
Advanced search Search tips

Issue 685332 link

Starred by 0 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Don't Show Current URL as Omnibox Suggestion on Empty Input

Project Member Reported by mpear...@chromium.org, Jan 25 2017

Issue description

What steps will reproduce the problem?
(1) On an arbitrary web page (not the NTP or a search results page), tap to focus the omnibox.
(2) See the list of zerosuggest omnibox suggestions, which should be the current URL at the top (known as the what-you-typed suggestion), then a list of highly visited URLs (like those on the NTP) below that.
(3) Tap the "X" to clear the omnibox input, or press backspace to do it.  (The latter should work because the omnibox input is selected by default.)

What is the expected result?
1. The omnibox text is empty, so the what-you-typed suggestion should be gone.
  I'm ambivalent whether the highly visited URL suggestions should be there.  See bug 685329.

What happens instead?
1. all suggestions are still there.

 
Owner: mattreynolds@chromium.org
Status: Started (was: Available)
Looks like this is coming from ZeroSuggestProvider.
It's confusing that we could ever suggest *anything* on an empty input field, as something has to be the default suggestion, and the only default suggestion for empty input must be the null suggestion that doesn't navigate anywhere.  So at best I would think we'd have a dropdown that looks like:

<some sort of do-nothing placeholder>
... all other suggestions here ...
pkasting: we only need a null/placeholder suggestion if pressing enter goes nowhere.  If pressing enter/Go goes somewhere, then it makes sense that it goes to the top item on the list.  It's a little strange that the (empty) text in the omnibox doesn't align with the top suggestion--normally the text matches the top suggestions--but I think the case of an empty omnibox is special.  If want, you can start a thread or bug with the Chrome Android UI and PM folks.  (Please don't morph this bug.)  I imagine they'll say the same thing they said on bug 685329, which is basically "we don't have a strong opinion yet on suggestions on an empty omnibox; stay tuned."  And we'll leave the current behavior as-is (well, aside from this bug fix) until they tell us otherwise.
The omnibox text itself, without dropdown, should always give you a clue as to what will happen when you hit enter.  If pressing enter on an empty omnibox goes somewhere, that behavior needs to be changed.  Is that actually the case today?

I'm not intentionally trying to bugmorph, I think I'm just sufficiently unfamiliar with our current behavior that I may be unintentionally doing so.
> If pressing enter on an empty omnibox goes somewhere, that behavior
> needs to be changed.  Is that actually the case today?
It does on Android.  I don't know about iOS.  On other platforms, we don't offer suggestions on an empty omnibox.  But this is a bug morph.  Please either comment on bug 685329, which I mentioned, which is about the question of offering suggestions in the omnibox dropdown on an empty omnibox.  It's particular to the Android most visited question, though I'm comfortable with a bug morph there given how the discussion is going.  (It's general.)  Or start a new bug.

By the way, the only other possible empty omnibox suggestions are physical web suggestions and clipboard suggestions.  These both seem appropriate and important to give on an empty omnibox.
Yes, I'm fine giving suggestions on an empty omnibox, just not having hitting enter on an empty omnibox navigate somewhere.  I'll comment on bug 685329.
Cc: mattreynolds@chromium.org
Labels: -Pri-2 Pri-3
Owner: ----
Status: Available (was: Started)
Not pri-2.

Components: UI>Browser>Omnibox>ZeroSuggest
Still an issue.
Labels: Hotlist-Polish
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 27 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)
Still valid.
Owner: mdjones@chromium.org
Status: Assigned (was: Available)
Assigning to mdjones@, who claims he recently fixed it.
It looks like I didn't actually fix this, but since I'm working in this area and affects my current work, I'll look into it.

Sign in to add a comment