New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 685330 link

Starred by 1 user
Status: Verified
Owner:
nya@chromium.org
Closed: Jan 2017
Cc:
█ rookrishna@chromium.org
weifangsun@chromium.org
dhadd...@chromium.org
abod...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Files app: .wav audio file from ARC++ media is not detected

Project Member Reported by sdantul...@chromium.org, Jan 25 2017 
Google Chrome	57.0.2987.8 (Official Build) dev (32-bit)
Revision	0
Platform	9202.4.0 (Official Build) dev-channel veyron_minnie

What steps will reproduce the problem?
1. Install Easy Voice Recorder app https://play.google.com/store/apps/details?id=com.coffeebeanventures.easyvoicerecorder&hl=en
2. Record your voice. File is saved in .wav format in /storage/emulated/0/EasyVoiceRecorder/ path
3. Open ChromeOS Files app -> Audio folder

What happens ?
.wav file is not listed

Comment 1 by sdantul...@chromium.org, Jan 25 2017 

Also,

1. Open ARC++ File Manager app and copy the .wav file to /sdcard/Download folder.
2. Open ChromeOS Files App -> Audio folder

What happens ?
.wav file is now shown in Audio folder but cannot be played. Attached screenshot.
Screenshot 2017-01-25 at 12.04.05.png
1008 KB View Download

Comment 2 by weifangsun@chromium.org, Jan 25 2017

Owner: nya@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by nya@chromium.org, Jan 26 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/588a513a3772d7cc466568f9007780aee8251003

commit 588a513a3772d7cc466568f9007780aee8251003
Author: nya <nya@chromium.org>
Date: Fri Jan 27 10:22:00 2017

mediaview: Recognize more MIME types.

Android uses "audio/x-wav" MIME type to describe .wav files, while
Chromium knows "audio/wav" only. This patch adds hard-coded mapping
between MIME types and file name extensions taken from Android.

BUG= chromium:685330 
TEST=unit_tests
TEST=.wav files recognized in media views

Review-Url: https://codereview.chromium.org/2656973003
Cr-Commit-Position: refs/heads/master@{#446633}

[modify] https://crrev.com/588a513a3772d7cc466568f9007780aee8251003/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.cc
[modify] https://crrev.com/588a513a3772d7cc466568f9007780aee8251003/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.cc
[modify] https://crrev.com/588a513a3772d7cc466568f9007780aee8251003/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.h
[modify] https://crrev.com/588a513a3772d7cc466568f9007780aee8251003/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util_unittest.cc

Comment 5 by nya@chromium.org, Jan 27 2017

Status: Fixed (was: Started)
Fixed in ToT.

sdantuluri, could you verify please?

Comment 6 by sdantul...@chromium.org, Jan 30 2017 

Fix not in chrome 58.0.2994.0. Will verify once new chrome version is available.

Comment 7 by nya@chromium.org, Jan 31 2017

Labels: Merge-Request-57
It's working on Chrome ToT so I'll request merge to M57.

BTW, thanks sdantuluri@ for catching this!
Project Member

Comment 8 by sheriffbot@chromium.org, Jan 31 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 31 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8844a6395ed1a3fdfc09d12fe5b24437d4aa31ca

commit 8844a6395ed1a3fdfc09d12fe5b24437d4aa31ca
Author: Shuhei Takahashi <nya@chromium.org>
Date: Tue Jan 31 03:33:24 2017

mediaview: Recognize more MIME types.

Android uses "audio/x-wav" MIME type to describe .wav files, while
Chromium knows "audio/wav" only. This patch adds hard-coded mapping
between MIME types and file name extensions taken from Android.

BUG= chromium:685330 
TEST=unit_tests
TEST=.wav files recognized in media views

Review-Url: https://codereview.chromium.org/2656973003
Cr-Commit-Position: refs/heads/master@{#446633}
(cherry picked from commit 588a513a3772d7cc466568f9007780aee8251003)

Review-Url: https://codereview.chromium.org/2661003003 .
Cr-Commit-Position: refs/branch-heads/2987@{#215}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/8844a6395ed1a3fdfc09d12fe5b24437d4aa31ca/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.cc
[modify] https://crrev.com/8844a6395ed1a3fdfc09d12fe5b24437d4aa31ca/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.cc
[modify] https://crrev.com/8844a6395ed1a3fdfc09d12fe5b24437d4aa31ca/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.h
[modify] https://crrev.com/8844a6395ed1a3fdfc09d12fe5b24437d4aa31ca/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util_unittest.cc

Comment 10 by sdantul...@chromium.org, Feb 7 2017

Status: Verified (was: Fixed)
Verified on ChromeOS  9202.18.0, 57.0.2987.32
►

Sign in to add a comment