[WPT Export] Cr-Commit-Position is returning incorrect commit hash |
|||||
Issue descriptionI believe using Cr-Commit-Position causes us to skip over the second commit if two exportable commits exist close together enough. From what I understand this is because Cr-Commit-Position does not point exactly to the position of the commit that was upstreamed. We should retain a pointer to exactly the right Chromium commit when exporting commits to WPT. My idea to solve this problem is to attach another footer onto any commit we export: Cr-Original-Commit-Hash which will point unambiguously to the original commit in Chromium from whence it originated.
,
Jan 25 2017
Update: we believe this is caused by a bug in git crrev-parse. I believe the way crrev-parse works is that it looks for the latest commit with Cr-Commit-Position: $POSITION. Because the reverted commit contains the Cr-Commit-Position of the original commit, running crrev-parse on the original commit position will always return the reverted commit.
,
Jan 25 2017
Created a CL in depot_tools to fix the problem. Things are functioning normally with the patch. https://chromium-review.googlesource.com/#/c/433158/
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/056bef208a5ebbff9864a9db328fdcfaa20a934b commit 056bef208a5ebbff9864a9db328fdcfaa20a934b Author: Jeff Carpenter <jeffcarp@chromium.org> Date: Wed Jan 25 20:51:26 2017 Fix git-crrev-parse returning reverted commits instead of original commits Also delete extraneous whitespace BUG= 685326 Change-Id: If7f68346fd27edf9a5dca315cfcfbca0decc2da6 Reviewed-on: https://chromium-review.googlesource.com/433158 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/056bef208a5ebbff9864a9db328fdcfaa20a934b/git-crrev-parse
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/056bef208a5ebbff9864a9db328fdcfaa20a934b commit 056bef208a5ebbff9864a9db328fdcfaa20a934b Author: Jeff Carpenter <jeffcarp@chromium.org> Date: Wed Jan 25 20:51:26 2017 Fix git-crrev-parse returning reverted commits instead of original commits Also delete extraneous whitespace BUG= 685326 Change-Id: If7f68346fd27edf9a5dca315cfcfbca0decc2da6 Reviewed-on: https://chromium-review.googlesource.com/433158 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/056bef208a5ebbff9864a9db328fdcfaa20a934b/git-crrev-parse
,
Jan 26 2017
The bug in git crrev-parse has landed, closing.
,
Jul 3 2017
,
Jul 3 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jeffcarp@chromium.org
, Jan 25 2017