Add logging to help debug certificate errors when wrong cert is used |
|||||
Issue descriptionOne problem we have when using Third Party Auth in Chromoting is knowing which certificate was used for authentication. If an invalid cert is added and we choose it, we can't tell just from our logs. We should add logging to make this type of problem more discoverable and to simplify debugging.
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d455f537abf27da5289674bbf96814172404e89d commit d455f537abf27da5289674bbf96814172404e89d Author: joedow <joedow@chromium.org> Date: Thu Jan 26 00:26:40 2017 Adding logging for third party certificate tokens This is a simple change to log the issuer of the certificate we use for Third Party Auth to make debugging easier. BUG= 685322 Review-Url: https://codereview.chromium.org/2652353002 Cr-Commit-Position: refs/heads/master@{#446174} [modify] https://crrev.com/d455f537abf27da5289674bbf96814172404e89d/remoting/host/token_validator_base.cc
,
Jan 26 2017
Change only affect Chrome Remote Desktop, would like to get into M57 to help debug certificate problems in our next release.
,
Jan 27 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86c253338eff058420e7724e508f470ab1e461e8 commit 86c253338eff058420e7724e508f470ab1e461e8 Author: Joe Downing <joedow@google.com> Date: Fri Jan 27 00:37:47 2017 Adding logging for third party certificate tokens This is a simple change to log the issuer of the certificate we use for Third Party Auth to make debugging easier. BUG= 685322 Review-Url: https://codereview.chromium.org/2652353002 Cr-Commit-Position: refs/heads/master@{#446174} (cherry picked from commit d455f537abf27da5289674bbf96814172404e89d) Review-Url: https://codereview.chromium.org/2654433014 . Cr-Commit-Position: refs/branch-heads/2987@{#130} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/86c253338eff058420e7724e508f470ab1e461e8/remoting/host/token_validator_base.cc
,
Jan 27 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by joedow@chromium.org
, Jan 25 2017