New issue
Advanced search Search tips

Issue 685317 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: ----



Sign in to add a comment

Show download home for all users

Project Member Reported by qin...@chromium.org, Jan 25 2017

Issue description

There is no user outcry on download Home, we should enable it by default for all users.
 

Comment 1 by qin...@chromium.org, Jan 25 2017

Status: Started (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2476c81a93b0cb04c10c8186308fbb5cf1271627

commit 2476c81a93b0cb04c10c8186308fbb5cf1271627
Author: qinmin <qinmin@chromium.org>
Date: Thu Jan 26 20:09:26 2017

Enable download home by default

enable this for M57 and beyond

BUG= 685317 

Review-Url: https://codereview.chromium.org/2651233002
Cr-Commit-Position: refs/heads/master@{#446420}

[modify] https://crrev.com/2476c81a93b0cb04c10c8186308fbb5cf1271627/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/2476c81a93b0cb04c10c8186308fbb5cf1271627/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/2476c81a93b0cb04c10c8186308fbb5cf1271627/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/2476c81a93b0cb04c10c8186308fbb5cf1271627/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java
[modify] https://crrev.com/2476c81a93b0cb04c10c8186308fbb5cf1271627/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java
[modify] https://crrev.com/2476c81a93b0cb04c10c8186308fbb5cf1271627/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
[modify] https://crrev.com/2476c81a93b0cb04c10c8186308fbb5cf1271627/chrome/browser/about_flags.cc
[modify] https://crrev.com/2476c81a93b0cb04c10c8186308fbb5cf1271627/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/2476c81a93b0cb04c10c8186308fbb5cf1271627/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/2476c81a93b0cb04c10c8186308fbb5cf1271627/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
[modify] https://crrev.com/2476c81a93b0cb04c10c8186308fbb5cf1271627/chrome/browser/ntp_snippets/download_suggestions_provider.cc
[modify] https://crrev.com/2476c81a93b0cb04c10c8186308fbb5cf1271627/chrome/browser/ntp_snippets/download_suggestions_provider.h
[modify] https://crrev.com/2476c81a93b0cb04c10c8186308fbb5cf1271627/chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc

Comment 3 by qin...@chromium.org, Jan 26 2017

Labels: Merge-Request-57
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 26 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 27 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/941930450b33b6437c479f7129493d9ff994397e

commit 941930450b33b6437c479f7129493d9ff994397e
Author: Min Qin <qinmin@chromium.org>
Date: Fri Jan 27 22:32:55 2017

Enable download home by default

enable this for M57 and beyond

BUG= 685317 
TBR=dfalcantara@chromium.org,bauerb@chromium.org

Review-Url: https://codereview.chromium.org/2651233002
Cr-Commit-Position: refs/heads/master@{#446420}
(cherry picked from commit 2476c81a93b0cb04c10c8186308fbb5cf1271627)

Review-Url: https://codereview.chromium.org/2662623003 .
Cr-Commit-Position: refs/branch-heads/2987@{#158}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/941930450b33b6437c479f7129493d9ff994397e/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/941930450b33b6437c479f7129493d9ff994397e/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/941930450b33b6437c479f7129493d9ff994397e/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/941930450b33b6437c479f7129493d9ff994397e/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java
[modify] https://crrev.com/941930450b33b6437c479f7129493d9ff994397e/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java
[modify] https://crrev.com/941930450b33b6437c479f7129493d9ff994397e/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
[modify] https://crrev.com/941930450b33b6437c479f7129493d9ff994397e/chrome/browser/about_flags.cc
[modify] https://crrev.com/941930450b33b6437c479f7129493d9ff994397e/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/941930450b33b6437c479f7129493d9ff994397e/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/941930450b33b6437c479f7129493d9ff994397e/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
[modify] https://crrev.com/941930450b33b6437c479f7129493d9ff994397e/chrome/browser/ntp_snippets/download_suggestions_provider.cc
[modify] https://crrev.com/941930450b33b6437c479f7129493d9ff994397e/chrome/browser/ntp_snippets/download_suggestions_provider.h
[modify] https://crrev.com/941930450b33b6437c479f7129493d9ff994397e/chrome/browser/ntp_snippets/download_suggestions_provider_unittest.cc

verified on M57-57.0.2987.19

Comment 7 by ananthak@google.com, Apr 27 2017

Components: UI>Browser>Downloads
Status: Fixed (was: Started)

Sign in to add a comment