New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685308 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

storm: take down paladin builder

Project Member Reported by grundler@google.com, Jan 25 2017

Issue description

storm is the Google designed reference board for whirlwind and arkham projects. No new products are planned with this reference board in 2017.

storm builder (and related resources NOT used by whirlwind or arkham builders) can be "archived".
 
Cc: vapier@chromium.org caiz@chromium.org
Owner: dgarr...@chromium.org
Status: Assigned (was: Untriaged)
Owner: pprabhu@chromium.org
Passing to current deputy, it should be easy. ;>
Cc: dgarr...@chromium.org
Labels: -current-issue
Status: Started (was: Assigned)
These require a tryserver waterfall restart (low priority)
https://chromium-review.googlesource.com/#/c/433460/
https://chromium-review.googlesource.com/#/c/433461/

This requires a master restart (sort of high priority: till then the storm-paladin will just stay on the waterfall marked important, but not getting scheduled):
https://chromium-review.googlesource.com/#/c/433532/

This requires tryserver, release, branch waterfalls restart:
https://chromium-review.googlesource.com/#/c/433533/
https://chromium-review.googlesource.com/#/c/433917/

Please review the last CL in particular. Looks like we don't quite clean up entirely on removal of a board.



Cc: pprabhu@chromium.org
Owner: grundler@chromium.org
The last CL is not needed, instead we need to turn down goldeneye configs for storm first.

back to grundler: Currently, storm is set as a leader board. Perhaps it should be whirlwind going forward?
Please make the necessary changes at the goldeneye console https://cros-goldeneye.corp.google.com/jetstream/console/listBuildConfig

In particular:
- make sure storm is not marked important / leader board
- make sure you have alternative boards with the coverage.

I'm not doing this myself because I'm not sure who the new leader should be etc.

You can then assign this bug back to me, and I'll land my CLs
gale is also set as a leader board.

PS: leader really means "enhanced testing".

Comment 6 by grundler@google.com, Jan 27 2017

pprabhu,
I have no idea what a "leader board" is outside of the context of video games. :)

storm is the reference board used for whirlwind/arkham devices but we've never shipped storm to customers and there is no plan to do _anything_ with storm at this time. It appears to be dead. I was expecting that we could turn down resources that are related to it.

Are whirlwind and arkham leveraging build artifacts from storm builds?
If yes, then perhaps we won't be saving as much as I expected from turning storm builder down.

gale is a different chipset (IPQ4019) than the rest. Storm, whirlwind, and arkham are based on IPQ8064.

I'll look into the links you provided tomorrow. The right answer might be making whirlwind the leader for arkham instead.

Comment 7 by dgarrett@google.com, Jan 27 2017

Leader is normally managed by TPMs, but I'm not certain who the right TPM is here.

whirlwind sounds like an excellent choice.


Owner: pprabhu@chromium.org
OK, changes in goldeneye:

- Add: whirlwind leaderboard
- Remove: storm leaderboard
- Remove: storm active

I'll wait for this config to make it to cbuildbot, and also to make sure that whirlwind correctly weathers the extra testing that leaderboards get.
cbuildbot config has been updated, whirlwind-release is looking OK.

First two CLs are in flight now:
https://chromium-review.googlesource.com/#/c/433460/
https://chromium-review.googlesource.com/#/c/433461/
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/4210bd434051aa615afad3ae5328bde766c4de6d

commit 4210bd434051aa615afad3ae5328bde766c4de6d
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Fri Feb 03 20:37:37 2017

chromeos_config: Use whirlwind for pre-cq

This CL is part of the storm builders turndown.

BUG= chromium:685308 
TEST=unittests.

Change-Id: Ie7c11893cda739589927e676e43cbc1c9b811905
Reviewed-on: https://chromium-review.googlesource.com/433460
Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/4210bd434051aa615afad3ae5328bde766c4de6d/cbuildbot/config_dump.json
[modify] https://crrev.com/4210bd434051aa615afad3ae5328bde766c4de6d/cbuildbot/waterfall_layout_dump.txt
[modify] https://crrev.com/4210bd434051aa615afad3ae5328bde766c4de6d/cbuildbot/chromeos_config.py

Project Member

Comment 11 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f90ce6580c04f63815e3603834095902c35de445

commit f90ce6580c04f63815e3603834095902c35de445
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Fri Feb 03 20:37:37 2017

chromeos_config: Use whirlwind for kernel_3.14 pre-cq.

This CL is part of the storm builder turndown.

BUG= chromium:685308 
TEST=unittests.

Change-Id: Ia2d40d487ed5346ca553b393f62c80b5cea8a9a9
Reviewed-on: https://chromium-review.googlesource.com/433461
Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/f90ce6580c04f63815e3603834095902c35de445/cbuildbot/config_dump.json
[modify] https://crrev.com/f90ce6580c04f63815e3603834095902c35de445/cbuildbot/waterfall_layout_dump.txt
[modify] https://crrev.com/f90ce6580c04f63815e3603834095902c35de445/cbuildbot/chromeos_config.py

Project Member

Comment 12 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/6d323e29fc0530b4e9b5617de3d12fcd17178145

commit 6d323e29fc0530b4e9b5617de3d12fcd17178145
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Thu Feb 09 00:24:32 2017

chromeos_config: Remove storm-paladin

This is part of the storm builders turndown.
This CL requires a waterfall restart.

BUG= chromium:685308 
TEST=unittests.

Change-Id: If323c9d4a1fc2d7b3dc48d4b8590615ba683b05f
Reviewed-on: https://chromium-review.googlesource.com/433532
Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/6d323e29fc0530b4e9b5617de3d12fcd17178145/cbuildbot/config_dump.json
[modify] https://crrev.com/6d323e29fc0530b4e9b5617de3d12fcd17178145/cbuildbot/waterfall_layout_dump.txt
[modify] https://crrev.com/6d323e29fc0530b4e9b5617de3d12fcd17178145/cbuildbot/chromeos_config_unittest.py
[modify] https://crrev.com/6d323e29fc0530b4e9b5617de3d12fcd17178145/cbuildbot/chromeos_config.py

Project Member

Comment 13 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/129fb8aae609f23e39c2a71c71983854e1b3d860

commit 129fb8aae609f23e39c2a71c71983854e1b3d860
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Thu Feb 16 23:39:32 2017

chromeos_config: Cull remaining storm builders.

BUG= chromium:685308 
TEST=unittests

Change-Id: Ie6063789dbac7bcffc3e7c58a885364f7d8ea5bf
Reviewed-on: https://chromium-review.googlesource.com/433533
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Commit-Queue: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/129fb8aae609f23e39c2a71c71983854e1b3d860/cbuildbot/config_dump.json
[modify] https://crrev.com/129fb8aae609f23e39c2a71c71983854e1b3d860/cbuildbot/waterfall_layout_dump.txt
[modify] https://crrev.com/129fb8aae609f23e39c2a71c71983854e1b3d860/cbuildbot/chromeos_config.py

CL 316239 is failing with:
No configuration target found for storm-pre-cq.
You can check the available configs by running `cbuildbot --list --all`.
The config may have been changed or removed, you can try to rebase your CL so it can get re-screened by the Pre-cq-launcher.

I'll try to rebase...but can I assume it's due to changes above?

Failing CL:
https://chrome-internal-review.googlesource.com/c/316239/
Status: Fixed (was: Started)

Comment 17 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment