New issue
Advanced search Search tips

Issue 685294 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: revert the Timeline->Performance rename in beta/stable M57.

Project Member Reported by pfeldman@chromium.org, Jan 25 2017

Issue description

We'll re-apply the change for M58, but would like to keep existing M56 behavior in M57.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/965cfcc7364062072a9dd574e39073f0f0d67abe

commit 965cfcc7364062072a9dd574e39073f0f0d67abe
Author: pfeldman <pfeldman@chromium.org>
Date: Wed Jan 25 22:21:42 2017

DevTools: temporarily revert Timeline->Performance rename.

BUG= 685294 

Review-Url: https://codereview.chromium.org/2657893002
Cr-Commit-Position: refs/heads/master@{#446141}

[modify] https://crrev.com/965cfcc7364062072a9dd574e39073f0f0d67abe/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-profile-removal.html
[modify] https://crrev.com/965cfcc7364062072a9dd574e39073f0f0d67abe/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-save-load.html
[modify] https://crrev.com/965cfcc7364062072a9dd574e39073f0f0d67abe/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-stopped-removed-race.html
[modify] https://crrev.com/965cfcc7364062072a9dd574e39073f0f0d67abe/third_party/WebKit/LayoutTests/inspector/profiler/profiler-test.js
[modify] https://crrev.com/965cfcc7364062072a9dd574e39073f0f0d67abe/third_party/WebKit/LayoutTests/inspector/user-metrics-expected.txt
[modify] https://crrev.com/965cfcc7364062072a9dd574e39073f0f0d67abe/third_party/WebKit/LayoutTests/inspector/user-metrics.html
[modify] https://crrev.com/965cfcc7364062072a9dd574e39073f0f0d67abe/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfilerPanel.js
[modify] https://crrev.com/965cfcc7364062072a9dd574e39073f0f0d67abe/third_party/WebKit/Source/devtools/front_end/profiler/module.json
[modify] https://crrev.com/965cfcc7364062072a9dd574e39073f0f0d67abe/third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css
[modify] https://crrev.com/965cfcc7364062072a9dd574e39073f0f0d67abe/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
[modify] https://crrev.com/965cfcc7364062072a9dd574e39073f0f0d67abe/third_party/WebKit/Source/devtools/front_end/timeline/module.json
[modify] https://crrev.com/965cfcc7364062072a9dd574e39073f0f0d67abe/third_party/WebKit/Source/devtools/front_end/ui/ShortcutsScreen.js

Labels: Merge-Request-57
We are postponing the launch of the new Performance panel. This change reverts r435488 and its minor follow-ups. Most of the changes are to the tests, actual code changes are limited to text labels in the UI and descriptors. It is safe to land on branch.

We'll keep it on Canary for a couple of days and merge into M57 after.
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 26 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by gov...@chromium.org, Jan 27 2017

Pls merge your change to M57 branch 2987 before 5:00 PM PT Monday (01/30) so we can pick it up for next week Last M57  Dev release. Thank you.
Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 27 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1f643460cb769d67ebde046185f5c99f066c716

commit b1f643460cb769d67ebde046185f5c99f066c716
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Fri Jan 27 21:50:38 2017

DevTools: temporarily revert Timeline->Performance rename.

BUG= 685294 

Review-Url: https://codereview.chromium.org/2657893002
Cr-Commit-Position: refs/heads/master@{#446141}
(cherry picked from commit 965cfcc7364062072a9dd574e39073f0f0d67abe)

Review-Url: https://codereview.chromium.org/2657873008 .
Cr-Commit-Position: refs/branch-heads/2987@{#156}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/b1f643460cb769d67ebde046185f5c99f066c716/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-profile-removal.html
[modify] https://crrev.com/b1f643460cb769d67ebde046185f5c99f066c716/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-save-load.html
[modify] https://crrev.com/b1f643460cb769d67ebde046185f5c99f066c716/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-stopped-removed-race.html
[modify] https://crrev.com/b1f643460cb769d67ebde046185f5c99f066c716/third_party/WebKit/LayoutTests/inspector/profiler/profiler-test.js
[modify] https://crrev.com/b1f643460cb769d67ebde046185f5c99f066c716/third_party/WebKit/LayoutTests/inspector/user-metrics-expected.txt
[modify] https://crrev.com/b1f643460cb769d67ebde046185f5c99f066c716/third_party/WebKit/LayoutTests/inspector/user-metrics.html
[modify] https://crrev.com/b1f643460cb769d67ebde046185f5c99f066c716/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfilerPanel.js
[modify] https://crrev.com/b1f643460cb769d67ebde046185f5c99f066c716/third_party/WebKit/Source/devtools/front_end/profiler/module.json
[modify] https://crrev.com/b1f643460cb769d67ebde046185f5c99f066c716/third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css
[modify] https://crrev.com/b1f643460cb769d67ebde046185f5c99f066c716/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
[modify] https://crrev.com/b1f643460cb769d67ebde046185f5c99f066c716/third_party/WebKit/Source/devtools/front_end/timeline/module.json
[modify] https://crrev.com/b1f643460cb769d67ebde046185f5c99f066c716/third_party/WebKit/Source/devtools/front_end/ui/ShortcutsScreen.js

Sign in to add a comment