Login View/Model should have a simpler binding mechanism |
|
Issue descriptionLogin View/Model should have a simpler binding mechanism Right now external code is responsible for binding the View to the Model and the Model to the View. The external code is also responsible for doing the unbinding. Since these two classes types live in unison, we should make binding simpler and more robust by moving the binding logic into some common parent types. Unbinding should happen automatically when either the Model or View goes down (potentially using WeakPtr).
,
Mar 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbf043b1bde50e64a940da7afcc6ec3a4abb3dbd commit fbf043b1bde50e64a940da7afcc6ec3a4abb3dbd Author: jdufault <jdufault@chromium.org> Date: Thu Mar 09 19:31:36 2017 cros: Remove CoreOobeHandler::Delegate. It was only used for communication within the JS layer, and CoreOobeHandler already has access to the only implementer, OobeUI. BUG=685287 Review-Url: https://codereview.chromium.org/2731103002 Cr-Commit-Position: refs/heads/master@{#455829} [modify] https://crrev.com/fbf043b1bde50e64a940da7afcc6ec3a4abb3dbd/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc [modify] https://crrev.com/fbf043b1bde50e64a940da7afcc6ec3a4abb3dbd/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h [modify] https://crrev.com/fbf043b1bde50e64a940da7afcc6ec3a4abb3dbd/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc [modify] https://crrev.com/fbf043b1bde50e64a940da7afcc6ec3a4abb3dbd/chrome/browser/ui/webui/chromeos/login/oobe_ui.h |
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, Mar 4 2017