New issue
Advanced search Search tips

Issue 685283 link

Starred by 1 user
Status: Fixed
Owner:
l...@chromium.org
Closed: Nov 2017
Cc:
einbinder@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: better execution contexts/filtering in DevTools console

Project Member Reported by l...@chromium.org, Jan 25 2017 
The current context selector dropdown in console does 2 things:
- only shows messages from the current selected context visible (when 'Show all messages' is not checked)
- sets the execution context for evaluations from the prompt

Proposal: console prompt can have its own execution context selector on the right.  This leaves the selector in the toolbar responsible for visibility only.  We can then remove the 'Show all messages' checkbox and use an 'all' option in the dropdown.

Questions:
- When you choose to view messages from context A, do you expect the prompt context to change to context A as well?
- When you change the prompt to context B, do you expect the visibility selector to filter out all messages that do not come from context B?

Comment 1 by l...@chromium.org, May 11 2017

Cc: einbinder@chromium.org
Another proposal: extending filter text processing to be more like Network Panel's.  e.g. "-domain:foo.com" to exclude messages whose domain is 'foo.com'
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5aae6a0af645a97f75ea980ae9bb839c26f1da35

commit 5aae6a0af645a97f75ea980ae9bb839c26f1da35
Author: Erik Luo <luoe@chromium.org>
Date: Thu Aug 17 00:52:23 2017

DevTools: generalize network's filter query parser

This CL generalizes functionality in Network's filter bar that parses
"url:foo.js" into {key: "url", value: "foo.js"}. Also, this replaces
the regex checkbox and instead treats any text wrapped in '/' as
regular expression.

"/images/" with regex checked will now be done as "/\/images\//".
The plan is to have Console's filter bar make use of this logic.

Bug:  685283 
Change-Id: I0a76031ae7da3b11b4a9e100bc65a3e1e82d28a7
Reviewed-on: https://chromium-review.googlesource.com/607528
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495018}
[modify] https://crrev.com/5aae6a0af645a97f75ea980ae9bb839c26f1da35/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[add] https://crrev.com/5aae6a0af645a97f75ea980ae9bb839c26f1da35/third_party/WebKit/LayoutTests/http/tests/inspector-unit/parse-filter-query-expected.txt
[add] https://crrev.com/5aae6a0af645a97f75ea980ae9bb839c26f1da35/third_party/WebKit/LayoutTests/http/tests/inspector-unit/parse-filter-query.js
[modify] https://crrev.com/5aae6a0af645a97f75ea980ae9bb839c26f1da35/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-filters.html
[delete] https://crrev.com/3e91d7d3da5cbe49b18e6216065f3ef584d62b2f/third_party/WebKit/LayoutTests/inspector/network/network-filter-parser-expected.txt
[delete] https://crrev.com/3e91d7d3da5cbe49b18e6216065f3ef584d62b2f/third_party/WebKit/LayoutTests/inspector/network/network-filter-parser.html
[modify] https://crrev.com/5aae6a0af645a97f75ea980ae9bb839c26f1da35/third_party/WebKit/Source/devtools/front_end/network/FilterSuggestionBuilder.js
[modify] https://crrev.com/5aae6a0af645a97f75ea980ae9bb839c26f1da35/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/5aae6a0af645a97f75ea980ae9bb839c26f1da35/third_party/WebKit/Source/devtools/front_end/text_utils/TextUtils.js
[modify] https://crrev.com/5aae6a0af645a97f75ea980ae9bb839c26f1da35/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js
[modify] https://crrev.com/5aae6a0af645a97f75ea980ae9bb839c26f1da35/third_party/WebKit/Source/devtools/front_end/ui/filter.css
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21a88f9a929c087970eed33b78e20fc43766182f

commit 21a88f9a929c087970eed33b78e20fc43766182f
Author: Erik Luo <luoe@chromium.org>
Date: Wed Aug 23 00:54:18 2017

DevTools: have console filter use query parser

Enables the use of 'url:foo.js' style queries in the console filter bar,
once exclusive to Network panel's filter. Also brings over the ability
to make negative queries:
-foo
foo -/bar*/

Screenshot: http://imgur.com/a/RAPUP

Bug:  685283 
Change-Id: Ib79f68649df92714740aea1f1c36eeb1331f19cc
Reviewed-on: https://chromium-review.googlesource.com/625236
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496532}
[modify] https://crrev.com/21a88f9a929c087970eed33b78e20fc43766182f/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-test-expected.txt
[modify] https://crrev.com/21a88f9a929c087970eed33b78e20fc43766182f/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-test.js
[modify] https://crrev.com/21a88f9a929c087970eed33b78e20fc43766182f/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/21a88f9a929c087970eed33b78e20fc43766182f/third_party/WebKit/Source/devtools/front_end/text_utils/TextUtils.js
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8103a3311e4900b7f840cabb5bc33cd7927eeab5

commit 8103a3311e4900b7f840cabb5bc33cd7927eeab5
Author: Erik Luo <luoe@chromium.org>
Date: Sat Aug 26 02:50:34 2017

DevTools: show counters for each sidebar group

This CL adds upon the Log Management experiment by adding counters to
each group, showing little icons with the number of info/warn/error
messages from each group.

Screenshot: http://imgur.com/a/wRmrI

Bug:  685283 
Change-Id: I8180dc849ee6e8f9ba4c84fff63389a5f3848903
Reviewed-on: https://chromium-review.googlesource.com/631056
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497641}
[modify] https://crrev.com/8103a3311e4900b7f840cabb5bc33cd7927eeab5/third_party/WebKit/Source/devtools/front_end/console/ConsoleSidebar.js
[modify] https://crrev.com/8103a3311e4900b7f840cabb5bc33cd7927eeab5/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/8103a3311e4900b7f840cabb5bc33cd7927eeab5/third_party/WebKit/Source/devtools/front_end/console/consoleSidebar.css
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/752b7f76a61ac0a882f6151a81b805df61edfbb4

commit 752b7f76a61ac0a882f6151a81b805df61edfbb4
Author: Erik Luo <luoe@chromium.org>
Date: Fri Sep 08 23:01:25 2017

DevTools: filter by source and context in console filter bar

This introduces new named filters for the console filter bar: 'context'
and 'source', corresponding to a message's context name and source name.

Only the 'source' requires an exact match, since it has a small set of
of values. E.g. 'source:work' will not match 'worker' or 'network'.

Bug:  685283 
Change-Id: I9733a6ee1f193e20b7fc67c6ba3f22d302c64a81
Reviewed-on: https://chromium-review.googlesource.com/654072
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500724}
[modify] https://crrev.com/752b7f76a61ac0a882f6151a81b805df61edfbb4/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-test-expected.txt
[modify] https://crrev.com/752b7f76a61ac0a882f6151a81b805df61edfbb4/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-test.js
[modify] https://crrev.com/752b7f76a61ac0a882f6151a81b805df61edfbb4/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/752b7f76a61ac0a882f6151a81b805df61edfbb4/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a57d5aa65194cc780ab7039d97aa33d11c6d6585

commit a57d5aa65194cc780ab7039d97aa33d11c6d6585
Author: Erik Luo <luoe@chromium.org>
Date: Mon Sep 25 20:18:19 2017

DevTools: ToolbarInput should use TextPrompt

This CL replaces the <input> used in ToolbarInput with a TextPrompt. It
is in preparation to allow all ToolbarInputs to use autocomplete
suggestions.

Bug:  685283 
Change-Id: I9df985d5b414ceb37079610a77143ca53346975c
Reviewed-on: https://chromium-review.googlesource.com/662400
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504148}
[modify] https://crrev.com/a57d5aa65194cc780ab7039d97aa33d11c6d6585/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/a57d5aa65194cc780ab7039d97aa33d11c6d6585/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
[modify] https://crrev.com/a57d5aa65194cc780ab7039d97aa33d11c6d6585/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
[modify] https://crrev.com/a57d5aa65194cc780ab7039d97aa33d11c6d6585/third_party/WebKit/Source/devtools/front_end/ui/toolbar.css
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/330dab70cfe979e1a9665b61971b3024315c46ae

commit 330dab70cfe979e1a9665b61971b3024315c46ae
Author: Erik Luo <luoe@chromium.org>
Date: Mon Oct 02 19:31:50 2017

DevTools: generalize ConsoleFilter for use by ConsoleSidebar and filter bar

This CL introduces a ConsoleFilter that can be applied to a
ConsoleViewMessage. With this general struct, ConsoleSidebar and the
console filter text input can both produce their own ConsoleFilter.

Bug:  685283 
Change-Id: Ie6ff87beb5b82acdd6a924a256aa69fa14f67614
Reviewed-on: https://chromium-review.googlesource.com/636457
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505720}
[modify] https://crrev.com/330dab70cfe979e1a9665b61971b3024315c46ae/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-level-test.js
[modify] https://crrev.com/330dab70cfe979e1a9665b61971b3024315c46ae/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-test-expected.txt
[modify] https://crrev.com/330dab70cfe979e1a9665b61971b3024315c46ae/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-test.js
[modify] https://crrev.com/330dab70cfe979e1a9665b61971b3024315c46ae/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-tests.js
[modify] https://crrev.com/330dab70cfe979e1a9665b61971b3024315c46ae/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js
[modify] https://crrev.com/330dab70cfe979e1a9665b61971b3024315c46ae/third_party/WebKit/Source/devtools/BUILD.gn
[add] https://crrev.com/330dab70cfe979e1a9665b61971b3024315c46ae/third_party/WebKit/Source/devtools/front_end/console/ConsoleFilter.js
[modify] https://crrev.com/330dab70cfe979e1a9665b61971b3024315c46ae/third_party/WebKit/Source/devtools/front_end/console/ConsoleSidebar.js
[modify] https://crrev.com/330dab70cfe979e1a9665b61971b3024315c46ae/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/330dab70cfe979e1a9665b61971b3024315c46ae/third_party/WebKit/Source/devtools/front_end/console/module.json
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db58678d52c048df084359b377adb1e0dffe1eb5

commit db58678d52c048df084359b377adb1e0dffe1eb5
Author: Erik Luo <luoe@chromium.org>
Date: Fri Oct 13 21:20:44 2017

DevTools: generalize filter suggestion builder part 1

The goal of this CL is to remove network-specific sorting logic from
FilterSuggestionBuilder, in order to allow console to use it.

Part 2 is simply to move to a new location. This makes it easier
to review part 1.

Bug:  685283 
Change-Id: I50d5632e97a646f4204016a5eae41d3cfe7b17a2
Reviewed-on: https://chromium-review.googlesource.com/669762
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508823}
[modify] https://crrev.com/db58678d52c048df084359b377adb1e0dffe1eb5/third_party/WebKit/Source/devtools/front_end/network/FilterSuggestionBuilder.js
[modify] https://crrev.com/db58678d52c048df084359b377adb1e0dffe1eb5/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6ad4a6441363fd8ae0df1fcec18e792612255d2

commit d6ad4a6441363fd8ae0df1fcec18e792612255d2
Author: Erik Luo <luoe@chromium.org>
Date: Fri Oct 13 21:28:09 2017

DevTools: filter settings should use ConsoleFilter

Filter settings appear in console UI, such as the
"Hide network messages" checkbox. Now,
- these settings are built using ConsoleFilter
- ConsoleViewFilter (CVF) no longer depends on ConsoleSidebar.
  Instead, ConsoleView calls sidebar.applyFilters(), and CVF acts only
  as a controller owning settings and text input filter.

Bug:  685283 
Change-Id: I266a1656748d6c9db24c5420e1cd7930ee7279da
Reviewed-on: https://chromium-review.googlesource.com/696439
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508825}
[modify] https://crrev.com/d6ad4a6441363fd8ae0df1fcec18e792612255d2/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-level-test.js
[modify] https://crrev.com/d6ad4a6441363fd8ae0df1fcec18e792612255d2/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-test.js
[modify] https://crrev.com/d6ad4a6441363fd8ae0df1fcec18e792612255d2/third_party/WebKit/Source/devtools/front_end/console/ConsoleFilter.js
[modify] https://crrev.com/d6ad4a6441363fd8ae0df1fcec18e792612255d2/third_party/WebKit/Source/devtools/front_end/console/ConsoleSidebar.js
[modify] https://crrev.com/d6ad4a6441363fd8ae0df1fcec18e792612255d2/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1eff80a625bd2a48a24bd2927ac67468489e8e61

commit 1eff80a625bd2a48a24bd2927ac67468489e8e61
Author: Erik Luo <luoe@chromium.org>
Date: Sat Oct 14 02:44:01 2017

DevTools: autocomplete in console filter bar

Screenshot: https://imgur.com/a/YTEni

Bug:  685283 
Change-Id: I533984d475d05858114e0402a00b1cd60b9ac028
Reviewed-on: https://chromium-review.googlesource.com/719400
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508917}
[modify] https://crrev.com/1eff80a625bd2a48a24bd2927ac67468489e8e61/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/1eff80a625bd2a48a24bd2927ac67468489e8e61/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/1eff80a625bd2a48a24bd2927ac67468489e8e61/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js
[delete] https://crrev.com/0ff7688d1d4cb6da35e5989462d1d54488ddabf1/third_party/WebKit/Source/devtools/front_end/network/FilterSuggestionBuilder.js
[modify] https://crrev.com/1eff80a625bd2a48a24bd2927ac67468489e8e61/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/1eff80a625bd2a48a24bd2927ac67468489e8e61/third_party/WebKit/Source/devtools/front_end/network/module.json
[add] https://crrev.com/1eff80a625bd2a48a24bd2927ac67468489e8e61/third_party/WebKit/Source/devtools/front_end/ui/FilterSuggestionBuilder.js
[modify] https://crrev.com/1eff80a625bd2a48a24bd2927ac67468489e8e61/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
[modify] https://crrev.com/1eff80a625bd2a48a24bd2927ac67468489e8e61/third_party/WebKit/Source/devtools/front_end/ui/module.json
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8828b31daab01fcc8922bbd7d3b083128eb73a0f

commit 8828b31daab01fcc8922bbd7d3b083128eb73a0f
Author: Erik Luo <luoe@chromium.org>
Date: Tue Oct 17 21:51:59 2017

DevTools: switch list to treeoutline for log management UI, part 1

This CL pivots the log management UI to use a tree instead of a list.
- Introduces SidebarLevelByUrlGroups, which contain SidebarItems
- Adding a single message will let groups create SidebarItem children
- Sidebar's applyFilter lets Groups choose which children to apply to

Some messages have no 'url' such as evaluations, and will be addressed
in a future CL.

Counters and styles will be introduced in a followup.

Bug:  685283 
Change-Id: I0335138c89ba3d4ff81dcbb3a88787e8ac0fa395
Reviewed-on: https://chromium-review.googlesource.com/719389
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509554}
[add] https://crrev.com/8828b31daab01fcc8922bbd7d3b083128eb73a0f/third_party/WebKit/LayoutTests/http/tests/devtools/console-sidebar/console-filter-sidebar-expected.txt
[add] https://crrev.com/8828b31daab01fcc8922bbd7d3b083128eb73a0f/third_party/WebKit/LayoutTests/http/tests/devtools/console-sidebar/console-filter-sidebar.js
[add] https://crrev.com/8828b31daab01fcc8922bbd7d3b083128eb73a0f/third_party/WebKit/LayoutTests/http/tests/devtools/console-sidebar/resources/log-source.js
[modify] https://crrev.com/8828b31daab01fcc8922bbd7d3b083128eb73a0f/third_party/WebKit/Source/devtools/front_end/console/ConsoleFilter.js
[modify] https://crrev.com/8828b31daab01fcc8922bbd7d3b083128eb73a0f/third_party/WebKit/Source/devtools/front_end/console/ConsoleSidebar.js
[modify] https://crrev.com/8828b31daab01fcc8922bbd7d3b083128eb73a0f/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/8828b31daab01fcc8922bbd7d3b083128eb73a0f/third_party/WebKit/Source/devtools/front_end/console/consoleSidebar.css
[modify] https://crrev.com/8828b31daab01fcc8922bbd7d3b083128eb73a0f/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/8828b31daab01fcc8922bbd7d3b083128eb73a0f/third_party/WebKit/Source/devtools/front_end/text_utils/TextUtils.js
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/859ffed5f5caaaa08df4611d81a13a013e2d25b8

commit 859ffed5f5caaaa08df4611d81a13a013e2d25b8
Author: Erik Luo <luoe@chromium.org>
Date: Wed Oct 18 09:48:40 2017

DevTools: reintroduce counters for sidebar items, part 2

This adds counters to each sidebar item, revealing the number of
messages within.

Screenshot: https://imgur.com/a/o4pSF

Bug:  685283 
Change-Id: Iee551c44506d9949b6a1a143ec6650cb12c9f728
Reviewed-on: https://chromium-review.googlesource.com/719958
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509726}
[modify] https://crrev.com/859ffed5f5caaaa08df4611d81a13a013e2d25b8/third_party/WebKit/LayoutTests/http/tests/devtools/console-sidebar/console-filter-sidebar-expected.txt
[modify] https://crrev.com/859ffed5f5caaaa08df4611d81a13a013e2d25b8/third_party/WebKit/Source/devtools/front_end/Images/smallIcons.png
[modify] https://crrev.com/859ffed5f5caaaa08df4611d81a13a013e2d25b8/third_party/WebKit/Source/devtools/front_end/Images/smallIcons_2x.png
[modify] https://crrev.com/859ffed5f5caaaa08df4611d81a13a013e2d25b8/third_party/WebKit/Source/devtools/front_end/Images/src/optimize_png.hashes
[modify] https://crrev.com/859ffed5f5caaaa08df4611d81a13a013e2d25b8/third_party/WebKit/Source/devtools/front_end/Images/src/smallIcons.svg
[modify] https://crrev.com/859ffed5f5caaaa08df4611d81a13a013e2d25b8/third_party/WebKit/Source/devtools/front_end/Images/src/svg2png.hashes
[modify] https://crrev.com/859ffed5f5caaaa08df4611d81a13a013e2d25b8/third_party/WebKit/Source/devtools/front_end/console/ConsoleFilter.js
[modify] https://crrev.com/859ffed5f5caaaa08df4611d81a13a013e2d25b8/third_party/WebKit/Source/devtools/front_end/console/ConsoleSidebar.js
[modify] https://crrev.com/859ffed5f5caaaa08df4611d81a13a013e2d25b8/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/859ffed5f5caaaa08df4611d81a13a013e2d25b8/third_party/WebKit/Source/devtools/front_end/console/consoleSidebar.css
[modify] https://crrev.com/859ffed5f5caaaa08df4611d81a13a013e2d25b8/third_party/WebKit/Source/devtools/front_end/ui/Icon.js
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3c841365bbe180bdd622e1b8b9775508d4bbe6e

commit e3c841365bbe180bdd622e1b8b9775508d4bbe6e
Author: Erik Luo <luoe@chromium.org>
Date: Fri Oct 20 03:13:07 2017

DevTools: iterate on log management ui

When the experiment is on,
- "User messages only" checkbox is replaced with "user messages" group
- Sidebar groups are not expanded by default
- Level dropdown is visible when sidebar is not. They are mutually
  exclusive and toggling sidebar will trigger a list refresh.

Bug:  685283 
Change-Id: Ib75a4b7dd58302337afea875853ca482a027d962
Reviewed-on: https://chromium-review.googlesource.com/726410
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510315}
[modify] https://crrev.com/e3c841365bbe180bdd622e1b8b9775508d4bbe6e/third_party/WebKit/LayoutTests/http/tests/devtools/console-sidebar/console-filter-sidebar-expected.txt
[modify] https://crrev.com/e3c841365bbe180bdd622e1b8b9775508d4bbe6e/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-level-test.js
[modify] https://crrev.com/e3c841365bbe180bdd622e1b8b9775508d4bbe6e/third_party/WebKit/Source/devtools/front_end/console/ConsoleSidebar.js
[modify] https://crrev.com/e3c841365bbe180bdd622e1b8b9775508d4bbe6e/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/e3c841365bbe180bdd622e1b8b9775508d4bbe6e/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js
[modify] https://crrev.com/e3c841365bbe180bdd622e1b8b9775508d4bbe6e/third_party/WebKit/Source/devtools/front_end/mobile_throttling/ThrottlingManager.js
[modify] https://crrev.com/e3c841365bbe180bdd622e1b8b9775508d4bbe6e/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
[modify] https://crrev.com/e3c841365bbe180bdd622e1b8b9775508d4bbe6e/third_party/WebKit/Source/devtools/front_end/ui/toolbar.css

Comment 14 by zac.spit...@gmail.com, Nov 3 2017 

this is great! but blackboxing isn't being respected, the blackboxed script source is showing in the sidebar, but not in the console pane. 

I had to remove and reapply the blackbox to get it working in the console pane as per https://bugs.chromium.org/p/chromium/issues/detail?id=762123

Comment 15 by l...@chromium.org, Nov 3 2017 

That's a good catch, I've filed a separate bug for blackboxing in sidebar (  https://crbug.com/781319  ).  It *should be a clear fix, since DevTools frontend can check whether URLs are blackboxed.

Regarding the other bug you linked, ( #762123 ), I haven't had any luck getting the issue to reproduce, unfortunately.  Still looking for a repro there.

Comment 16 by l...@chromium.org, Nov 7 2017

Status: Fixed (was: Assigned)
Closing this issue for now, as the sidebar has landed, experiment is no longer hidden, and there is no major feature work planned.  Please feel free to comment here with feedback or open new issues!
►

Sign in to add a comment