New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685258 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

[Windows][Host] Disable DX Capturer by default

Project Member Reported by joedow@chromium.org, Jan 25 2017

Issue description

We should disable the DX Capturer (prefer the GDI capturer) until  crbug.com/684937  is understood and fixed.

 

Comment 1 by joedow@chromium.org, Jan 25 2017

Status: Started (was: Assigned)
Blocking: 679523
Blocking: -679523
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76a10b17535c0456f042817a69fa036f226b26a3

commit 76a10b17535c0456f042817a69fa036f226b26a3
Author: joedow <joedow@chromium.org>
Date: Wed Jan 25 21:04:26 2017

Disable DX Capturer to unblock testing

A bug was found yesterday ( crbug.com/684937 ) when prevents users from logging
into Me2Me connections on Windows when using the DX capturer.  The original
author is on vacation so we are going to disable this functionality to unblock
testing of M57 builds and development on M58 builds.

BUG= 685258 

Review-Url: https://codereview.chromium.org/2652073004
Cr-Commit-Position: refs/heads/master@{#446117}

[modify] https://crrev.com/76a10b17535c0456f042817a69fa036f226b26a3/remoting/host/desktop_environment_options.cc

Comment 5 by joedow@chromium.org, Jan 25 2017

Labels: Merge-Request-57

Comment 6 by joedow@chromium.org, Jan 25 2017

This change does not affect the Chrome browser, only Chrome Remote Desktop.

It disables a feature which was first enabled in M57 but we want to turn it off for that release due to some recently found issues.
Project Member

Comment 7 by sheriffbot@chromium.org, Jan 26 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by gov...@chromium.org, Jan 26 2017

If possible, pls merge your change to M57 branch 2987 before 5:00 PM PT today (Thursday, 01/26) so we can pick it for tomorrow's Dev release.
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 26 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/068230f6448595391cf6bcfba114edfc2a6f2aea

commit 068230f6448595391cf6bcfba114edfc2a6f2aea
Author: Joe Downing <joedow@google.com>
Date: Thu Jan 26 22:26:10 2017

Disable DX Capturer to unblock testing

A bug was found yesterday ( crbug.com/684937 ) when prevents users from logging
into Me2Me connections on Windows when using the DX capturer.  The original
author is on vacation so we are going to disable this functionality to unblock
testing of M57 builds and development on M58 builds.

BUG= 685258 

Review-Url: https://codereview.chromium.org/2652073004
Cr-Commit-Position: refs/heads/master@{#446117}
(cherry picked from commit 76a10b17535c0456f042817a69fa036f226b26a3)

Review-Url: https://codereview.chromium.org/2650383006 .
Cr-Commit-Position: refs/branch-heads/2987@{#122}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/068230f6448595391cf6bcfba114edfc2a6f2aea/remoting/host/desktop_environment_options.cc

Owner: ajnolley@chromium.org
Status: Fixed (was: Started)
With this fix, you should be able to connect and sign in to Windows Me2Me hosts in non-curtain mode again.
Status: Verified (was: Fixed)
Previous behavior for me before fix allowed a connection and interaction in non-curtain mode, but it would freeze with ctrl alt del or invoking an admin prompt. This behavior no longer occurs in host versions 57.0.2987.13 and 58.0.2994.0, the builds from last night. 

Sign in to add a comment