Pointer Events Pen Eraser does not work
Reported by
setpixel...@gmail.com,
Jan 25 2017
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.95 Safari/537.36 Steps to reproduce the problem: 1. Use a tablet on Mac Chrome 55-58 2. https://patrickhlauke.github.io/touch/pen-tracker/ , open devtools 3. Using erasure reports button: -1 and buttons: 1 (Same as pen tip) What is the expected behavior? re: https://developer.mozilla.org/en-US/docs/Web/API/Pointer_events Should report: Button: 5, Buttons: 32 Also BTW: Pen tip down should report button: 0, buttons: 1 button: -1 is incorrect. What went wrong? I believe it was never piped in correctly, as much of Pointer Events pen support. Did this work before? No Does this work in other browsers? Yes Chrome version: 55.0.2883.95 Channel: stable OS Version: OS X 10.12.2 Flash Version: Shockwave Flash 24.0 r0 OMG PLEASE FIX :D
,
Jan 26 2017
lanwei@ is certainly working on some mac aspects of stylus support
,
Jan 26 2017
I will work on this soon, adding the support of the eraser button for stylus. Thank you for report this.
,
Feb 13 2017
Thanks so much Lan! Looking forward to it! Please let me know if I can help in any way.
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45def6b3f18b803e4ea050a84ba8fecbc786b6df commit 45def6b3f18b803e4ea050a84ba8fecbc786b6df Author: lanwei <lanwei@chromium.org> Date: Thu Mar 23 19:01:11 2017 Make stylus's eraser button work on Mac In order to make stylus's eraser button work on Mac, I set the pointer type to blink::WebPointerProperties::PointerType::Eraser when we use the eraser button on the tablet. BUG= 685252 Review-Url: https://codereview.chromium.org/2739773004 Cr-Commit-Position: refs/heads/master@{#459166} [modify] https://crrev.com/45def6b3f18b803e4ea050a84ba8fecbc786b6df/content/browser/renderer_host/input/web_input_event_builders_mac.mm [modify] https://crrev.com/45def6b3f18b803e4ea050a84ba8fecbc786b6df/content/browser/renderer_host/render_widget_host_view_mac.h [modify] https://crrev.com/45def6b3f18b803e4ea050a84ba8fecbc786b6df/content/browser/renderer_host/render_widget_host_view_mac.mm [modify] https://crrev.com/45def6b3f18b803e4ea050a84ba8fecbc786b6df/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
,
Mar 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c1d1f31c293867ecd7f90d60419e5a13d503408 commit 3c1d1f31c293867ecd7f90d60419e5a13d503408 Author: avi <avi@chromium.org> Date: Mon Mar 27 01:17:38 2017 Fix build break on Mac SDK 10.12. BUG= 705176 , 685252 Review-Url: https://codereview.chromium.org/2769353004 Cr-Commit-Position: refs/heads/master@{#459686} [modify] https://crrev.com/3c1d1f31c293867ecd7f90d60419e5a13d503408/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
,
Apr 6 2017
This commit Commit(#5) was landed in 59.0.3050.0. Do we need a merge here?
,
Apr 6 2017
Yes please! I know I don't have a say, but I would LOVE this to be in 58.
,
Apr 7 2017
No this is new feature work and isn't a regression so it doesn't constitute a merge. Sorry but you'll have to wait for m59.
,
Apr 7 2017
It's sort of a regression. It's been stated for 2 versions that it has worked. I guess it's fine. This is to be expected. Edge has supported it for almost a year ago.
,
May 8 2017
,
May 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0474c2a5ba9d963f73bc2cdecc6d16e575a4a4be commit 0474c2a5ba9d963f73bc2cdecc6d16e575a4a4be Author: lanwei <lanwei@chromium.org> Date: Fri May 12 18:52:01 2017 Do not increase the pointer id when type is eraser We are setting the pointer type to eraser when using an eraser button. We should not increase the pointer id in this case, because it should be considered as a pen type. BUG= 685252 Review-Url: https://codereview.chromium.org/2867093003 Cr-Commit-Position: refs/heads/master@{#471391} [modify] https://crrev.com/0474c2a5ba9d963f73bc2cdecc6d16e575a4a4be/content/shell/test_runner/event_sender.cc [modify] https://crrev.com/0474c2a5ba9d963f73bc2cdecc6d16e575a4a4be/content/shell/test_runner/event_sender.h [modify] https://crrev.com/0474c2a5ba9d963f73bc2cdecc6d16e575a4a4be/third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html [modify] https://crrev.com/0474c2a5ba9d963f73bc2cdecc6d16e575a4a4be/third_party/WebKit/Source/core/events/PointerEventFactory.cpp [modify] https://crrev.com/0474c2a5ba9d963f73bc2cdecc6d16e575a4a4be/third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp
,
May 18 2017
Please request a merge to M59 if needed.
,
May 18 2017
Sorry, We cannot. We already missed M59's beta range which ended at May 4.
,
Aug 1 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ligim...@chromium.org
, Jan 25 2017