New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685244 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug


Sign in to add a comment

roll clang again

Project Member Reported by thakis@chromium.org, Jan 25 2017

Issue description

r292949 fixes a windows debug info assert. msan compiles are faster at trunk. we haven't rolled in a while.
 

Comment 1 by h...@chromium.org, Jan 25 2017

Cc: euge...@chromium.org
+eugenis who asked about the roll the other day

Comment 2 by thakis@chromium.org, Jan 25 2017

Blockedon: 685253 685254 685255

Comment 3 by thakis@chromium.org, Jan 25 2017

Blockedon: 685257

Comment 4 by thakis@chromium.org, Jan 25 2017

Blockedon: 685259

Comment 5 by thakis@chromium.org, Jan 25 2017

Blockedon: 685262

Comment 6 by thakis@chromium.org, Jan 26 2017

Blocking: 681136

Comment 7 by thakis@chromium.org, Jan 27 2017

Blockedon: 686109

Comment 8 by thakis@chromium.org, Jan 27 2017

Blockedon: 686113
From crdev: "I am building chromium on Fedora, and it crashes with https://llvm.org/bugs/show_bug.cgi?id=31043. Clang was fixed in r291064."
Cc: krasin@chromium.org
Blockedon: 689559
Blockedon: -685259
Blocking: 688098
Cc: kcc@chromium.org infe...@chromium.org
This will fix libFuzzer Mac compile issue after enabling trace-pc-guard.
Blockedon: 689874
Blocking: 689874
Blockedon: -689874
Blockedon: 690123
Blocking: 687570
r294517 (https://reviews.llvm.org/rL294517) also fixes an important linker problem problem for libfuzzer: 687570
Blockedon: 691051
Blockedon: 692255
Blockedon: 692580

Comment 22 by h...@chromium.org, Feb 15 2017

After rolling, we should be able to revert https://codereview.chromium.org/2694053003. (We could also revert https://codereview.chromium.org/2640153006 if we want.)
Blockedon: 693718

Comment 24 by r...@chromium.org, Feb 21 2017

Blocking: 694402

Comment 25 by r...@chromium.org, Feb 21 2017

Blockedon: -685262
Blockedon: 694797

Comment 27 by h...@chromium.org, Feb 22 2017

Blockedon: 695113
I gave it a try in https://chromium.googlesource.com/chromium/src/+/c702a811babe12110a84d644ee81b6d99b2f4716 (forgot to put a BUG= line on it). I wouldn't be surprised if it ends up being reverted for some reason though.
Project Member

Comment 30 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b87e5b0b9505543cc4270479af08e60da11cd507

commit b87e5b0b9505543cc4270479af08e60da11cd507
Author: Nico Weber <thakis@chromium.org>
Date: Fri Feb 24 20:25:00 2017

Disable nocompile tests after clang roll

Results need rebasing.

BUG=695991, 685244 
TBR=lazyboy@chromium.org

Review-Url: https://codereview.chromium.org/2711343004 .
Cr-Commit-Position: refs/heads/master@{#452912}

[modify] https://crrev.com/b87e5b0b9505543cc4270479af08e60da11cd507/build/nocompile.gni

Status: Fixed (was: Untriaged)
we did a follow-up roll in  bug 696607  due to regression in this roll. But mostly it looks like it might stick.

Sign in to add a comment