system_health.memory_desktop failing on 11 builders |
||||||||||
Issue descriptionsystem_health.memory_desktop failing on 11 builders Type: infra-failure Builders failed on: - Mac 10.12 Perf: https://build.chromium.org/p/chromium.perf/builders/Mac%2010.12%20Perf - Mac Retina Perf: https://build.chromium.org/p/chromium.perf/builders/Mac%20Retina%20Perf - Win 10 High-DPI Perf: https://build.chromium.org/p/chromium.perf/builders/Win%2010%20High-DPI%20Perf - Win 10 Perf: https://build.chromium.org/p/chromium.perf/builders/Win%2010%20Perf - Win 7 ATI GPU Perf: https://build.chromium.org/p/chromium.perf/builders/Win%207%20ATI%20GPU%20Perf - Win 7 Intel GPU Perf: https://build.chromium.org/p/chromium.perf/builders/Win%207%20Intel%20GPU%20Perf - Win 7 Nvidia GPU Perf: https://build.chromium.org/p/chromium.perf/builders/Win%207%20Nvidia%20GPU%20Perf - Win 7 Perf: https://build.chromium.org/p/chromium.perf/builders/Win%207%20Perf - Win 7 x64 Perf: https://build.chromium.org/p/chromium.perf/builders/Win%207%20x64%20Perf - Win 8 Perf: https://build.chromium.org/p/chromium.perf/builders/Win%208%20Perf - Win Zenbook Perf: https://build.chromium.org/p/chromium.perf/builders/Win%20Zenbook%20Perf
,
Jan 25 2017
Stephen can you take a look?
,
Jan 25 2017
,
Jan 26 2017
So, trivially, it looks like these tests are taking longer than 2 hours to run. There's a timeout on each task in swarming, which is 2 hours I think. They didn't used to take that long, IIRC. Does anyone know of any changes that could have increased the cycle time?
,
Jan 26 2017
,
Jan 26 2017
It could be related to the change Hector did recently to make memory benchmarks more reproducible?
,
Jan 26 2017
Comparing between before & now, there is clearly a timing explosion here: Before: https://chromium-swarm.appspot.com/task?id=33833729e3513f10&refresh=10&show_raw=1 [ OK ] load:media:dailymotion (14963 ms) Now: https://chromium-swarm.appspot.com/task?id=33f013a32a4e1510&refresh=10&show_raw=1 [ OK ] load:media:dailymotion (81316 ms)
,
Jan 26 2017
I am really suspecting Hector's change (https://codereview.chromium.org/2631283002) is creating this time explosion because system_health.common_dekstop doesn't have the same timing explosion (taking 34m in https://build.chromium.org/p/chromium.perf/builders/Win%2010%20Perf/builds/334). The only differences between the two suite are: 1) system_health.memory_desktop use memory trace whereas system_health.common_desktop uses other trace 2) system_health.memory_desktop clear system cache & browser profile for every single user story whereas system_health.common_desktop ignores it. It's extremely unlikely that that 50+ seconds regression in #7 is due to memory tracing regression, so I think (2) is likely the root cause. Assign to Hector for further investigation.
,
Jan 26 2017
,
Jan 26 2017
Running try jobs on win-all, mac-all with the change reverted from memory_desktop to compare. See https://codereview.chromium.org/2658583005.
,
Jan 26 2017
If I'm looking at the right step "Running WITH patch.Performance Test (With/Without Patch)" https://luci-milo.appspot.com/buildbot/tryserver.chromium.perf/mac_air_perf_bisect/6 then is does seem to be slower. Shall we try committing https://codereview.chromium.org/2631283002 and see if they recover?
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce9c223faabd70c29759bc6f5d8844f44b40cede commit ce9c223faabd70c29759bc6f5d8844f44b40cede Author: hjd <hjd@chromium.org> Date: Thu Jan 26 19:38:00 2017 Only flush system cache on mobile. Flushing the cache on desktop increases runtime significantly. BUG= 685240 Review-Url: https://codereview.chromium.org/2658583005 Cr-Commit-Position: refs/heads/master@{#446396} [modify] https://crrev.com/ce9c223faabd70c29759bc6f5d8844f44b40cede/tools/perf/benchmarks/system_health.py
,
Feb 17 2017
,
Mar 14 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by zh...@chromium.org
, Jan 25 2017