New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 685235 link

Starred by 1 user
Status: Fixed
Owner:
█ jialiul@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Cc:
nparker@chromium.org
mmenke@chromium.org
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 620852



Sign in to add a comment

Make SafeBrowsing ModelLoader release URLFetcher in between reloads

Project Member Reported by xunji...@chromium.org, Jan 25 2017 
In investigating  Issue 685205 , I noticed that ModelLoader can keep completed URLFetcher alive for a while (? kClientModelFetchIntervalMs = 1hr). Completed URLFetcher retains metadata, which take up memory.

Can ModelLoader releases |fetcher_| in EndFetch()? It already creates a new one in ScheduleFetch(), so we might as well release the old |fetcher_| early.

Comment 1 by vakh@chromium.org, Jan 27 2017

Labels: SafeBrowsing-Triaged
Owner: jialiul@chromium.org
Status: Assigned (was: Untriaged)
The approach sounds reasonable. xunjieli@, feel free to take it on, if you'd like to.

Comment 2 by xunji...@chromium.org, Jan 30 2017 

maksims has a CL at https://codereview.chromium.org/2665653002/

Comment 3 by jialiul@chromium.org, Feb 3 2017

Status: Fixed (was: Assigned)
Cool~ Thanks xuejieli@. maksims@'s CL has already landed. Let's mark this bug as fixed then.
►

Sign in to add a comment