Add a context menu to reading list |
|||||
Issue descriptionIn reading list, when user taps and holds an item, the animation suggests that something will happen, but nothing happens. Maybe we could do one of the following: a) enable editing b) add a context menu (UIActionSheet) to open in Current, New and Incognito tabs?
,
Jan 25 2017
,
Jan 26 2017
+ Pink, Eric +1 for context menu. It should be like in History: Open in New Tab, Open in New Incognito Tab, Copy Link URL. Olivier: I am not sure users would understand "Refresh Offline Version" but I think adding a "View Offline Version" could be useful. What do others think?
,
Jan 26 2017
+1 for "View Offline Version" instead of "Refresh Offline Version"
,
Jan 26 2017
Giving control of the offline version would be great. What about Open in New Tab Open in New Incognito Tab Copy Link URL Offline... Offline... leading to View Online View Offline Refresh Delete ?
,
Jan 26 2017
As discussed: - without adding a date field on the article "Refresh" is a bit out of place - it's not very logical to click on "Offline..." to then "View Online" So for the time being, let's stick with: - Open in New Tab - Open in New Incognito Tab - Copy Link URL - View Offline Version [and Cancel of course] We should open a different bug to track the feature request for adding Date + Size like in Clank's download's space and assign it to UX. Thanks.
,
Jan 26 2017
Is size really important, or just extra cluttering information? On that topic, but totally separate, does "clear browsing data" in settings actually clear out offline Reading List content? Should it? Is that possibly a Privacy issue if it doesn't?
,
Jan 26 2017
And +1 to the suggested context menu in #6 by mardini.
,
Jan 26 2017
#7. No, browsing data does not delete offline Reading List content. I don't think offline pages are browsing data so I would say it should not. Privacy is usually OK if you can delete items individually. Privacy asked how items were deleted (not specifically offline content) and seemed happy with the current behavior. https://bugs.chromium.org/p/chromium/issues/detail?id=679704#c10 Note: Android does not delete it either.
,
Jan 26 2017
We will also table size and date for now.
,
Jan 31 2017
Should the last one be "View Offline Version" or "View Offline Version in New Tab"? Opening in a new tab is easier technically, and it is consistent with the other actions. WDYT?
,
Jan 31 2017
I'm fine with "View Offline Version in New Tab" from a behaviour consistency standpoint. I'm concerned, however, that the string will wrap (especially for longer languages). Will the font size be resized to fit on line?
,
Feb 1 2017
Yes. I have attached a screenshot.
,
Feb 1 2017
OK. Looks fine for English. I'm sure there is a minimum font size though after which it will not resize, no ?
,
Feb 1 2017
There is no minimum font size. It will resize until the font is 0. But the maximum number of letters for translation is 50, which is the number of letter in the screenshot I posted.
,
Feb 1 2017
mardini: do we want some metrics specific for this context menu? For now the only User Action used is "MobileReadingListOpen" for all opening (current tab, new tab, new incognito tab, offline in new tab).
,
Feb 1 2017
To document the offline conversation I had with Gauthier: We'll create a histogram with four values representing the four options on this menu: 1/ Open in New Tab 2/ Open in New Incognito Tab 3/ View Offline Version in New Tab 4/ Cancel This will be useful to gauge users' interest in viewing the offline version which is a good data point informing the popularity of an eventual stand-alone "Reader Mode". We still need the UserAction MobileReadingListOpen to be incremented when performing any of the three actions.
,
Feb 1 2017
There are 5 options (+copy link), so the histogram will have 5 values.
,
Feb 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a13836f0b66471a08f88e02fdaba0c7671f83e6 commit 6a13836f0b66471a08f88e02fdaba0c7671f83e6 Author: gambard <gambard@chromium.org> Date: Mon Feb 06 17:19:28 2017 Add context menu when long press on a reading list entry This CL adds a context menu with different actions when a long press on a reading list entry occurs. BUG= 685230 Review-Url: https://codereview.chromium.org/2659693004 Cr-Commit-Position: refs/heads/master@{#448282} [modify] https://crrev.com/6a13836f0b66471a08f88e02fdaba0c7671f83e6/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/6a13836f0b66471a08f88e02fdaba0c7671f83e6/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/6a13836f0b66471a08f88e02fdaba0c7671f83e6/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/6a13836f0b66471a08f88e02fdaba0c7671f83e6/ios/chrome/browser/ui/history/history_collection_view_controller.mm [modify] https://crrev.com/6a13836f0b66471a08f88e02fdaba0c7671f83e6/ios/chrome/browser/ui/reading_list/BUILD.gn [modify] https://crrev.com/6a13836f0b66471a08f88e02fdaba0c7671f83e6/ios/chrome/browser/ui/reading_list/reading_list_view_controller.h [modify] https://crrev.com/6a13836f0b66471a08f88e02fdaba0c7671f83e6/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm [modify] https://crrev.com/6a13836f0b66471a08f88e02fdaba0c7671f83e6/ios/chrome/browser/ui/reading_list/reading_list_view_controller_builder.h [modify] https://crrev.com/6a13836f0b66471a08f88e02fdaba0c7671f83e6/ios/chrome/browser/ui/reading_list/reading_list_view_controller_builder.mm [modify] https://crrev.com/6a13836f0b66471a08f88e02fdaba0c7671f83e6/ios/chrome/browser/ui/reading_list/reading_list_view_controller_container.h [modify] https://crrev.com/6a13836f0b66471a08f88e02fdaba0c7671f83e6/ios/chrome/browser/ui/reading_list/reading_list_view_controller_container.mm [add] https://crrev.com/6a13836f0b66471a08f88e02fdaba0c7671f83e6/ios/chrome/browser/ui/reading_list/reading_list_view_controller_container_unittest.mm [modify] https://crrev.com/6a13836f0b66471a08f88e02fdaba0c7671f83e6/ios/chrome/browser/ui/reading_list/reading_list_view_controller_unittest.mm [modify] https://crrev.com/6a13836f0b66471a08f88e02fdaba0c7671f83e6/ios/chrome/browser/ui/util/BUILD.gn [add] https://crrev.com/6a13836f0b66471a08f88e02fdaba0c7671f83e6/ios/chrome/browser/ui/util/pasteboard_util.h [add] https://crrev.com/6a13836f0b66471a08f88e02fdaba0c7671f83e6/ios/chrome/browser/ui/util/pasteboard_util.mm [modify] https://crrev.com/6a13836f0b66471a08f88e02fdaba0c7671f83e6/tools/metrics/histograms/histograms.xml
,
Feb 10 2017
,
Feb 14 2017
Verified the issue on the build 58.0.3012.0 canary tested on iPhone7+(iOS 10),iPadAir(iOS10). Context menu is displayed on long tapping on reading list entries.looks good. iPhone : https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpZEpta2lScHFtdFk/view?usp=sharing iPad: https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpSkxvUERrT2JlZVk/view?usp=sharing |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by olivierrobin@chromium.org
, Jan 25 2017