New issue
Advanced search Search tips

Issue 685226 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Mus+Ash Status Bubble does not work in Chrome

Project Member Reported by fsam...@chromium.org, Jan 25 2017

Issue description

The Chrome status bubble doesn't seem to work in Mus+Ash. While debugging a display compositor feature, I noticed what looks like a request for a new top level window, but nothing ever renders into it. I'm adding the label "displaycompositor" because this bug is potentially blocking me.
 
I just sync'ed to Tip of tree, and it looks like the status bubble does work initially then stops working for some reason.

Comment 2 by sky@chromium.org, Jan 25 2017

Status: star (was: Untriaged)

Comment 3 by sky@chromium.org, Jan 25 2017

Owner: sky@chromium.org
Status: Started (was: Star)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55cd9ef40d390ea5a39089d4b18ea8fe78de5eb8

commit 55cd9ef40d390ea5a39089d4b18ea8fe78de5eb8
Author: sky <sky@chromium.org>
Date: Wed Jan 25 22:59:09 2017

chromeos: wires transients using the WindowTreeHost window

The expectation is transients are honored at the widget level, which
corresponds to wiring using the window created by the WindowTreeHost.

BUG= 685226 
TEST=covered by test.
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2649103009
Cr-Commit-Position: refs/heads/master@{#446151}

[modify] https://crrev.com/55cd9ef40d390ea5a39089d4b18ea8fe78de5eb8/ui/views/mus/desktop_window_tree_host_mus.cc
[modify] https://crrev.com/55cd9ef40d390ea5a39089d4b18ea8fe78de5eb8/ui/views/mus/desktop_window_tree_host_mus_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a265dc92c9aabf095817219ca44f094c81cfdd5

commit 9a265dc92c9aabf095817219ca44f094c81cfdd5
Author: sky <sky@chromium.org>
Date: Thu Jan 26 19:21:21 2017

mash: changes event dispatch to consider non-client area of all windows

Previously if a window was marked as not accepting events then events
would never target it. This means you could never drag a window as
marked as not accepting events. This patch makes it so the non-client
area can be targeted for these windows so that they can still be
dragged and what not.

BUG= 685226 
TEST=covered by test.
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2655213002
Cr-Commit-Position: refs/heads/master@{#446384}

[modify] https://crrev.com/9a265dc92c9aabf095817219ca44f094c81cfdd5/services/ui/ws/event_dispatcher.cc
[modify] https://crrev.com/9a265dc92c9aabf095817219ca44f094c81cfdd5/services/ui/ws/event_dispatcher.h
[modify] https://crrev.com/9a265dc92c9aabf095817219ca44f094c81cfdd5/services/ui/ws/window_finder.cc
[modify] https://crrev.com/9a265dc92c9aabf095817219ca44f094c81cfdd5/services/ui/ws/window_finder.h
[modify] https://crrev.com/9a265dc92c9aabf095817219ca44f094c81cfdd5/services/ui/ws/window_finder_unittest.cc

Components: Internals>Compositing

Comment 7 by sky@chromium.org, Jan 26 2017

Status: Fixed (was: Started)
Blocking:
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment