Issue 685225 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ jif@chromium.org Last visit > 30 days ago
Closed:	Feb 2017
Cc:	ios-bugs@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	iOS
Pri:	3
Type:	Bug

Rename UIActivityFindLoginActionSource

Project Member Reported by jif@chromium.org, Jan 25 2017

Issue description

Unlike what its name suggests, UIActivityFindLoginActionSource is not just used for finding logins.
We should rename that class.

Project Member

Comment 1 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f64972b263657c4f1b524f1ee544e571758b9dc

commit 5f64972b263657c4f1b524f1ee544e571758b9dc
Author: jif <jif@chromium.org>
Date: Wed Feb 22 10:11:13 2017

Rename UIActivityFindLoginActionSource to UIActivityURLSource.

BUG= 685225 

Review-Url: https://codereview.chromium.org/2710923002
Cr-Commit-Position: refs/heads/master@{#451969}

[modify] https://crrev.com/5f64972b263657c4f1b524f1ee544e571758b9dc/ios/chrome/browser/ui/activity_services/activity_service_controller.mm
[modify] https://crrev.com/5f64972b263657c4f1b524f1ee544e571758b9dc/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm
[modify] https://crrev.com/5f64972b263657c4f1b524f1ee544e571758b9dc/ios/chrome/browser/ui/activity_services/chrome_activity_item_source.h
[modify] https://crrev.com/5f64972b263657c4f1b524f1ee544e571758b9dc/ios/chrome/browser/ui/activity_services/chrome_activity_item_source.mm

Comment 2 by jif@chromium.org, Feb 22 2017

Status: Fixed (was: Assigned)

►

Issue 685225 link

Issue metadata

Rename UIActivityFindLoginActionSource

Issue description

Comment 1 by bugdroid1@chromium.org, Feb 22 2017

Comment 1 Deleted

Comment 2 by jif@chromium.org, Feb 22 2017

Comment 2 Deleted

Sign in to add a comment