New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685222 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature



Sign in to add a comment

Add new Android Video Quality test to our bots.

Project Member Reported by kjellander@chromium.org, Jan 25 2017

Issue description

In https://codereview.webrtc.org/2632323003/ the https://chromium.googlesource.com/external/webrtc/+/master/webrtc/tools/test_stubbed_loopback_video.py test was added, which performs a video quality test on an Android device and outputs perf numbers.

We'd like to add this as a new step on the Android Perf bots in the client.webrtc.perf waterfall (perf tracking enabled obviously). I believe the test is self-contained so it should just be a matter of running the script from its location in the checkout.


 
Cc: mbonadei@chromium.org
Labels: -Pri-2 Pri-1
Owner: ehmaldonado@chromium.org
This is getting increasingly important to get running so we can start gathering data. 

Edward: Would you mind taking a look instead?
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ad97a00291833bff900460ec12ffb55d1a46aaf3

commit ad97a00291833bff900460ec12ffb55d1a46aaf3
Author: Edward Lemur <ehmaldonado@webrtc.org>
Date: Thu Feb 09 15:04:59 2017

WebRTC: Add new Android Video Quality test to Android Perf bots.

BUG= chromium:685222 

Change-Id: I64b7b29b47c8e2571f4a2ea0c1a007c6a13eb349
Reviewed-on: https://chromium-review.googlesource.com/439344
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/ad97a00291833bff900460ec12ffb55d1a46aaf3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus6_.json
[modify] https://crrev.com/ad97a00291833bff900460ec12ffb55d1a46aaf3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5_.json
[modify] https://crrev.com/ad97a00291833bff900460ec12ffb55d1a46aaf3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__k_nexus5_.json
[modify] https://crrev.com/ad97a00291833bff900460ec12ffb55d1a46aaf3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus4_.json
[modify] https://crrev.com/ad97a00291833bff900460ec12ffb55d1a46aaf3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__n_nexus6_.json
[modify] https://crrev.com/ad97a00291833bff900460ec12ffb55d1a46aaf3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced.json
[modify] https://crrev.com/ad97a00291833bff900460ec12ffb55d1a46aaf3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json
[modify] https://crrev.com/ad97a00291833bff900460ec12ffb55d1a46aaf3/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/ad97a00291833bff900460ec12ffb55d1a46aaf3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__l_nexus9_.json
[modify] https://crrev.com/ad97a00291833bff900460ec12ffb55d1a46aaf3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus7_2_.json

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ff817739f3d37f076695af9e8b218c044e5c83fd

commit ff817739f3d37f076695af9e8b218c044e5c83fd
Author: Edward Lesmes <ehmaldonado@chromium.org>
Date: Thu Feb 09 16:03:27 2017

Revert "WebRTC: Add new Android Video Quality test to Android Perf bots."

This reverts commit ad97a00291833bff900460ec12ffb55d1a46aaf3.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> WebRTC: Add new Android Video Quality test to Android Perf bots.
> 
> BUG= chromium:685222 
> 
> Change-Id: I64b7b29b47c8e2571f4a2ea0c1a007c6a13eb349
> Reviewed-on: https://chromium-review.googlesource.com/439344
> Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> 

TBR=kjellander@chromium.org,ehmaldonado@chromium.org,chromium-reviews@chromium.org,ehmaldonado@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:685222 

Change-Id: I8d16188fcde10bae6dd97ff4b4e09c61b31623de
Reviewed-on: https://chromium-review.googlesource.com/440068
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/ff817739f3d37f076695af9e8b218c044e5c83fd/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus6_.json
[modify] https://crrev.com/ff817739f3d37f076695af9e8b218c044e5c83fd/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5_.json
[modify] https://crrev.com/ff817739f3d37f076695af9e8b218c044e5c83fd/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__k_nexus5_.json
[modify] https://crrev.com/ff817739f3d37f076695af9e8b218c044e5c83fd/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus4_.json
[modify] https://crrev.com/ff817739f3d37f076695af9e8b218c044e5c83fd/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__n_nexus6_.json
[modify] https://crrev.com/ff817739f3d37f076695af9e8b218c044e5c83fd/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced.json
[modify] https://crrev.com/ff817739f3d37f076695af9e8b218c044e5c83fd/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json
[modify] https://crrev.com/ff817739f3d37f076695af9e8b218c044e5c83fd/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/ff817739f3d37f076695af9e8b218c044e5c83fd/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__l_nexus9_.json
[modify] https://crrev.com/ff817739f3d37f076695af9e8b218c044e5c83fd/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus7_2_.json

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b373cf63b72495df7a78a4afd2f544612bf4bb8d

commit b373cf63b72495df7a78a4afd2f544612bf4bb8d
Author: Edward Lemur <ehmaldonado@webrtc.org>
Date: Mon Feb 13 12:10:30 2017

WebRTC: Add new Android Video Quality test to Android Perf bots.

BUG= chromium:685222 

Change-Id: Id9a204c23c36be80ab6c7d00dc7eef0b847b414f
Reviewed-on: https://chromium-review.googlesource.com/441024
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/b373cf63b72495df7a78a4afd2f544612bf4bb8d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus6_.json
[modify] https://crrev.com/b373cf63b72495df7a78a4afd2f544612bf4bb8d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5_.json
[modify] https://crrev.com/b373cf63b72495df7a78a4afd2f544612bf4bb8d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__k_nexus5_.json
[modify] https://crrev.com/b373cf63b72495df7a78a4afd2f544612bf4bb8d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus4_.json
[modify] https://crrev.com/b373cf63b72495df7a78a4afd2f544612bf4bb8d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__n_nexus6_.json
[modify] https://crrev.com/b373cf63b72495df7a78a4afd2f544612bf4bb8d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced.json
[modify] https://crrev.com/b373cf63b72495df7a78a4afd2f544612bf4bb8d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json
[modify] https://crrev.com/b373cf63b72495df7a78a4afd2f544612bf4bb8d/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/b373cf63b72495df7a78a4afd2f544612bf4bb8d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__l_nexus9_.json
[modify] https://crrev.com/b373cf63b72495df7a78a4afd2f544612bf4bb8d/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus7_2_.json

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/8023c86904686167254cc06329fd269863941eff

commit 8023c86904686167254cc06329fd269863941eff
Author: Edward Lesmes <ehmaldonado@chromium.org>
Date: Mon Feb 13 13:13:35 2017

Revert "WebRTC: Add new Android Video Quality test to Android Perf bots."

This reverts commit b373cf63b72495df7a78a4afd2f544612bf4bb8d.

Reason for revert: 

/usr/bin/python /b/c/b/Android32_Tests__K_Nexus5_/src/webrtc/examples/androidtests/video_quality_loopback_test.py out/Release
INFO:root:Running ['gn', 'gen', '/tmp/tmpg8G_2y/LocalBuild']
ERROR Can't find source root.
I could not find a ".gn" file in the current directory or any parent,
and the --root command-line argument was not specified.
Traceback (most recent call last):
  File "/b/c/b/Android32_Tests__K_Nexus5_/src/webrtc/examples/androidtests/video_quality_loopback_test.py", line 135, in <module>
    sys.exit(main())
  File "/b/c/b/Android32_Tests__K_Nexus5_/src/webrtc/examples/androidtests/video_quality_loopback_test.py", line 72, in main
    _RunCommand(['gn', 'gen', build_dir_x86])
  File "/b/c/b/Android32_Tests__K_Nexus5_/src/webrtc/examples/androidtests/video_quality_loopback_test.py", line 37, in _RunCommand
    subprocess.check_call(argv, **kwargs)
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['gn', 'gen', '/tmp/tmpg8G_2y/LocalBuild']' returned non-zero exit status 1


Original change's description:
> WebRTC: Add new Android Video Quality test to Android Perf bots.
> 
> BUG= chromium:685222 
> 
> Change-Id: Id9a204c23c36be80ab6c7d00dc7eef0b847b414f
> Reviewed-on: https://chromium-review.googlesource.com/441024
> Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> 

TBR=kjellander@chromium.org,ehmaldonado@chromium.org,ehmaldonado@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:685222 

Change-Id: Ife41f9c99a57cacdb06359247fd44c91d539d21c
Reviewed-on: https://chromium-review.googlesource.com/441765
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/8023c86904686167254cc06329fd269863941eff/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus6_.json
[modify] https://crrev.com/8023c86904686167254cc06329fd269863941eff/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5_.json
[modify] https://crrev.com/8023c86904686167254cc06329fd269863941eff/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__k_nexus5_.json
[modify] https://crrev.com/8023c86904686167254cc06329fd269863941eff/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus4_.json
[modify] https://crrev.com/8023c86904686167254cc06329fd269863941eff/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__n_nexus6_.json
[modify] https://crrev.com/8023c86904686167254cc06329fd269863941eff/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced.json
[modify] https://crrev.com/8023c86904686167254cc06329fd269863941eff/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json
[modify] https://crrev.com/8023c86904686167254cc06329fd269863941eff/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/8023c86904686167254cc06329fd269863941eff/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__l_nexus9_.json
[modify] https://crrev.com/8023c86904686167254cc06329fd269863941eff/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus7_2_.json

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/d103f4ba4afc8928345baa14dcb05124c94481e9

commit d103f4ba4afc8928345baa14dcb05124c94481e9
Author: ehmaldonado <ehmaldonado@webrtc.org>
Date: Thu Feb 16 15:20:26 2017

Modify android video_quality_loopback_test to run commands from the src dir.

R=kjellander@webrtc.org, mandermo@webrtc.org
TBR=perkj@webrtc.org
BUG= chromium:685222 
NOTRY=True

Review-Url: https://codereview.webrtc.org/2695713002
Cr-Commit-Position: refs/heads/master@{#16647}

[modify] https://crrev.com/d103f4ba4afc8928345baa14dcb05124c94481e9/webrtc/examples/androidtests/video_quality_loopback_test.py

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/4f434debc09adac5440df5ab546dbf06ff135a95

commit 4f434debc09adac5440df5ab546dbf06ff135a95
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Thu Feb 16 21:24:48 2017

WebRTC: Add video quality loopback test to android. Take 3

BUG= chromium:685222 

Change-Id: Ia3f95d1660557023062c9a3d6d7fd175b6ce1bd5
Reviewed-on: https://chromium-review.googlesource.com/441346
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/4f434debc09adac5440df5ab546dbf06ff135a95/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus6_.json
[modify] https://crrev.com/4f434debc09adac5440df5ab546dbf06ff135a95/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5_.json
[modify] https://crrev.com/4f434debc09adac5440df5ab546dbf06ff135a95/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__k_nexus5_.json
[modify] https://crrev.com/4f434debc09adac5440df5ab546dbf06ff135a95/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus4_.json
[modify] https://crrev.com/4f434debc09adac5440df5ab546dbf06ff135a95/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__n_nexus6_.json
[modify] https://crrev.com/4f434debc09adac5440df5ab546dbf06ff135a95/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced.json
[modify] https://crrev.com/4f434debc09adac5440df5ab546dbf06ff135a95/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json
[modify] https://crrev.com/4f434debc09adac5440df5ab546dbf06ff135a95/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/4f434debc09adac5440df5ab546dbf06ff135a95/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__l_nexus9_.json
[modify] https://crrev.com/4f434debc09adac5440df5ab546dbf06ff135a95/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus7_2_.json

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ee479198c101a38609ff8c7943674d4568d27743

commit ee479198c101a38609ff8c7943674d4568d27743
Author: Edward Lesmes <ehmaldonado@chromium.org>
Date: Thu Feb 16 22:10:38 2017

Revert "WebRTC: Add video quality loopback test to android. Take 3"

This reverts commit 4f434debc09adac5440df5ab546dbf06ff135a95.

Reason for revert: 
Breaks the bots. https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20%28L%20Nexus4%29/builds/166/steps/video_quality_loopback_test/logs/stdio

INFO:root:Running ['/usr/bin/python', 'out/Release/bin/run_AppRTCMobileTestStubbedVideoIO']
/usr/bin/python: can't open file 'out/Release/bin/run_AppRTCMobileTestStubbedVideoIO': [Errno 2] No such file or directory
Traceback (most recent call last):
  File "/b/c/b/Android32_Tests__L_Nexus4_/src/webrtc/examples/androidtests/video_quality_loopback_test.py", line 132, in <module>
    sys.exit(main())
  File "/b/c/b/Android32_Tests__L_Nexus4_/src/webrtc/examples/androidtests/video_quality_loopback_test.py", line 82, in main
    _RunCommand([sys.executable, test_script])
  File "/b/c/b/Android32_Tests__L_Nexus4_/src/webrtc/examples/androidtests/video_quality_loopback_test.py", line 37, in _RunCommand
    subprocess.check_call(argv, cwd=cwd, **kwargs)
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/usr/bin/python', 'out/Release/bin/run_AppRTCMobileTestStubbedVideoIO']' returned non-zero exit status 2

Original change's description:
> WebRTC: Add video quality loopback test to android. Take 3
> 
> BUG= chromium:685222 
> 
> Change-Id: Ia3f95d1660557023062c9a3d6d7fd175b6ce1bd5
> Reviewed-on: https://chromium-review.googlesource.com/441346
> Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> 

TBR=kjellander@chromium.org,ehmaldonado@chromium.org,chromium-reviews@chromium.org,ehmaldonado@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:685222 

Change-Id: I73edcf005dde946cb5f10aea1199bdcdaa67456f
Reviewed-on: https://chromium-review.googlesource.com/444404
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/ee479198c101a38609ff8c7943674d4568d27743/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus6_.json
[modify] https://crrev.com/ee479198c101a38609ff8c7943674d4568d27743/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5_.json
[modify] https://crrev.com/ee479198c101a38609ff8c7943674d4568d27743/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__k_nexus5_.json
[modify] https://crrev.com/ee479198c101a38609ff8c7943674d4568d27743/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus4_.json
[modify] https://crrev.com/ee479198c101a38609ff8c7943674d4568d27743/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__n_nexus6_.json
[modify] https://crrev.com/ee479198c101a38609ff8c7943674d4568d27743/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced.json
[modify] https://crrev.com/ee479198c101a38609ff8c7943674d4568d27743/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json
[modify] https://crrev.com/ee479198c101a38609ff8c7943674d4568d27743/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/ee479198c101a38609ff8c7943674d4568d27743/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__l_nexus9_.json
[modify] https://crrev.com/ee479198c101a38609ff8c7943674d4568d27743/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus7_2_.json

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d0248b51bee0e4e68a282883dfa0b505d1026a53

commit d0248b51bee0e4e68a282883dfa0b505d1026a53
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Sat Feb 18 20:09:40 2017

WebRTC: Add video quality loopback test to android. Take 4

The path to the output dir needs to be passed as an absolute path.

BUG= chromium:685222 
TBR=ehmaldonado@chromium.org

Change-Id: I604053723cae8ac30d08c9934ca8fb2805155ccf
Reviewed-on: https://chromium-review.googlesource.com/444228
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/d0248b51bee0e4e68a282883dfa0b505d1026a53/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus6_.json
[modify] https://crrev.com/d0248b51bee0e4e68a282883dfa0b505d1026a53/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5_.json
[modify] https://crrev.com/d0248b51bee0e4e68a282883dfa0b505d1026a53/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__k_nexus5_.json
[modify] https://crrev.com/d0248b51bee0e4e68a282883dfa0b505d1026a53/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus4_.json
[modify] https://crrev.com/d0248b51bee0e4e68a282883dfa0b505d1026a53/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__n_nexus6_.json
[modify] https://crrev.com/d0248b51bee0e4e68a282883dfa0b505d1026a53/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced.json
[modify] https://crrev.com/d0248b51bee0e4e68a282883dfa0b505d1026a53/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json
[modify] https://crrev.com/d0248b51bee0e4e68a282883dfa0b505d1026a53/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/d0248b51bee0e4e68a282883dfa0b505d1026a53/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__l_nexus9_.json
[modify] https://crrev.com/d0248b51bee0e4e68a282883dfa0b505d1026a53/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus7_2_.json

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/3da9d728fa3c388f3aec2ae873924baa8222af4f

commit 3da9d728fa3c388f3aec2ae873924baa8222af4f
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Sat Feb 18 20:56:16 2017

WebRTC: Build AppRTCMobileTestStubbedVideoIO for Android perf bots.

The bots were only building webrtc_perf_tests which caused the
assumptions for the video_quality_loopback_test.py script to be
incorrect (out/Release/bin/run_AppRTCMobileTestStubbedVideoIO
was not found)

BUG= chromium:685222 
TBR=ehmaldonado@chromium.org

Change-Id: I5c6f085d16f090801ed15c1f51d7fd43899cc570
Reviewed-on: https://chromium-review.googlesource.com/445024
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/3da9d728fa3c388f3aec2ae873924baa8222af4f/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_builder.json
[modify] https://crrev.com/3da9d728fa3c388f3aec2ae873924baa8222af4f/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder_forced.json
[modify] https://crrev.com/3da9d728fa3c388f3aec2ae873924baa8222af4f/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder.json
[modify] https://crrev.com/3da9d728fa3c388f3aec2ae873924baa8222af4f/scripts/slave/recipe_modules/webrtc/chromium_config.py

Project Member

Comment 11 by bugdroid1@chromium.org, Feb 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/45191f3bfdf590993582f180df558b70d37ae710

commit 45191f3bfdf590993582f180df558b70d37ae710
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Sun Feb 19 09:37:41 2017

Revert "WebRTC: Add video quality loopback test to android. Take 4"

This reverts commit d0248b51bee0e4e68a282883dfa0b505d1026a53.

Reason for revert: The test is failing: https://bugs.chromium.org/p/webrtc/issues/detail?id=7145
and we don't have a good way to just make it skip (even if returning exit code 0 it's counted as a failure on the bots: https://build.chromium.org/p/client.webrtc.perf/builders/Android32%20Tests%20%28L%20Nexus5%29/builds/1805)

Original change's description:
> WebRTC: Add video quality loopback test to android. Take 4
> 
> The path to the output dir needs to be passed as an absolute path.
> 
> BUG= chromium:685222 
> TBR=ehmaldonado@chromium.org
> 
> Change-Id: I604053723cae8ac30d08c9934ca8fb2805155ccf
> Reviewed-on: https://chromium-review.googlesource.com/444228
> Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
> Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
> 

TBR=kjellander@chromium.org,ehmaldonado@chromium.org,chromium-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:685222 

Change-Id: I3bc758fe8fdfc673c008ba828c780e3b196bbb70
Reviewed-on: https://chromium-review.googlesource.com/444410
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/45191f3bfdf590993582f180df558b70d37ae710/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus6_.json
[modify] https://crrev.com/45191f3bfdf590993582f180df558b70d37ae710/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5_.json
[modify] https://crrev.com/45191f3bfdf590993582f180df558b70d37ae710/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__k_nexus5_.json
[modify] https://crrev.com/45191f3bfdf590993582f180df558b70d37ae710/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus4_.json
[modify] https://crrev.com/45191f3bfdf590993582f180df558b70d37ae710/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__n_nexus6_.json
[modify] https://crrev.com/45191f3bfdf590993582f180df558b70d37ae710/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced.json
[modify] https://crrev.com/45191f3bfdf590993582f180df558b70d37ae710/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json
[modify] https://crrev.com/45191f3bfdf590993582f180df558b70d37ae710/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/45191f3bfdf590993582f180df558b70d37ae710/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__l_nexus9_.json
[modify] https://crrev.com/45191f3bfdf590993582f180df558b70d37ae710/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus7_2_.json

Edward. I gave this some thinking and I've come up with this approach to make it possible for Magnus to try out things on the bots (since he's unable to repro the errors we're seeing locally):

* Create a CL in WebRTC repo that allows the test to run on Swarming (i.e. add isolate config in mb.py if needed etc). While doing this, we should also do the same for webrtc_perf_tests (to be added to trybots in  bug 687890  but waiting for final work in https://bugs.chromium.org/p/webrtc/issues/detail?id=7153).
* Make an infra CL adding this to a new trybot config, which is not default in the CQ.  I suggest adding a new bot: android_experimental.

Could you take a stab at this? It's becoming more and more urgent to get something up here.
Why allow it to run on Swarming? So we don't need actual devices?
Because we don't have any machines with dedicated devices in our try server like the ones we have in the perf waterfall. When running on Swarming it will still run on a device but I'm hoping we'll be able to find the culprit and get the test to run reliably, since mandermo@ hasn't been able to reproduce the problem we saw on the bots on his machine.
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/41f8a88e4fb8070d0422d74920d29383c6777e21

commit 41f8a88e4fb8070d0422d74920d29383c6777e21
Author: ehmaldonado <ehmaldonado@webrtc.org>
Date: Wed Mar 08 12:22:36 2017

Add AppRTCMobileTestStubbedVideoIO to gn_isolate_map.

This will make it possible for the test to run on swarming bots.

BUG= chromium:685222 
R=kjellander@webrtc.org
NOTRY=True

Review-Url: https://codereview.webrtc.org/2731423004
Cr-Commit-Position: refs/heads/master@{#17113}

[modify] https://crrev.com/41f8a88e4fb8070d0422d74920d29383c6777e21/tools-webrtc/mb/gn_isolate_map.pyl

Project Member

Comment 17 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/efff7c534d021121cc9cd5647f9365f1cd019c1a

commit efff7c534d021121cc9cd5647f9365f1cd019c1a
Author: Henrik Kjellander <kjellander@webrtc.org>
Date: Thu Mar 09 06:18:27 2017

MB: Add android_experimental trybot configuration

Replaced the unused android_n6 config and changed it
to build Release for ARM 32-bit.

BUG= chromium:685222 
NOTRY=True
TBR=ehmaldonado@webrtc.org

Review-Url: https://codereview.webrtc.org/2741653002 .
Cr-Commit-Position: refs/heads/master@{#17127}

[modify] https://crrev.com/efff7c534d021121cc9cd5647f9365f1cd019c1a/tools-webrtc/mb/mb_config.pyl

Project Member

Comment 18 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/4f68ae30f79706de6c1b395a9f73d4627c9f20da

commit 4f68ae30f79706de6c1b395a9f73d4627c9f20da
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Thu Mar 09 06:46:27 2017

WebRTC: Fix typo in AppRTCMobileTestStubbedVideoIO test

The new experimental bot added in
https://chromium-review.googlesource.com/451498
had a typo in the GN target name.

TBR=ehmaldonado@chromium.org
BUG= chromium:685222 

Change-Id: Ia704a43375ec1db779e5c2ca307996d23cedbbfe
Reviewed-on: https://chromium-review.googlesource.com/452297
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/4f68ae30f79706de6c1b395a9f73d4627c9f20da/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_experimental.json
[modify] https://crrev.com/4f68ae30f79706de6c1b395a9f73d4627c9f20da/scripts/slave/recipe_modules/webrtc/steps.py

Project Member

Comment 19 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/4f68ae30f79706de6c1b395a9f73d4627c9f20da

commit 4f68ae30f79706de6c1b395a9f73d4627c9f20da
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Thu Mar 09 06:46:27 2017

WebRTC: Fix typo in AppRTCMobileTestStubbedVideoIO test

The new experimental bot added in
https://chromium-review.googlesource.com/451498
had a typo in the GN target name.

TBR=ehmaldonado@chromium.org
BUG= chromium:685222 

Change-Id: Ia704a43375ec1db779e5c2ca307996d23cedbbfe
Reviewed-on: https://chromium-review.googlesource.com/452297
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/4f68ae30f79706de6c1b395a9f73d4627c9f20da/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_experimental.json
[modify] https://crrev.com/4f68ae30f79706de6c1b395a9f73d4627c9f20da/scripts/slave/recipe_modules/webrtc/steps.py

Owner: oprypin@chromium.org
Oleh is taking over this.
Project Member

Comment 21 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ddd9bbfb0c1822049db7e27a59854ed81c106dac

commit ddd9bbfb0c1822049db7e27a59854ed81c106dac
Author: Oleh Prypin <oprypin@chromium.org>
Date: Tue Apr 25 08:17:37 2017

WebRTC: Add video quality loopback test to android. Take 5

BUG= chromium:685222 

Change-Id: I97dd88d9b50e2d4ec0784237c0177ffb2d727f65
Reviewed-on: https://chromium-review.googlesource.com/486299
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>

[modify] https://crrev.com/ddd9bbfb0c1822049db7e27a59854ed81c106dac/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus6_.json
[modify] https://crrev.com/ddd9bbfb0c1822049db7e27a59854ed81c106dac/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5_.json
[modify] https://crrev.com/ddd9bbfb0c1822049db7e27a59854ed81c106dac/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__k_nexus5_.json
[modify] https://crrev.com/ddd9bbfb0c1822049db7e27a59854ed81c106dac/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus4_.json
[modify] https://crrev.com/ddd9bbfb0c1822049db7e27a59854ed81c106dac/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__n_nexus6_.json
[modify] https://crrev.com/ddd9bbfb0c1822049db7e27a59854ed81c106dac/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced.json
[modify] https://crrev.com/ddd9bbfb0c1822049db7e27a59854ed81c106dac/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json
[modify] https://crrev.com/ddd9bbfb0c1822049db7e27a59854ed81c106dac/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/ddd9bbfb0c1822049db7e27a59854ed81c106dac/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__l_nexus9_.json
[modify] https://crrev.com/ddd9bbfb0c1822049db7e27a59854ed81c106dac/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus7_2_.json

Project Member

Comment 22 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/99164f601e87f07d382889014617f15bca75f20b

commit 99164f601e87f07d382889014617f15bca75f20b
Author: Oleh Prypin <oprypin@chromium.org>
Date: Tue Apr 25 12:02:11 2017

Revert "WebRTC: Add video quality loopback test to android. Take 5"

This reverts commit ddd9bbfb0c1822049db7e27a59854ed81c106dac.

Reason for revert:
The test still fails on buildbots with "No activities found".

Original change's description:
> WebRTC: Add video quality loopback test to android. Take 5
> 
> BUG= chromium:685222 
> 
> Change-Id: I97dd88d9b50e2d4ec0784237c0177ffb2d727f65
> Reviewed-on: https://chromium-review.googlesource.com/486299
> Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
> Commit-Queue: Oleh Prypin <oprypin@chromium.org>
> 

TBR=kjellander@chromium.org,ehmaldonado@chromium.org,oprypin@chromium.org,chromium-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:685222 

Change-Id: I0428e13f99e2623e76c2ce7463ff7540d34fe109
Reviewed-on: https://chromium-review.googlesource.com/486305
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/99164f601e87f07d382889014617f15bca75f20b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus6_.json
[modify] https://crrev.com/99164f601e87f07d382889014617f15bca75f20b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5_.json
[modify] https://crrev.com/99164f601e87f07d382889014617f15bca75f20b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__k_nexus5_.json
[modify] https://crrev.com/99164f601e87f07d382889014617f15bca75f20b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus4_.json
[modify] https://crrev.com/99164f601e87f07d382889014617f15bca75f20b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__n_nexus6_.json
[modify] https://crrev.com/99164f601e87f07d382889014617f15bca75f20b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced.json
[modify] https://crrev.com/99164f601e87f07d382889014617f15bca75f20b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json
[modify] https://crrev.com/99164f601e87f07d382889014617f15bca75f20b/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/99164f601e87f07d382889014617f15bca75f20b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__l_nexus9_.json
[modify] https://crrev.com/99164f601e87f07d382889014617f15bca75f20b/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus7_2_.json

Project Member

Comment 23 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/6090db20c4bc86d175ecc78e2b2cee649ffe06cf

commit 6090db20c4bc86d175ecc78e2b2cee649ffe06cf
Author: Oleh Prypin <oprypin@chromium.org>
Date: Wed Apr 26 14:35:36 2017

WebRTC: Add video quality loopback test to android. Take 6

The test has been fixed to work without an internet connection.

BUG= chromium:685222 

Change-Id: I89a9f5d9a50bd29cc2ed22bb7e477ef8db2d6af0
Reviewed-on: https://chromium-review.googlesource.com/487962
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>

[modify] https://crrev.com/6090db20c4bc86d175ecc78e2b2cee649ffe06cf/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus6_.json
[modify] https://crrev.com/6090db20c4bc86d175ecc78e2b2cee649ffe06cf/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5_.json
[modify] https://crrev.com/6090db20c4bc86d175ecc78e2b2cee649ffe06cf/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__k_nexus5_.json
[modify] https://crrev.com/6090db20c4bc86d175ecc78e2b2cee649ffe06cf/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus4_.json
[modify] https://crrev.com/6090db20c4bc86d175ecc78e2b2cee649ffe06cf/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__n_nexus6_.json
[modify] https://crrev.com/6090db20c4bc86d175ecc78e2b2cee649ffe06cf/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced.json
[modify] https://crrev.com/6090db20c4bc86d175ecc78e2b2cee649ffe06cf/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json
[modify] https://crrev.com/6090db20c4bc86d175ecc78e2b2cee649ffe06cf/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/6090db20c4bc86d175ecc78e2b2cee649ffe06cf/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__l_nexus9_.json
[modify] https://crrev.com/6090db20c4bc86d175ecc78e2b2cee649ffe06cf/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus7_2_.json

Project Member

Comment 24 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/902c9df1c55e10db441703cbbaea9e5f72165e0a

commit 902c9df1c55e10db441703cbbaea9e5f72165e0a
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Wed Apr 26 19:36:25 2017

WebRTC: Skip video_quality_loopback_test on Android K perf bot.

The test doesn't seem to support Android K. Let's skip it for now
until we've figured out if we want to support this version.

BUG= chromium:685222 
TBR=ehmaldonado@chromium.org
CC=oprypin@chromium.org

Change-Id: Ie605b1ade2b8cded686e4e868d6464b7b2d16fdc
Reviewed-on: https://chromium-review.googlesource.com/488222
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/902c9df1c55e10db441703cbbaea9e5f72165e0a/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__k_nexus5_.json
[modify] https://crrev.com/902c9df1c55e10db441703cbbaea9e5f72165e0a/scripts/slave/recipe_modules/webrtc/steps.py

Status: Fixed (was: Assigned)

Sign in to add a comment