Don't show "Form Not Secure" prompt on Page Load |
||||||
Issue descriptionIn Issue 672668 , we started showing Form Not Secure on form fields on page load. Due to general glitchiness, we don't want that behavior for now. Test page: http://http-login.badssl.com Removing this ShowNotSecureWarning call: https://cs.chromium.org/chromium/src/components/autofill/content/renderer/password_autofill_agent.cc?sq=package:chromium&rcl=1485332207&l=1270
,
Jan 27 2017
,
Jan 30 2017
I think we need a merge for the commit in comment 1 (elawrence please correct if this is premature)
,
Jan 30 2017
This bug requires manual review: DEPS changes referenced in bugdroid comments. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 30 2017
Before we approve merge to M57, could you please confirm change listed #1 is well baked/verified in Canary and safe to merge to M57?
,
Jan 30 2017
Re #5: Change landed on Thursday and has no reported problems in Canary; it fixes several known UX glitches by not showing the FNS UI in problematic cases. The change itself was very simple and should not carry any risk.
,
Jan 30 2017
Approving merge to M57 branch 2987 based on comment #6. Please merge ASAP. Thank you.
,
Jan 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fc2b249856943818575ae4f6030193bd326596c commit 7fc2b249856943818575ae4f6030193bd326596c Author: Emily Stark <estark@google.com> Date: Mon Jan 30 19:24:36 2017 Don't show FormNotSecure warning on page load Previously, we showed the FormNotSecure warning popup on form fields if an autofill occurred on page load. This proved to be too glitchy, so it is being removed for the time being. The notice will still appear when the user interacts with the form fields. BUG= 685213 Review-Url: https://codereview.chromium.org/2656913002 Cr-Commit-Position: refs/heads/master@{#446363} (cherry picked from commit 09f615ca6182adcf1dff3e55465b5dfdf7f27260) Review-Url: https://codereview.chromium.org/2661973002 . Cr-Commit-Position: refs/branch-heads/2987@{#171} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [delete] https://crrev.com/e1e7d7ff6eed446848c90fee771487669ba4466f/chrome/renderer/autofill/DEPS [modify] https://crrev.com/7fc2b249856943818575ae4f6030193bd326596c/chrome/renderer/autofill/password_autofill_agent_browsertest.cc [modify] https://crrev.com/7fc2b249856943818575ae4f6030193bd326596c/components/autofill/content/common/autofill_types.mojom [modify] https://crrev.com/7fc2b249856943818575ae4f6030193bd326596c/components/autofill/content/common/autofill_types_struct_traits.cc [modify] https://crrev.com/7fc2b249856943818575ae4f6030193bd326596c/components/autofill/content/common/autofill_types_struct_traits.h [modify] https://crrev.com/7fc2b249856943818575ae4f6030193bd326596c/components/autofill/content/renderer/password_autofill_agent.cc [modify] https://crrev.com/7fc2b249856943818575ae4f6030193bd326596c/components/autofill/core/common/password_form_fill_data.cc [modify] https://crrev.com/7fc2b249856943818575ae4f6030193bd326596c/components/autofill/core/common/password_form_fill_data.h [modify] https://crrev.com/7fc2b249856943818575ae4f6030193bd326596c/components/password_manager/core/browser/password_form_manager_unittest.cc [modify] https://crrev.com/7fc2b249856943818575ae4f6030193bd326596c/components/password_manager/core/browser/password_manager.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jan 26 2017