New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685210 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: ----



Sign in to add a comment

Add UMA for latency of notification clicks going through NotificationJobService

Project Member Reported by awdf@chromium.org, Jan 25 2017

Issue description

Once  http://crbug.com/663427  is resolved we'll be using the NotificationJobService to handle notification clicks (and closes) on Android N and above.

We ask Android to execute our jobs immediately (override deadline of 0ms), but we should add UMA to check in case this actually introduces a noticeable lag.

(Note there is already a noticeable lag if Chrome is killed when a notification is clicked and we have to start up the whole browser process.. this is just to check we're not introducing further lag)
 

Comment 1 by awdf@chromium.org, Jan 25 2017

Description: Show this description

Comment 2 by awdf@chromium.org, Mar 22 2017

Owner: awdf@chromium.org

Comment 3 by awdf@chromium.org, Mar 22 2017

Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00570565583c855e12888ca88e891d12c39541f1

commit 00570565583c855e12888ca88e891d12c39541f1
Author: Anita Woodruff <awdf@chromium.org>
Date: Fri Oct 13 10:45:38 2017

Android - add UMA for notification job start delay

- Re-uploading from https://codereview.chromium.org/2769713002

Bug:  685210 
Change-Id: I12a3d997440095650673c942154b5a94958c3e15
Reviewed-on: https://chromium-review.googlesource.com/712159
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508668}
[modify] https://crrev.com/00570565583c855e12888ca88e891d12c39541f1/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java
[modify] https://crrev.com/00570565583c855e12888ca88e891d12c39541f1/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationJobService.java
[modify] https://crrev.com/00570565583c855e12888ca88e891d12c39541f1/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
[modify] https://crrev.com/00570565583c855e12888ca88e891d12c39541f1/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java
[modify] https://crrev.com/00570565583c855e12888ca88e891d12c39541f1/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeTest.java
[modify] https://crrev.com/00570565583c855e12888ca88e891d12c39541f1/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment