New issue
Advanced search Search tips

Issue 685209 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

The Payment Request dialog rows that are clickable should be highlighted on hover.

Project Member Reported by anthonyvd@chromium.org, Jan 25 2017

Issue description

The specifics of the highlighting are shown in the mocks. Note that the highlight extends to the border of the dialog while the lower border does not.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8580766009627c5aeb0625172c3f3c576d7c3636

commit 8580766009627c5aeb0625172c3f3c576d7c3636
Author: anthonyvd <anthonyvd@chromium.org>
Date: Fri Jan 27 23:16:36 2017

[Web Payments] Refactor the row display code.

This CL extracts the common bits of row views into a separate class.
This will allow the hover effect as well as the border styling to be
used in multiple screens easily.

The rows also now properly display their hover effects.

BUG= 685209 

Review-Url: https://codereview.chromium.org/2656853002
Cr-Commit-Position: refs/heads/master@{#446821}

[modify] https://crrev.com/8580766009627c5aeb0625172c3f3c576d7c3636/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/8580766009627c5aeb0625172c3f3c576d7c3636/chrome/browser/ui/views/payments/order_summary_view_controller.cc
[add] https://crrev.com/8580766009627c5aeb0625172c3f3c576d7c3636/chrome/browser/ui/views/payments/payment_request_row_view.cc
[add] https://crrev.com/8580766009627c5aeb0625172c3f3c576d7c3636/chrome/browser/ui/views/payments/payment_request_row_view.h
[modify] https://crrev.com/8580766009627c5aeb0625172c3f3c576d7c3636/chrome/browser/ui/views/payments/payment_request_views_util.cc
[modify] https://crrev.com/8580766009627c5aeb0625172c3f3c576d7c3636/chrome/browser/ui/views/payments/payment_request_views_util.h
[modify] https://crrev.com/8580766009627c5aeb0625172c3f3c576d7c3636/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/8580766009627c5aeb0625172c3f3c576d7c3636/ui/views/view.cc
[modify] https://crrev.com/8580766009627c5aeb0625172c3f3c576d7c3636/ui/views/view.h

Status: Fixed (was: Assigned)

Sign in to add a comment