New issue
Advanced search Search tips

Issue 685197 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 663427



Sign in to add a comment

Keep the wakelock until we've finished handling the notification event

Project Member Reported by awdf@chromium.org, Jan 25 2017

Issue description

OS: Android

We should ensure that the browser process cannot be killed (eg for low memory reasons) while a notification interaction event is being processed.

For the NotificationJobService code path (see  http://crbug.com/663427 ), we already hold this wakelock while starting up the browser, but there is still a window where our process may be killed whilst the notification is being processed by async native code which calls the service worker (which is allowed up to 1 minute of execution time).

We can retain the wakelock Android gives us in onStartJob by by returning true there, and then calling jobFinished once the event has been completely handled (ie once serviceWorkerRegistration.onNotificationClicked has returned).
 
Project Member

Comment 1 by sheriffbot@chromium.org, Feb 12 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by peter@chromium.org, Feb 12 2018

Owner: peter@chromium.org
Status: Assigned (was: Untriaged)
We want to do this.

Comment 3 by peter@chromium.org, Feb 12 2018

Labels: -Hotlist-Recharge-Cold

Sign in to add a comment