New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 685168 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
█ kjellander@chromium.org
hbos@chromium.org
mflodman@chromium.org
sprang@chromium.org
brandtr@chromium.org
terelius@chromium.org
holmer@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: ----



Sign in to add a comment

enable MSAN for OpenH264 assembly

Project Member Reported by hta@chromium.org, Jan 25 2017 
When landing assembly for OpenH264 encoding, the msan bot turns flaky.

https://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/16972 is an example (log attached).

The short term fix is to disable assembly for MSAN builds.

The issue has been reported upstream:

https://github.com/cisco/openh264/issues/2652

Long term, we want to have MSAN active for the code we run in production, so this is not a happy fix.
text.txt
31.9 KB View Download

Comment 1 by hta@chromium.org, Apr 5 2017

Owner: guidou@chromium.org
The issue is that MSAN is unable to check that assignment is done inside assembly. The code is working correctly, and always initializes the variables, so upstream won't make code changes to account for this.

So the issue can be solved by MSAN exclusions, or by MSAN improvements.

Comment 2 by guidou@chromium.org, Sep 14 2017

Owner: ----

Comment 3 by guidou@chromium.org, Sep 14 2017

Components: Blink>WebRTC>Video

Comment 4 by brandtr@chromium.org, Sep 15 2017

Status: Available (was: Unconfirmed)
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 17

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by holmer@google.com, Oct 12

Status: Available (was: Untriaged)
►

Sign in to add a comment