New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685108 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit 16 days ago
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[image_fetcher] parse multi-dimensional ICO files

Project Member Reported by jkrcal@chromium.org, Jan 25 2017

Issue description

Image fetcher does not seem to support multi-dimensional ICO files. 

This is a requirement if (ever) the image_fetcher should be used by the favicon service.
 
One example this might be causing: http://crbug/690029
i dug a bit deeper: when calling the image-decoder, we do not provide a desired-size: https://cs.chromium.org/chromium/src/services/image_decoder/image_decoder_impl.cc?rcl=90d1657ffcf4eb720c60e572453477fad72377f9&l=70
For the ico fetching, this probably leads to loading the smallest size (which is too small to be shown on the NTP).

If we want to support multiple resolutions, we need a different way to decode the image (collecting all frames).

Comment 3 by jkrcal@chromium.org, Feb 27 2017

Why is loading the largest size the wrong hack for http://crbug/690029, now?
Status: Assigned (was: Untriaged)

Sign in to add a comment