Issue metadata
Sign in to add a comment
|
Regression : "Nothing to see here..." Text is seen missing in Downloads Folder |
||||||||||||||||||||||
Issue descriptionChrome Version: 57.0.2987.8/9202.4.0 dev-channel Daisy,Candy,Peppy and Mighty OS: Chrome Pre-Condition : Make sure Downloads Folder is empty What steps will reproduce the problem? (1)Sign into User -> Click on Launcher available at L.H.S of Shelf (2)Select "Files" to open Downloads -> Now observe for "Nothing to see here..." Text (Please refer screenshots) Expected:"Nothing to see here..." Text should be seen in Downloads Folder when there are no folders,Files etc Actual: Instead "Nothing to see here..." Text is seen missing This is Regression issue as same is working fine in 56.0.2924.67/9000.66.0 Beta-channel Quawks @fukino: Please confirm the issue
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d0085691a3932c3e299c4af35f71e6e97dc3222 commit 1d0085691a3932c3e299c4af35f71e6e97dc3222 Author: fukino <fukino@chromium.org> Date: Thu Jan 26 09:16:50 2017 Files app: Correct the order of file-list layer and empty-folder layer. The UI indicating that the folder is empty is behind the file-list layer. It used to be visible because the file-list has transparent background, but with https://codereview.chromium.org/2554433002, file-list got background color and the UI turned invisible. We should correct the order of layers instead of reverting the background color of file list, as the background color of file list is necessary to make use of native overlay scrollbar. BUG= 685106 TEST=manually tested CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2652413002 Cr-Commit-Position: refs/heads/master@{#446280} [modify] https://crrev.com/1d0085691a3932c3e299c4af35f71e6e97dc3222/ui/file_manager/file_manager/main.html
,
Jan 26 2017
,
Jan 26 2017
Approving merge to M57 Chrome OS.
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2164fd8d8d0be849a16e5cec17ee2cd0a7995184 commit 2164fd8d8d0be849a16e5cec17ee2cd0a7995184 Author: Naoki Fukino <fukino@chromium.org> Date: Thu Jan 26 23:14:49 2017 Files app: Correct the order of file-list layer and empty-folder layer. The UI indicating that the folder is empty is behind the file-list layer. It used to be visible because the file-list has transparent background, but with https://codereview.chromium.org/2554433002, file-list got background color and the UI turned invisible. We should correct the order of layers instead of reverting the background color of file list, as the background color of file list is necessary to make use of native overlay scrollbar. BUG= 685106 TEST=manually tested TBR=yamaguchi@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2652413002 Cr-Commit-Position: refs/heads/master@{#446280} (cherry picked from commit 1d0085691a3932c3e299c4af35f71e6e97dc3222) Review-Url: https://codereview.chromium.org/2662483002 . Cr-Commit-Position: refs/branch-heads/2987@{#124} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/2164fd8d8d0be849a16e5cec17ee2cd0a7995184/ui/file_manager/file_manager/main.html
,
Jan 26 2017
,
Jan 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8fbb4032d36b3ae10373db8d489a0f9276cc5d54 commit 8fbb4032d36b3ae10373db8d489a0f9276cc5d54 Author: fukino <fukino@chromium.org> Date: Mon Jan 30 06:59:01 2017 Revert of Files app: Correct the order of file-list layer and empty-folder layer. (patchset #1 id:1 of https://codereview.chromium.org/2652413002/ ) Reason for revert: This change causes a regression crbug.com/686618 . Original issue's description: > Files app: Correct the order of file-list layer and empty-folder layer. > > The UI indicating that the folder is empty is behind the file-list layer. > It used to be visible because the file-list has transparent background, but with > https://codereview.chromium.org/2554433002, file-list got background color and > the UI turned invisible. > We should correct the order of layers instead of reverting the background color > of file list, as the background color of file list is necessary to make use of > native overlay scrollbar. > > BUG= 685106 > TEST=manually tested > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2652413002 > Cr-Commit-Position: refs/heads/master@{#446280} > Committed: https://chromium.googlesource.com/chromium/src/+/1d0085691a3932c3e299c4af35f71e6e97dc3222 TBR=yamaguchi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 685106 , 686618 Review-Url: https://codereview.chromium.org/2659313002 Cr-Commit-Position: refs/heads/master@{#446961} [modify] https://crrev.com/8fbb4032d36b3ae10373db8d489a0f9276cc5d54/ui/file_manager/file_manager/main.html
,
Jan 30 2017
Google Chrome 57.0.2987.17 (Official Build) dev (32-bit) Revision 0 Platform 9202.10.0 (Official Build) dev-channel
,
Feb 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1836bb99563be3c67db606dbfacd5c719499a2e commit c1836bb99563be3c67db606dbfacd5c719499a2e Author: Naoki Fukino <fukino@chromium.org> Date: Mon Feb 06 05:29:28 2017 Revert of Files app: Correct the order of file-list layer and empty-folder layer. (patchset #1 id:1 of https://codereview.chromium.org/2652413002/ ) Reason for revert: This change causes a regression crbug.com/686618 . Original issue's description: > Files app: Correct the order of file-list layer and empty-folder layer. > > The UI indicating that the folder is empty is behind the file-list layer. > It used to be visible because the file-list has transparent background, but with > https://codereview.chromium.org/2554433002, file-list got background color and > the UI turned invisible. > We should correct the order of layers instead of reverting the background color > of file list, as the background color of file list is necessary to make use of > native overlay scrollbar. > > BUG= 685106 > TEST=manually tested > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2652413002 > Cr-Commit-Position: refs/heads/master@{#446280} > Committed: https://chromium.googlesource.com/chromium/src/+/1d0085691a3932c3e299c4af35f71e6e97dc3222 TBR=yamaguchi@chromium.org BUG= 685106 , 686618 Review-Url: https://codereview.chromium.org/2659313002 Cr-Commit-Position: refs/heads/master@{#446961} (cherry picked from commit 8fbb4032d36b3ae10373db8d489a0f9276cc5d54) Review-Url: https://codereview.chromium.org/2677023002 . Cr-Commit-Position: refs/branch-heads/2987@{#317} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/c1836bb99563be3c67db606dbfacd5c719499a2e/ui/file_manager/file_manager/main.html |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by fukino@chromium.org
, Jan 26 2017