Add Bundle ID of Enpass Password Manager's extension to the whitelist.
Reported by
si...@sinew.in,
Jan 25 2017
|
|||||
Issue descriptionSteps to reproduce the problem: 1. Install Enpass app from https://itunes.apple.com/in/app/enpass-password-manager/id455566716?mt=8) 2. Setup password for Enpass and add a demo Facebook item with url "www.facebook.com". https://www.enpass.io/docs/ios/create.html 3. Enable Enpass extension from inside Chrome (Using "Share" activities) 4. Open www.facebook.com in Chrome. 5. Tap on 'Share' button which will show Enpass App for autofilling. 6. Tap on Facebook item (created in step 2) to autofill username and password in the webpage. What is the expected behavior? On tapping 'Facebook' item, username and password should be autofilled on webpage just like 1Password, LastPass and other password managers do. What went wrong? Login filling by Enpass extension doesn't work because - Bundle ID of Enpass extension doesn't contain the string "find-login-action" and due to that Chrome for iOS doesn't treat Enpass as password manager. Did this work before? No Chrome version: 55.0.2883.79 Channel: stable OS Version: 10.2 Flash Version: Hello, I'm from Enpass password manager and many of our users have reported here https://discussion.enpass.io/index.php?/topic/143-support-for-other-browsers-than-safari/#comment-578 that Chrome for iOS does autofill from Enpass extension while Chrome does so with other password managers. The same issue was reported to you by other password managers here https://bugs.chromium.org/p/chromium/issues/detail?id=405894 Enpass is being used by million of users worldwise on all the platforms where it works well with Chrome browser (on Android/Mac/Linux/Windows) but on iOS it creates problem. One of the solution is that we have to add string "find-login-action" to our Bundle ID and altering the Bundle ID is not possible for us. The only solution ================= The only possible solution to fix this issue is to add our extension's bundle ID "in.sinew.Walletx.WalletxExt" to your whitelist just like you've done for 1Password & other password managers here https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/activity_services/activity_type_util.mm Tons of thanks, Enpass team and users
,
Mar 15 2017
,
Mar 15 2017
The quickest way would be for Enpass extension to contain the "find-login-action" in its bundle ID. I understand that may not be possible for every app for different reasons. The alternative would be for Chrome to explicitly whitelist apps like it has been done for some apps in the past. The issue with whitelisting is that it is slightly more labour intensive than I would like. Now that Chrome is open source, anyone (Enpass included) can submit a patch and I would be happy to review the change. I've also been thinking about refactoring that part of the code to make the whitelisting lower friction and easier for simple straight forward whitelist requests.
,
Apr 17 2017
,
Apr 19 2017
,
Apr 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9132013d56d23c4212c0137c270cf474871c80f0 commit 9132013d56d23c4212c0137c270cf474871c80f0 Author: pkl <pkl@chromium.org> Date: Thu Apr 20 20:38:50 2017 Adds Enpass Password Manager to kAllPasswordManagerApps App: https://itunes.apple.com/us/app/enpass-password-manager/id455566716?mt=8 BUG= 685094 TEST=Install Enpass app and test that extension works NOTRY=true Review-Url: https://codereview.chromium.org/2820113002 Cr-Commit-Position: refs/heads/master@{#466114} [modify] https://crrev.com/9132013d56d23c4212c0137c270cf474871c80f0/ios/chrome/browser/ui/activity_services/activity_type_util.mm
,
Apr 21 2017
Verified on Chrome 60.0.3077.0 canary.
,
Apr 21 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sczs@chromium.org
, Jan 25 2017Owner: pkl@chromium.org
Status: Assigned (was: Unconfirmed)