New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685084 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Buried. Ping if important.
Closed: Jan 2017
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 435547



Sign in to add a comment

Add deprecation warnings for blocked subresource types.

Project Member Reported by mkwst@chromium.org, Jan 25 2017

Issue description

I should have added deprecation warnings ~2 years ago, but apparently I didn't. Now I am.
 

Comment 1 by mkwst@chromium.org, Jan 26 2017

Labels: Merge-Request-57
I should have tied https://codereview.chromium.org/2647283007 to this bug, but I didn't. :(

Friendly release managers, I hope you'll let me merge that patch back to 57 anyway, to ensure that we give developers as much warning as possible about upcoming deprecations. The patch only adds deprecation warnings to the console, and has zero substantive effect on the product.

Comment 2 by gov...@chromium.org, Jan 26 2017

Is this change applicable to All OSes or any specific OS?
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 27 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by mkwst@chromium.org, Jan 27 2017

Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
govind@: All Blink OSs (e.g. not iOS). I've updated the OS labels accordingly. Thanks!

Comment 5 by gov...@chromium.org, Jan 27 2017

Thank you. Please merge your change to M57 branch 2987 before 5:00 PM PT, Friday (01/27) so we can pick it up for next week last Dev release.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 27 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/781c4e2bbdd94ae563f4540136a2384443e5ec5d

commit 781c4e2bbdd94ae563f4540136a2384443e5ec5d
Author: Mike West <mkwst@google.com>
Date: Fri Jan 27 08:06:12 2017

Add deprecation messages for blocked subresource types.

Intent 1: https://groups.google.com/a/chromium.org/d/msg/blink-dev/bIJdwwoQ98U/-F1aL2FgBAAJ
Intent 2: https://groups.google.com/a/chromium.org/d/msg/blink-dev/lx-U_JR2BF0/Hsg1fiZiBAAJ

BUG=435547,504300, 685084 

Review-Url: https://codereview.chromium.org/2647283007
Cr-Commit-Position: refs/heads/master@{#446038}
(cherry picked from commit 81c970230a492e70e9a580c38e4de8a3f0fcc29b)

Review-Url: https://codereview.chromium.org/2659823004 .
Cr-Commit-Position: refs/branch-heads/2987@{#136}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/781c4e2bbdd94ae563f4540136a2384443e5ec5d/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-xhr-replay-expected.txt
[modify] https://crrev.com/781c4e2bbdd94ae563f4540136a2384443e5ec5d/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/multiple-report-policies-expected.txt
[add] https://crrev.com/781c4e2bbdd94ae563f4540136a2384443e5ec5d/third_party/WebKit/LayoutTests/http/tests/security/deprecated-subresource-requests-expected.txt
[add] https://crrev.com/781c4e2bbdd94ae563f4540136a2384443e5ec5d/third_party/WebKit/LayoutTests/http/tests/security/deprecated-subresource-requests.html
[modify] https://crrev.com/781c4e2bbdd94ae563f4540136a2384443e5ec5d/third_party/WebKit/LayoutTests/http/tests/security/location-href-clears-username-password-expected.txt
[modify] https://crrev.com/781c4e2bbdd94ae563f4540136a2384443e5ec5d/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt
[modify] https://crrev.com/781c4e2bbdd94ae563f4540136a2384443e5ec5d/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/failed-auth-expected.txt
[modify] https://crrev.com/781c4e2bbdd94ae563f4540136a2384443e5ec5d/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/logout-expected.txt
[modify] https://crrev.com/781c4e2bbdd94ae563f4540136a2384443e5ec5d/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/null-auth-expected.txt
[modify] https://crrev.com/781c4e2bbdd94ae563f4540136a2384443e5ec5d/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/remember-bad-password-expected.txt
[modify] https://crrev.com/781c4e2bbdd94ae563f4540136a2384443e5ec5d/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/referer-expected.txt
[modify] https://crrev.com/781c4e2bbdd94ae563f4540136a2384443e5ec5d/third_party/WebKit/LayoutTests/security/block-test-expected.txt
[modify] https://crrev.com/781c4e2bbdd94ae563f4540136a2384443e5ec5d/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/781c4e2bbdd94ae563f4540136a2384443e5ec5d/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

Comment 7 by mkwst@chromium.org, Jan 27 2017

Status: Fixed (was: Started)
Landed on 2987, thanks!

Sign in to add a comment