Regression: Blank ‘Sync confirmation’ overlay is seen after clicking on 'Undo' button
Reported by
jshan...@etouch.net,
Jan 25 2017
|
|||||||
Issue descriptionChrome Version:58.0.2992.0 (Official Build)25ff90033184e53f7fd47b44511397da29a1ce27-refs/heads/master@{#445908}-32/64 bit OS: Windows(7,8,10), Mac(10.10.5, 10.11.4), Linux(14.04 LTS). Steps: 1. Launch Chrome, navigate chrome://settings and click on 'Sign in to Chrome' button 2. Enter valid email id and password and proceed till ‘Sync confirmation’ overlay appears 3. Drag the 'Settings' links to NTP, ‘Sync confirmation’ overlay opens on NTP then click on 'Undo' button 4. Observe Actual: Blank ‘Sync confirmation’ overlay remain open even after clicking on 'Undo' button Expected: Blank ‘Sync confirmation’ overlay should not be seen after clicking on 'Undo' button This is a regression issue broken in ‘M-57’, below is the Manual Regression range and will soon update other info. Good build : 57.0.2959.0 Bad build : 57.0.2960.0
,
Jan 25 2017
Adding Release block beta.Please undo if not the case. Thank You!
,
Jan 25 2017
I do not think this needs to block beta (it is a very very corner case).
,
Feb 10 2017
Just to update the issue, this behavior is observed on Mac 10.12.3 with chrome version #58.0.3007.0 msarda@ will you update the lastest info on this issue. Thank You...
,
Feb 10 2017
Able to reproduce this issue on Windows 10 with chrome version #58.0.3007.0 Attaching the screen-cast for reference.
,
Feb 10 2017
CC+ jlebel@ It seems this is a bug both on Windows and macOS. I think the dialog dismissal code is different on these platforms.
,
Feb 10 2017
,
Feb 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1100249acef2cfa42c46deb9279bbd864d7e8807 commit 1100249acef2cfa42c46deb9279bbd864d7e8807 Author: msarda <msarda@chromium.org> Date: Mon Feb 13 22:10:12 2017 Avoid multiple displays of the sign-in dialogs. This CL avoids diaplying the sync and the sign-in error dialogs if they were already displayed. BUG= 685062 Review-Url: https://codereview.chromium.org/2685163003 Cr-Commit-Position: refs/heads/master@{#450112} [modify] https://crrev.com/1100249acef2cfa42c46deb9279bbd864d7e8807/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h [modify] https://crrev.com/1100249acef2cfa42c46deb9279bbd864d7e8807/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.mm [modify] https://crrev.com/1100249acef2cfa42c46deb9279bbd864d7e8807/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc [modify] https://crrev.com/1100249acef2cfa42c46deb9279bbd864d7e8807/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h
,
Feb 14 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by rbasuvula@chromium.org
, Jan 25 2017Labels: hasbisect-per-revision
Owner: msarda@chromium.org
Status: Assigned (was: Unconfirmed)