"org.chromium.content.browser.ChildProcessLauncherTest#testBindServiceFromMultipleProcesses" is flaky |
|||
Issue description"org.chromium.content.browser.ChildProcessLauncherTest#testBindServiceFromMultipleProcesses" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 10 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyZQsSBUZsYWtlIlpvcmcuY2hyb21pdW0uY29udGVudC5icm93c2VyLkNoaWxkUHJvY2Vzc0xhdW5jaGVyVGVzdCN0ZXN0QmluZFNlcnZpY2VGcm9tTXVsdGlwbGVQcm9jZXNzZXMM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Jan 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e926b67a55af0b521951664cb67b95947a10eab commit 7e926b67a55af0b521951664cb67b95947a10eab Author: rsesek <rsesek@chromium.org> Date: Wed Jan 25 18:54:59 2017 Address follow-up comments from https://codereview.chromium.org/2626413004/. This also de-flakes the testBindServiceFromMultipleProcesses test. BUG=683133, 685052 R=boliu@chromium.org Review-Url: https://codereview.chromium.org/2652293002 Cr-Commit-Position: refs/heads/master@{#446069} [modify] https://crrev.com/7e926b67a55af0b521951664cb67b95947a10eab/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java [modify] https://crrev.com/7e926b67a55af0b521951664cb67b95947a10eab/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
,
Jan 26 2017
Detected 29 new flakes for test/step "org.chromium.content.browser.ChildProcessLauncherTest#testBindServiceFromMultipleProcesses". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyZQsSBUZsYWtlIlpvcmcuY2hyb21pdW0uY29udGVudC5icm93c2VyLkNoaWxkUHJvY2Vzc0xhdW5jaGVyVGVzdCN0ZXN0QmluZFNlcnZpY2VGcm9tTXVsdGlwbGVQcm9jZXNzZXMM. This message was posted automatically by the chromium-try-flakes app.
,
Jan 26 2017
Removing label to make this disappear from the sheriff-o-matic dashboard.
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a79d8da197d36b7b28ce24da4e694a12c787183 commit 4a79d8da197d36b7b28ce24da4e694a12c787183 Author: rsesek <rsesek@chromium.org> Date: Thu Jan 26 21:22:33 2017 Really de-flake ChildProcessLauncherTest#testBindServiceFromMultipleProcesses. The previous attempt was a bad band-aid around this underlying issue: there are multiple paths to enter ChildProcessConnectionImpl.doSetupConnection(). Failing to bindToCaller() was only preventing one of those paths in onServiceConnected(). The connection now tracks this and does not call setupConnection() if bindToCaller() failed. BUG=683133, 685052 R=boliu@chromium.org Review-Url: https://codereview.chromium.org/2655463012 Cr-Commit-Position: refs/heads/master@{#446451} [modify] https://crrev.com/4a79d8da197d36b7b28ce24da4e694a12c787183/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java [modify] https://crrev.com/4a79d8da197d36b7b28ce24da4e694a12c787183/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java [modify] https://crrev.com/4a79d8da197d36b7b28ce24da4e694a12c787183/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
,
Jan 30 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by boliu@chromium.org
, Jan 25 2017Status: Assigned (was: Untriaged)