New issue
Advanced search Search tips

Issue 685050 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

STANDARD_STORE == store_mode in js-native-context-specialization.cc

Project Member Reported by ClusterFuzz, Jan 25 2017

Issue description

Cc: jarin@chromium.org
Components: -Blink>JavaScript Blink>JavaScript>Compiler
Owner: bmeu...@chromium.org
Status: Assigned (was: Untriaged)
The {STORE_NO_TRANSITION_HANDLE_COW} case is unhandled when lowering element stores. Simplified repro ...

// Copyright 2017 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// Flags: --allow-natives-syntax

function f(a) {
  a[0] = 0;
  a[1] = 0;
}

var a = new Int32Array(2);
for (var i = 0; i < 5; i++) {
  if (i == 2) %OptimizeOsr();
  f([1, 2, 3]);
}
f(a);

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/64eae6eff294670c4503d9a95fbe164e34edcdf1

commit 64eae6eff294670c4503d9a95fbe164e34edcdf1
Author: bmeurer <bmeurer@chromium.org>
Date: Tue Jan 31 09:00:55 2017

[turbofan] Remove over-restrictive DCHECKs.

The KeyedStoreMode that we get out of the FeedbackNexus doesn't
necessarily need to apply when we have "static knowledge" about
the receiver, i.e. when the receiver is a known JSTypedArray, but
the KEYED_STORE_IC has seen only JSArray instances so far. The
DCHECK was too restrictive in this case, since we can just ignore
the KEYED_STORE_IC mode (like we ignore the maps).

BUG= chromium:685050 
R=ishell@chromium.org

Review-Url: https://codereview.chromium.org/2668643002
Cr-Commit-Position: refs/heads/master@{#42810}

[modify] https://crrev.com/64eae6eff294670c4503d9a95fbe164e34edcdf1/src/compiler/js-native-context-specialization.cc
[add] https://crrev.com/64eae6eff294670c4503d9a95fbe164e34edcdf1/test/mjsunit/regress/regress-crbug-685050.js

Status: Fixed (was: Assigned)

Sign in to add a comment