New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685048 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 684498
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Data race in base::StatisticsRecorder::FindHistogram

Project Member Reported by ClusterFuzz, Jan 25 2017

Issue description

Cc: nyerramilli@chromium.org
Components: Blink>Scheduling
Labels: Test-Predator-Correct-CLs M-58
Owner: alexclarke@chromium.org
Status: Assigned (was: Untriaged)
providing Predator results,
The result is a list of CLs that change the crashed files. 

Author: alexclarke
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src/+/cdf5b1fbdbfed58d0a0450597d3666c5a2159c30
Time: Tue Jan 24 19:11:06 2017
File task_queue_manager.cc is changed in this cl (and is part of stack frame #5, "blink::scheduler::TaskQueueManager::MaybeRecordTaskDelayHistograms"; frame #6, "blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue"; frame #7, "blink::scheduler::TaskQueueManager::DoWork")
Minimum distance from crash line to modified line: 2. (file: task_queue_manager.cc, crashed on: 320, modified: 322).

assigning to alexclarke@, could you please check the issue and help.
Cc: alexclarke@chromium.org
Components: -Blink>Scheduling
Owner: bcwh...@chromium.org
https://codereview.chromium.org/2653643002 shouldn't change anything w.r.t the histogram.

Looking at the regression range, I'm wondering if https://codereview.chromium.org/2655673002 might be related?
I'd guess it's the enable-by-default.  That's not in the regression range but perhaps this one got delayed by the g_allocator find.

Being enabled means that TSAN is doing all its test cases with persistent histograms enabled and is thus finding these new races.  Going to be a busy week, I suspect...
Mergedinto: 684498
Status: Duplicate (was: Assigned)
Looks like accesses to g_allocator.  The fix for that went in 16 hours ago and the report shows the last git commit being 18 hours ago.

Sign in to add a comment