New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685047 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
NOT IN USE
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

isFirstAfterBreak(lineTopInFlowThread) || !line.paginationStrut() || !isLogicalT

Project Member Reported by ClusterFuzz, Jan 25 2017

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4648600882905088

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_debug_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  isFirstAfterBreak(lineTopInFlowThread) || !line.paginationStrut() || !isLogicalT
  blink::InitialColumnHeightFinder::examineLine
  blink::ColumnBalancer::traverseLines
  
Sanitizer: address (ASAN)

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_debug_content_shell_drt&range=361738:361835

Minimized Testcase (0.21 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv96HBu_XfTco2AywshsaCZx9Oj_CKBlXnFUPLtlQY7xs0gXwT308t3uZXaFPlhfL9BHu39XtJpgNlFBonoOShphhFJ1UxzZJihE7dLmEykaLX14FgYFbvdcYBMz0iKqvz_8o-_LZ1rfrMM-fdO6RqLXIatRMrhLX1eKfT7VM32AHnLgtP6XK9gMhx3ZHbi2vPFazJmkPkryjfxkQPU6VvzmPvMCviJMwfwWxNBm_YAlYJOgm2o6vJS_XZ7CoO8R2l9yo8EZTC41_ocuakDhT-jwBLqEzdEb7CWLUnSMfBsGO6LVQShXA3iRY4nNQMPYbyeglS04zHF0mI6BKtRNKolKAlrgDWhlRyw8NKmOIqfUMSSWKsy8?testcase_id=4648600882905088
<style>
div div {
	display: flex;
	flex-wrap: wrap;
	width: 200px;
</style>
  <div>
   <div>
     damer
    </p>
    <style>
   html, body { -webkit-column-count: 2000000000;</style>
   This test should not crash.


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Blink>Layout>MultiCol
Labels: Test-Predator-Wrong M-57
Owner: msten...@opera.com
Status: Assigned (was: Untriaged)
Causing any one of below CL's.
https://chromium.googlesource.com/chromium/src/+/5c2f73741d5087c50451a67089e26b071982acd1
https://chromium.googlesource.com/chromium/src/+/d19d51259c048132deb253a9d7441b40eceb55e9
mstensho@, could you please take a look?
Thank you.

Comment 2 by msten...@opera.com, Apr 6 2017

This is caused by bug 606350. Flex items are moved in the block direction after having been paginated.

Looks like all we can do for now is remove the assertion.

Attaching a test that both asserts (if assertions are enabled in your build) and also fails visually.
tc.html
573 bytes View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ab573d311cd7a4a72b86ee8d47a7b70b358432b

commit 0ab573d311cd7a4a72b86ee8d47a7b70b358432b
Author: mstensho <mstensho@opera.com>
Date: Thu Apr 06 13:17:20 2017

Remove DCHECK in column balancer that failed because of flexbox bugs.

This DCHECK was useful (detects broken layout, but nothing more dangerous than
that). However, as long as we don't paginate flex items at their final block
position (see bug 606350), we cannot assert like this, because it's going to
fail under certain circumstances.

BUG= 685047 

Review-Url: https://codereview.chromium.org/2797313003
Cr-Commit-Position: refs/heads/master@{#462447}

[add] https://crrev.com/0ab573d311cd7a4a72b86ee8d47a7b70b358432b/third_party/WebKit/LayoutTests/fast/multicol/nested-with-wrapped-flexbox-crash.html
[modify] https://crrev.com/0ab573d311cd7a4a72b86ee8d47a7b70b358432b/third_party/WebKit/Source/core/layout/ColumnBalancer.cpp

Comment 4 by msten...@opera.com, Apr 6 2017

Status: Fixed (was: Assigned)
The test attached previously still doesn't pass visually, of course (but the assertion failure is gone). In order to make it render correctly, we need to fix bug 606350.
Project Member

Comment 5 by ClusterFuzz, Apr 7 2017

ClusterFuzz has detected this issue as fixed in range 462366:462558.

Detailed report: https://clusterfuzz.com/testcase?key=4648600882905088

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_debug_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  isFirstAfterBreak(lineTopInFlowThread) || !line.paginationStrut() || !isLogicalT
  blink::InitialColumnHeightFinder::examineLine
  blink::ColumnBalancer::traverseLines
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_content_shell_drt&range=361738:361835
Fixed: https://clusterfuzz.com/revisions?job=linux_debug_content_shell_drt&range=462366:462558

Reproducer Testcase: https://clusterfuzz.com/download/AMIfv96j4F627Ld0oap2V6EUrGHO6IO0wgR8fwIHQIbjvqiEadqryEaxNMrRnMoLxnS3w72CJLIQOW3z-zEb9cAaSf8kjHMUjX79Y0B2SDGTo4el5PJA-Rmh0EoIRyqmbec9sKI4gKuplPevpZhYLUXHJOhYe1i_CKYuvJm_HbTIxDSqhI7zZXVohJTRasiYvEcR864an8GTOH9ZhmAMUkwKNhe9vdLWy6sBWEnfMnwlYU7qpGMi0_kHFghGbfyCbxwgO5uA04_BHfH1JyYE2Lx3yPzxXs1cPWkX4DNkFIDPNpYAQzKcu4RviVoIjM7-gAAnojXSNotlP_O0UWRidBynYmDMO7409ReBCIIftfiRfWZH_f5U9xNo0eYm-tF40xUzrPhMhUKtSIlXNadPOaOmu5yjubmLuA?testcase_id=4648600882905088


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment