New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685027 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:Exception added under 'clear on exit' for incognito session remains and options of list doesn't work.

Reported by vku...@etouch.net, Jan 25 2017

Issue description

Chrome Version: 58.0.2992.0 (Official Build) Revision 25ff90033184e53f7fd47b44511397da29a1ce27-refs/heads/master@{#445908} (32/64-bit)
OS: Windows(7,8,10),Mac(10.12.1, 10.11.6, 10.12)

What steps will reproduce 
the problem?
(1)Launch chrome,click on wrench > new incognito window
(2)Navigate to chrome://md-settings/content/flash,click on 'add' button under clear on exit section.
(3)Enter any url for e.g https://www.google.co.in and save Close the incognito window and observe.
(4)Click on iron icon and remove, observe.

Actual: 
1.Exception added under clear on exit for incognito window remains even if incognito window is closed
2.Options like allow, block and remove in list doesn't work after clicking on iron icon.

Expected: Exception added under clear on exit for incognito window should disappear once incognito window is closed

This is a regression issue broken in 'M57' and below is the manual regression range
Good Build: 58.0.2991.0
Bad Build:  58.0.2992.0
 
Actual_Incognito.mp4
706 KB View Download

Comment 1 Deleted

Comment 2 by vku...@etouch.net, Jan 25 2017

Labels: -M-58 M-56 OS-Linux
Summary: Regression:Exception added under 'clear on exit' for incognito session remains and options of list doesn't work. (was: Regression:Exception added under 'clear on exit' for incognito window remains even if incognito window is closed.)
Correction:
Step 2:Navigate to chrome://md-settings/content/cookies,click on 'add' button under clear on exit section.

This is a regression issue broken in 'M56' and below is the manual regression range:
Good Build: 56.0.2915.0
Bad Build:  56.0.2916.0

Comment 3 by tapted@chromium.org, Jan 25 2017

Labels: Proj-MaterialDesign-WebUI
Owner: dbeam@chromium.org
[mac triage] -> dbeam for triage

Comment 4 by vku...@etouch.net, Jan 25 2017

Cc: dschuyler@chromium.org
Labels: hasbisect
Status: Assigned (was: Unconfirmed)
Narrow bisect
https://chromium.googlesource.com/chromium/src/+log/ad8a4ece43e32abb8bccacd89e382ae17afad8c2..0643d7f805b69c2fd595540791dc6a62ca195254?pretty=fuller&n=50

Suspecting: 431449 ?
Components: Privacy

Comment 6 by dbeam@chromium.org, Feb 6 2017

Cc: -dschuyler@chromium.org dbeam@chromium.org dpa...@chromium.org
Labels: -M-56 Hotlist-MD-Settings-Privacy-SiteSettings
Owner: dschuyler@chromium.org
dschuyler@/dpapad@: any ideas on what's going on here?  this does seem kind of unexpected, but I also don't generally understand the incognito content settings stuff that well
This is very related to  issue 680619 . When an incognito window is open, the exceptions list needs to be updated with any exceptions that only refer to incognito, and vice versa, when an incognito window is closed, those exceptions should be removed from the list. Well, at least this is how the old Options seems to handle Incognito-only exceptions.
Status: Started (was: Assigned)
I think comment #7 is on the money. I've been able to reproduce this issue, but it seems intermittent (so maybe there's a race condition somewhere). I'll look into it further, just making a quick update here.
Status: Assigned (was: Started)
Since this is not blocking crbug 671375, I'm un-starting this. To be resumed some other day.
Status: Started (was: Assigned)
The issue in #8 was fixed earlier, I believe.

What is left is that parts of the code omit session only from incognito session only options. Either this bug is that a user can set the incognito session only checkbox for a session only exception (and the fix is to remove that checkbox in that case); or the bug is that session only exceptions are not allowed for incognito.

There seems to be clear intent to prevent session only incognito session exceptions, so I'll go that way. Let me know if it should go the other way.
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfa9a8f45b3152616eabe23803befcb0673317f6

commit dfa9a8f45b3152616eabe23803befcb0673317f6
Author: dschuyler <dschuyler@chromium.org>
Date: Fri Apr 14 00:54:12 2017

[MD settings] hide option for incognito on session only exceptions

This CL removes the checkbox for 'incognito session only' from the add
site exception dialog for 'session only' exceptions.

BUG= 685027 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2817103002
Cr-Commit-Position: refs/heads/master@{#464634}

[modify] https://crrev.com/dfa9a8f45b3152616eabe23803befcb0673317f6/chrome/browser/resources/settings/site_settings/add_site_dialog.html
[modify] https://crrev.com/dfa9a8f45b3152616eabe23803befcb0673317f6/chrome/browser/resources/settings/site_settings/add_site_dialog.js
[modify] https://crrev.com/dfa9a8f45b3152616eabe23803befcb0673317f6/chrome/browser/resources/settings/site_settings/site_list.js

Status: Fixed (was: Started)

Sign in to add a comment