New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685018 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: 58-Dev , 58-Beta , 58-Stable
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----



Sign in to add a comment

Launch HTMLMediaElement.controlsList

Project Member Reported by mlamouri@chromium.org, Jan 25 2017

Issue description

Change description:
Allow website to customize the buttons available in the native controls.

Changes to API surface:
* add controlsList property as a DOMTokenList
* allow controlsList HTML attribute to take various tokens

Links: https://docs.google.com/document/d/1dVPuL8UznIyhYn1KCnaMT7GRJFvDerSgqaUQhSiiY3Y/edit#heading=h.lqqvomsdg9jx
Public standards discussion: https://github.com/whatwg/html/issues/2293

Support in other browsers:
Internet Explorer: No
Firefox: No
Safari: No
 
Description: Show this description
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caca06866f37c79df89cab9a634bb7497177236e

commit caca06866f37c79df89cab9a634bb7497177236e
Author: avayvod <avayvod@chromium.org>
Date: Fri Mar 10 00:39:55 2017

[Blink, Media] Added controlsList to HTMLMediaElement

Adds a DOMTokenList backed controlsList/controlslist attribute to HTMLMediaElement with three keywords: nodownload, nofullscreen and noremoteplayback.

Spec change is discussed here: https://github.com/whatwg/html/issues/2293
Spec change PR is here: https://github.com/whatwg/html/pull/2426
WICG repo for the API is here: https://github.com/WICG/controls-list
Intent to ship is here: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tFuQd3AcsIQ/discussion

BUG= 650174 , 685018 
TEST=manual+layout tests

Review-Url: https://codereview.chromium.org/2657723002
Cr-Commit-Position: refs/heads/master@{#455926}

[add] https://crrev.com/caca06866f37c79df89cab9a634bb7497177236e/third_party/WebKit/LayoutTests/http/tests/media/controls/controls-list-add-hide.html
[add] https://crrev.com/caca06866f37c79df89cab9a634bb7497177236e/third_party/WebKit/LayoutTests/http/tests/media/controls/controls-list-remove-show.html
[modify] https://crrev.com/caca06866f37c79df89cab9a634bb7497177236e/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/caca06866f37c79df89cab9a634bb7497177236e/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/caca06866f37c79df89cab9a634bb7497177236e/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/caca06866f37c79df89cab9a634bb7497177236e/third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/caca06866f37c79df89cab9a634bb7497177236e/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/caca06866f37c79df89cab9a634bb7497177236e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/caca06866f37c79df89cab9a634bb7497177236e/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/caca06866f37c79df89cab9a634bb7497177236e/third_party/WebKit/Source/core/html/BUILD.gn
[modify] https://crrev.com/caca06866f37c79df89cab9a634bb7497177236e/third_party/WebKit/Source/core/html/HTMLAttributeNames.json5
[modify] https://crrev.com/caca06866f37c79df89cab9a634bb7497177236e/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/caca06866f37c79df89cab9a634bb7497177236e/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/caca06866f37c79df89cab9a634bb7497177236e/third_party/WebKit/Source/core/html/HTMLMediaElement.idl
[add] https://crrev.com/caca06866f37c79df89cab9a634bb7497177236e/third_party/WebKit/Source/core/html/HTMLMediaElementControlsList.cpp
[add] https://crrev.com/caca06866f37c79df89cab9a634bb7497177236e/third_party/WebKit/Source/core/html/HTMLMediaElementControlsList.h
[modify] https://crrev.com/caca06866f37c79df89cab9a634bb7497177236e/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/caca06866f37c79df89cab9a634bb7497177236e/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
[modify] https://crrev.com/caca06866f37c79df89cab9a634bb7497177236e/third_party/WebKit/Source/core/html/shadow/MediaControls.h
[modify] https://crrev.com/caca06866f37c79df89cab9a634bb7497177236e/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 11 2017

Labels: merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f92e23e416a507c94523e120d1d4608b4ef087f

commit 1f92e23e416a507c94523e120d1d4608b4ef087f
Author: Anton Vayvod <avayvod@google.com>
Date: Sat Mar 11 14:26:56 2017

[Blink, Media] Added controlsList to HTMLMediaElement

Adds a DOMTokenList backed controlsList/controlslist attribute to HTMLMediaElement with three keywords: nodownload, nofullscreen and noremoteplayback.

Spec change is discussed here: https://github.com/whatwg/html/issues/2293
Spec change PR is here: https://github.com/whatwg/html/pull/2426
WICG repo for the API is here: https://github.com/WICG/controls-list
Intent to ship is here: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tFuQd3AcsIQ/discussion

BUG= 650174 , 685018 
TEST=manual+layout tests

Review-Url: https://codereview.chromium.org/2657723002
Cr-Commit-Position: refs/heads/master@{#455926}
(cherry picked from commit caca06866f37c79df89cab9a634bb7497177236e)

Review-Url: https://codereview.chromium.org/2741933004 .
Cr-Commit-Position: refs/branch-heads/3029@{#132}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[add] https://crrev.com/1f92e23e416a507c94523e120d1d4608b4ef087f/third_party/WebKit/LayoutTests/http/tests/media/controls/controls-list-add-hide.html
[add] https://crrev.com/1f92e23e416a507c94523e120d1d4608b4ef087f/third_party/WebKit/LayoutTests/http/tests/media/controls/controls-list-remove-show.html
[modify] https://crrev.com/1f92e23e416a507c94523e120d1d4608b4ef087f/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/1f92e23e416a507c94523e120d1d4608b4ef087f/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/1f92e23e416a507c94523e120d1d4608b4ef087f/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/1f92e23e416a507c94523e120d1d4608b4ef087f/third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/1f92e23e416a507c94523e120d1d4608b4ef087f/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/1f92e23e416a507c94523e120d1d4608b4ef087f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/1f92e23e416a507c94523e120d1d4608b4ef087f/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/1f92e23e416a507c94523e120d1d4608b4ef087f/third_party/WebKit/Source/core/html/BUILD.gn
[modify] https://crrev.com/1f92e23e416a507c94523e120d1d4608b4ef087f/third_party/WebKit/Source/core/html/HTMLAttributeNames.json5
[modify] https://crrev.com/1f92e23e416a507c94523e120d1d4608b4ef087f/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/1f92e23e416a507c94523e120d1d4608b4ef087f/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/1f92e23e416a507c94523e120d1d4608b4ef087f/third_party/WebKit/Source/core/html/HTMLMediaElement.idl
[add] https://crrev.com/1f92e23e416a507c94523e120d1d4608b4ef087f/third_party/WebKit/Source/core/html/HTMLMediaElementControlsList.cpp
[add] https://crrev.com/1f92e23e416a507c94523e120d1d4608b4ef087f/third_party/WebKit/Source/core/html/HTMLMediaElementControlsList.h
[modify] https://crrev.com/1f92e23e416a507c94523e120d1d4608b4ef087f/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
[modify] https://crrev.com/1f92e23e416a507c94523e120d1d4608b4ef087f/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
[modify] https://crrev.com/1f92e23e416a507c94523e120d1d4608b4ef087f/third_party/WebKit/Source/core/html/shadow/MediaControls.h
[modify] https://crrev.com/1f92e23e416a507c94523e120d1d4608b4ef087f/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Comment 6 by ananthak@google.com, May 24 2017

Components: Blink>Media>Controls

Sign in to add a comment