New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685000 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

factory: A new UI library

Project Member Reported by hungte@chromium.org, Jan 25 2017

Issue description

As continue to  issue 670277 .

During development of touch UI, it seems like that current UI library was designed with too much flexibility that people need to understand whole dependency to make touch UI work.

I think we should consider a new library that is:
 - Less API dependency, for example no need to setting templates before BindKey was called, or won't have problem if people set template to other forms again.
 - Supporting touch by default
 - Easier to use, for example won't need to worry about once=True or not for BindKey calls.
 - Even better if the UI library accepts setting input source and output source, for example output=keyboard_led

 

Comment 1 by hungte@chromium.org, Jan 25 2017

... and should help most tests to prevent setting CSS and HTML everywhere.
Would be very great if the test can describe UI in an abstracted way.

Comment 2 by hungte@chromium.org, Jul 26 2017

Cc: -shunhsingou@chromium.org chromeos-factory-eng@google.com
Labels: OS-Chrome
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/f72dadbb1c0e2f3545ccd1acb66a1d0ff25b98db

commit f72dadbb1c0e2f3545ccd1acb66a1d0ff25b98db
Author: Peter Shih <pihsun@chromium.org>
Date: Tue Oct 31 13:04:47 2017

test_ui: Add WaitKeysOnce.

Add WaitKeysOnce that can be used in background thread to wait for some
keys to be pressed. This can simplify many custom key handlers in
pytests.

BUG=b:68681772, chromium:685000 
TEST=make test

Change-Id: If15d61b0fce96c96a94641e23600dd06b74a8ed4
Reviewed-on: https://chromium-review.googlesource.com/746490
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/f72dadbb1c0e2f3545ccd1acb66a1d0ff25b98db/py/test/test_ui.py

Status: Fixed (was: Assigned)
pihsun has made a new revised version.

Sign in to add a comment