New issue
Advanced search Search tips

Issue 684986 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Use the manifest start URL to query the existence of a WebAPK

Project Member Reported by dominickn@chromium.org, Jan 25 2017

Issue description

We should always use the start URL when calling ShortcutHelper.QueryWebApkPackage()
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d09ddc4ab402628be6dad227726cf78dc486a55

commit 5d09ddc4ab402628be6dad227726cf78dc486a55
Author: dominickn <dominickn@chromium.org>
Date: Wed Jan 25 03:54:26 2017

Use the manifest start URL to query the existence of a WebAPK

This corrects an oversight where the last committed URL was used instead
of the manifest start URL when checking whether a WebAPK was already
installed.

BUG= 684986 

Review-Url: https://codereview.chromium.org/2652903005
Cr-Commit-Position: refs/heads/master@{#445937}

[modify] https://crrev.com/5d09ddc4ab402628be6dad227726cf78dc486a55/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

Labels: Merge-Request-57
Requesting merge of #1 (very small WebAPK fix) to M57.
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 30 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Started)
I think this has been merged.
Project Member

Comment 5 by sheriffbot@chromium.org, Feb 3 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -Merge-Approved-57 Merge-Merged

Sign in to add a comment