New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 684966 link

Starred by 6 users
Status: Fixed
Owner: ----
Closed: Dec 13
Cc:
danakj@chromium.org
█ meade@chromium.org
█ nainar@chromium.org
dcheng@chromium.org
shend@chromium.org
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 628043


Show other hotlists

Hotlists containing this issue:
style-dev-current


Sign in to add a comment

Change ComputedStyle enums to enum classes and rename enumerators

Project Member Reported by shend@chromium.org, Jan 25 2017 
Currently enums in ComputedStyle are plain enums. We would like to convert them into enum classes with unsigned underlying types for better type safety. We also want to rename the enumerator values by adding the prefix 'k' to match the Chromium style guide. This is pre-work for generating the enums, since we need to get the enums in the right format before replacing them with the generated versions.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a47e08858ad7ede6ea59d80dd87ff94fb7ffab4

commit 4a47e08858ad7ede6ea59d80dd87ff94fb7ffab4
Author: shend <shend@chromium.org>
Date: Sat Jan 28 08:19:27 2017

Rename EOverflowAnchor values with k prefix.

Rename the values of the EOverflowAnchor enum with the k prefix to match
the style generated by make_computed_style_base.py, which is in line with
the Blink rename to match Chromium style. This is prework for generating
EOverflowAnchor.

BUG= 684966 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2658953004
Cr-Commit-Position: refs/heads/master@{#446916}

[modify] https://crrev.com/4a47e08858ad7ede6ea59d80dd87ff94fb7ffab4/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/4a47e08858ad7ede6ea59d80dd87ff94fb7ffab4/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/4a47e08858ad7ede6ea59d80dd87ff94fb7ffab4/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/4a47e08858ad7ede6ea59d80dd87ff94fb7ffab4/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp
[modify] https://crrev.com/4a47e08858ad7ede6ea59d80dd87ff94fb7ffab4/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/4a47e08858ad7ede6ea59d80dd87ff94fb7ffab4/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/4a47e08858ad7ede6ea59d80dd87ff94fb7ffab4/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/581521281404da94a7c8a6281d34c7ac65fa1d9d

commit 581521281404da94a7c8a6281d34c7ac65fa1d9d
Author: shend <shend@chromium.org>
Date: Tue Jan 31 00:11:53 2017

Changed ETableLayout to an enum class and renamed its members

Changed ETableLayout to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow ETableLayout to be used by generated
fields in ComputedStyleBase.

BUG= 684966 

Review-Url: https://codereview.chromium.org/2666483002
Cr-Commit-Position: refs/heads/master@{#447121}

[modify] https://crrev.com/581521281404da94a7c8a6281d34c7ac65fa1d9d/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/581521281404da94a7c8a6281d34c7ac65fa1d9d/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/581521281404da94a7c8a6281d34c7ac65fa1d9d/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5bebbb612832e8d1feee0f0cf972f41283496e0

commit c5bebbb612832e8d1feee0f0cf972f41283496e0
Author: shend <shend@chromium.org>
Date: Tue Jan 31 06:15:39 2017

Changed EClear to an enum class and renamed its members

Changed EClear to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow EClear to be used by generated
fields in ComputedStyleBase.

BUG= 684966 

Review-Url: https://codereview.chromium.org/2653123002
Cr-Commit-Position: refs/heads/master@{#447197}

[modify] https://crrev.com/c5bebbb612832e8d1feee0f0cf972f41283496e0/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/c5bebbb612832e8d1feee0f0cf972f41283496e0/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/c5bebbb612832e8d1feee0f0cf972f41283496e0/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/c5bebbb612832e8d1feee0f0cf972f41283496e0/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h
[modify] https://crrev.com/c5bebbb612832e8d1feee0f0cf972f41283496e0/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp
[modify] https://crrev.com/c5bebbb612832e8d1feee0f0cf972f41283496e0/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
[modify] https://crrev.com/c5bebbb612832e8d1feee0f0cf972f41283496e0/third_party/WebKit/Source/core/layout/line/LineBreaker.cpp
[modify] https://crrev.com/c5bebbb612832e8d1feee0f0cf972f41283496e0/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
[modify] https://crrev.com/c5bebbb612832e8d1feee0f0cf972f41283496e0/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc
[modify] https://crrev.com/c5bebbb612832e8d1feee0f0cf972f41283496e0/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/c5bebbb612832e8d1feee0f0cf972f41283496e0/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb83e4dea76b261e101277f39a0703a0e5ae98d7

commit bb83e4dea76b261e101277f39a0703a0e5ae98d7
Author: shend <shend@chromium.org>
Date: Thu Feb 02 06:39:27 2017

Rename EOverflow values with k prefix.

Rename the values of the EOverflow enum with the k prefix to match
the style generated by make_computed_style_base.py, which is in line with
the Blink rename to match Chromium style. This also prefixes PagedX and
PagedY with Webkit since they are webkit specific keywords. This is
prework for generating EOverflow.

BUG= 684966 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2660423004
Cr-Commit-Position: refs/heads/master@{#447711}

[modify] https://crrev.com/bb83e4dea76b261e101277f39a0703a0e5ae98d7/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/bb83e4dea76b261e101277f39a0703a0e5ae98d7/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
[modify] https://crrev.com/bb83e4dea76b261e101277f39a0703a0e5ae98d7/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/bb83e4dea76b261e101277f39a0703a0e5ae98d7/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/bb83e4dea76b261e101277f39a0703a0e5ae98d7/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/bb83e4dea76b261e101277f39a0703a0e5ae98d7/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/bb83e4dea76b261e101277f39a0703a0e5ae98d7/third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp
[modify] https://crrev.com/bb83e4dea76b261e101277f39a0703a0e5ae98d7/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/bb83e4dea76b261e101277f39a0703a0e5ae98d7/third_party/WebKit/Source/core/layout/LayoutBox.h
[modify] https://crrev.com/bb83e4dea76b261e101277f39a0703a0e5ae98d7/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp
[modify] https://crrev.com/bb83e4dea76b261e101277f39a0703a0e5ae98d7/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
[modify] https://crrev.com/bb83e4dea76b261e101277f39a0703a0e5ae98d7/third_party/WebKit/Source/core/layout/LayoutTextControl.cpp
[modify] https://crrev.com/bb83e4dea76b261e101277f39a0703a0e5ae98d7/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp
[modify] https://crrev.com/bb83e4dea76b261e101277f39a0703a0e5ae98d7/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/bb83e4dea76b261e101277f39a0703a0e5ae98d7/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
[modify] https://crrev.com/bb83e4dea76b261e101277f39a0703a0e5ae98d7/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp
[modify] https://crrev.com/bb83e4dea76b261e101277f39a0703a0e5ae98d7/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp
[modify] https://crrev.com/bb83e4dea76b261e101277f39a0703a0e5ae98d7/third_party/WebKit/Source/core/page/SpatialNavigation.cpp
[modify] https://crrev.com/bb83e4dea76b261e101277f39a0703a0e5ae98d7/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/bb83e4dea76b261e101277f39a0703a0e5ae98d7/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/bb83e4dea76b261e101277f39a0703a0e5ae98d7/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/bb83e4dea76b261e101277f39a0703a0e5ae98d7/third_party/WebKit/Source/core/style/ComputedStyleTest.cpp

Comment 5 by ericwilligers@chromium.org, Feb 12 2017

Labels: Update-Monthly
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30aef3be9b857563cfab70278e011dba9d1e8a14

commit 30aef3be9b857563cfab70278e011dba9d1e8a14
Author: shend <shend@chromium.org>
Date: Tue Feb 14 02:20:08 2017

Changed EPosition to an enum class and renamed its members

Changed EPosition to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow EPosition to be used by generated
fields in ComputedStyleBase.

BUG= 684966 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2667493002
Cr-Commit-Position: refs/heads/master@{#450202}

[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/layout/LayoutInline.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/layout/LayoutState.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/30aef3be9b857563cfab70278e011dba9d1e8a14/third_party/WebKit/Source/web/FindInPageCoordinates.cpp

Comment 7 Deleted

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be8002aa2f99d13a07546f12018d4add0b7e1be8

commit be8002aa2f99d13a07546f12018d4add0b7e1be8
Author: shend <shend@chromium.org>
Date: Thu Mar 16 05:19:37 2017

Rename EDisplay values with k prefix.

Rename the values of the EDisplay enum with the k prefix to match
the style generated by make_computed_style_base.py, which is in line with
the Blink rename to match Chromium style. This is prework for generating
EDisplay.

BUG= 684966 

Review-Url: https://codereview.chromium.org/2670643004
Cr-Commit-Position: refs/heads/master@{#457356}

[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/dom/PseudoElement.h
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/dom/Text.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/html/HTMLRTElement.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/html/HTMLRubyElement.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/html/HTMLSummaryElement.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/html/shadow/TextControlInnerElements.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutBlock.h
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutInline.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutPagedFlowThread.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutTableCol.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutTableCol.h
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutTextControlMultiLine.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutTextTrackContainer.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/LayoutTheme.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/core/svg/SVGGElement.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/be8002aa2f99d13a07546f12018d4add0b7e1be8/third_party/WebKit/Source/web/PopupMenuImpl.cpp

Comment 9 by shend@chromium.org, Apr 5 2017

Status: Started (was: Assigned)

Comment 10 by shend@chromium.org, Apr 13 2017

Labels: Hotlist-CodeHealth

Comment 11 by sashab@chromium.org, Apr 18 2017

Cc: -sashab@chromium.org
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0bef062337921727eb9b670b417ebd0b6d86fd6

commit e0bef062337921727eb9b670b417ebd0b6d86fd6
Author: shend <shend@chromium.org>
Date: Fri Apr 28 04:06:39 2017

Make EBoxDecorationBreak an enum class.

This patch makes EBoxDecoration break an enum class for better type
safety.

BUG= 684966 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2845893002
Cr-Commit-Position: refs/heads/master@{#467885}

[modify] https://crrev.com/e0bef062337921727eb9b670b417ebd0b6d86fd6/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/e0bef062337921727eb9b670b417ebd0b6d86fd6/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/e0bef062337921727eb9b670b417ebd0b6d86fd6/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
[modify] https://crrev.com/e0bef062337921727eb9b670b417ebd0b6d86fd6/third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp
[modify] https://crrev.com/e0bef062337921727eb9b670b417ebd0b6d86fd6/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/e0bef062337921727eb9b670b417ebd0b6d86fd6/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/e0bef062337921727eb9b670b417ebd0b6d86fd6/third_party/WebKit/Source/core/style/StyleBoxData.cpp
Project Member

Comment 13 by bugdroid1@chromium.org, May 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dc275c518d70c4fb4652fdfb5b908d060b53296

commit 9dc275c518d70c4fb4652fdfb5b908d060b53296
Author: shend <shend@chromium.org>
Date: Fri May 12 04:24:05 2017

Make TextDecoration an enum class.

This patch makes TextDecoration an enum class for better type safety.
However, TextDecoration is a bit flag, so it is often used with bitwise
operators. Enum classes do not have bitwise operators by default, so we
define our own explicitly as needed.

Furthermore, a lot of code involves testing if a bit is set/active in a
TextDecoration. Previously, we could do something like:

if (text_decoration & TextDecoration::kUnderline)

to check if underline is applied. This worked because TextDecoration
could be implicitly converted to a bool. However, enum classes cannot.
With an enum class, it is more verbose and unintuitive:

if ((text_decoration & TextDecoration::kUnderline) !=
    TextDecoration::kNone)

Hence, we also provide a helper function called EnumHasFlags that
performs this check:

if (EnumHasFlags(text_decoration, TextDecoration::kUnderline))

BUG= 684966 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2845773002
Cr-Commit-Position: refs/heads/master@{#471219}

[modify] https://crrev.com/9dc275c518d70c4fb4652fdfb5b908d060b53296/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/9dc275c518d70c4fb4652fdfb5b908d060b53296/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/9dc275c518d70c4fb4652fdfb5b908d060b53296/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5
[modify] https://crrev.com/9dc275c518d70c4fb4652fdfb5b908d060b53296/third_party/WebKit/Source/core/layout/LayoutTextCombine.cpp
[modify] https://crrev.com/9dc275c518d70c4fb4652fdfb5b908d060b53296/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
[modify] https://crrev.com/9dc275c518d70c4fb4652fdfb5b908d060b53296/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/9dc275c518d70c4fb4652fdfb5b908d060b53296/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp
[modify] https://crrev.com/9dc275c518d70c4fb4652fdfb5b908d060b53296/third_party/WebKit/Source/core/paint/TextPainterBase.cpp
[modify] https://crrev.com/9dc275c518d70c4fb4652fdfb5b908d060b53296/third_party/WebKit/Source/core/style/AppliedTextDecoration.cpp
[modify] https://crrev.com/9dc275c518d70c4fb4652fdfb5b908d060b53296/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/9dc275c518d70c4fb4652fdfb5b908d060b53296/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/9dc275c518d70c4fb4652fdfb5b908d060b53296/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/9dc275c518d70c4fb4652fdfb5b908d060b53296/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
Project Member

Comment 14 by bugdroid1@chromium.org, May 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39f50e39f87993743d1253c33dc5fe67caa5da05

commit 39f50e39f87993743d1253c33dc5fe67caa5da05
Author: shend <shend@chromium.org>
Date: Fri May 12 06:53:48 2017

Make ETextSecurity an enum class.

This patch makes ETextSecurity an enum class for better type safety.

BUG= 684966 
TBR=aboxhall@chromium.org

Review-Url: https://codereview.chromium.org/2868783005
Cr-Commit-Position: refs/heads/master@{#471239}

[modify] https://crrev.com/39f50e39f87993743d1253c33dc5fe67caa5da05/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/39f50e39f87993743d1253c33dc5fe67caa5da05/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/39f50e39f87993743d1253c33dc5fe67caa5da05/third_party/WebKit/Source/core/layout/LayoutText.cpp
[modify] https://crrev.com/39f50e39f87993743d1253c33dc5fe67caa5da05/third_party/WebKit/Source/core/layout/LayoutText.h
[modify] https://crrev.com/39f50e39f87993743d1253c33dc5fe67caa5da05/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp
[modify] https://crrev.com/39f50e39f87993743d1253c33dc5fe67caa5da05/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/39f50e39f87993743d1253c33dc5fe67caa5da05/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/39f50e39f87993743d1253c33dc5fe67caa5da05/third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp
[modify] https://crrev.com/39f50e39f87993743d1253c33dc5fe67caa5da05/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
Project Member

Comment 16 by bugdroid1@chromium.org, May 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6c0fe91631379e1ce4f928d27e423ccf801a9f6

commit e6c0fe91631379e1ce4f928d27e423ccf801a9f6
Author: shend <shend@chromium.org>
Date: Mon May 15 06:20:28 2017

Make ETextModify an enum class.

This patch makes ETextModify an enum class for better type safety.

BUG= 684966 

Review-Url: https://codereview.chromium.org/2878333002
Cr-Commit-Position: refs/heads/master@{#471681}

[modify] https://crrev.com/e6c0fe91631379e1ce4f928d27e423ccf801a9f6/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/e6c0fe91631379e1ce4f928d27e423ccf801a9f6/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
[modify] https://crrev.com/e6c0fe91631379e1ce4f928d27e423ccf801a9f6/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/e6c0fe91631379e1ce4f928d27e423ccf801a9f6/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/e6c0fe91631379e1ce4f928d27e423ccf801a9f6/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp
[modify] https://crrev.com/e6c0fe91631379e1ce4f928d27e423ccf801a9f6/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
[modify] https://crrev.com/e6c0fe91631379e1ce4f928d27e423ccf801a9f6/third_party/WebKit/Source/core/html/forms/TextControlInnerElements.cpp
[modify] https://crrev.com/e6c0fe91631379e1ce4f928d27e423ccf801a9f6/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/e6c0fe91631379e1ce4f928d27e423ccf801a9f6/third_party/WebKit/Source/core/layout/LayoutTextControl.cpp
[modify] https://crrev.com/e6c0fe91631379e1ce4f928d27e423ccf801a9f6/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/e6c0fe91631379e1ce4f928d27e423ccf801a9f6/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/e6c0fe91631379e1ce4f928d27e423ccf801a9f6/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/e6c0fe91631379e1ce4f928d27e423ccf801a9f6/third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp
Project Member

Comment 18 by bugdroid1@chromium.org, May 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c68a7332c9f3558c810b0218c8b4853abc93c074

commit c68a7332c9f3558c810b0218c8b4853abc93c074
Author: nainar <nainar@chromium.org>
Date: Thu May 18 09:43:49 2017

Make EBorderStyle an enum class.

This patch makes EBorderStyle an enum class for better type safety.

BUG= 684966 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2890733002
Cr-Commit-Position: refs/heads/master@{#472754}

[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/layout/CollapsedBorderValue.h
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/layout/CollapsedBorderValueTest.cpp
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/layout/LayoutThemeTest.cpp
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/paint/BoxPainter.cpp
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/paint/ObjectPainter.cpp
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/paint/TableCellPainter.cpp
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/style/BorderEdge.cpp
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/style/BorderStyle.h
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/style/BorderValue.h
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/style/ComputedStyleTest.cpp
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/style/OutlineValue.h
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/style/OutlineValueTest.cpp
[modify] https://crrev.com/c68a7332c9f3558c810b0218c8b4853abc93c074/third_party/WebKit/Source/core/style/StyleMultiColData.h
Project Member

Comment 19 by bugdroid1@chromium.org, May 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/385931fbf1990470dde91e5f12c75db5680193c4

commit 385931fbf1990470dde91e5f12c75db5680193c4
Author: shend <shend@chromium.org>
Date: Thu May 18 23:45:20 2017

Make EUserSelect an enum class.

This patch makes EUserSelect an enum class for better type safety.

BUG= 684966 

Review-Url: https://codereview.chromium.org/2882093002
Cr-Commit-Position: refs/heads/master@{#472975}

[modify] https://crrev.com/385931fbf1990470dde91e5f12c75db5680193c4/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/385931fbf1990470dde91e5f12c75db5680193c4/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/385931fbf1990470dde91e5f12c75db5680193c4/third_party/WebKit/Source/core/editing/EditingStrategy.cpp
[modify] https://crrev.com/385931fbf1990470dde91e5f12c75db5680193c4/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
[modify] https://crrev.com/385931fbf1990470dde91e5f12c75db5680193c4/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
[modify] https://crrev.com/385931fbf1990470dde91e5f12c75db5680193c4/third_party/WebKit/Source/core/frame/SmartClip.cpp
[modify] https://crrev.com/385931fbf1990470dde91e5f12c75db5680193c4/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/385931fbf1990470dde91e5f12c75db5680193c4/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/385931fbf1990470dde91e5f12c75db5680193c4/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/385931fbf1990470dde91e5f12c75db5680193c4/third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp
Project Member

Comment 22 by bugdroid1@chromium.org, May 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7446a544808a998f3698178f1cf309f627592c70

commit 7446a544808a998f3698178f1cf309f627592c70
Author: shend <shend@chromium.org>
Date: Fri May 19 09:03:15 2017

Make EWordBreak an enum class.

This patch makes EWordBreak an enum class for better type safety.

BUG= 684966 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2877333002
Cr-Commit-Position: refs/heads/master@{#473133}

[modify] https://crrev.com/7446a544808a998f3698178f1cf309f627592c70/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/7446a544808a998f3698178f1cf309f627592c70/third_party/WebKit/Source/core/layout/LayoutText.cpp
[modify] https://crrev.com/7446a544808a998f3698178f1cf309f627592c70/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
[modify] https://crrev.com/7446a544808a998f3698178f1cf309f627592c70/third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc
[modify] https://crrev.com/7446a544808a998f3698178f1cf309f627592c70/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/7446a544808a998f3698178f1cf309f627592c70/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/7446a544808a998f3698178f1cf309f627592c70/third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp
Project Member

Comment 26 by bugdroid1@chromium.org, May 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78f5c551f8255dab868c0f32fb543748d9a0bfca

commit 78f5c551f8255dab868c0f32fb543748d9a0bfca
Author: shend <shend@chromium.org>
Date: Fri May 26 03:33:07 2017

Make TextEmphasisPosition an enum class.

This patch makes TextEmphasisPosition an enum class for better type
safety.

BUG= 684966 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2895883002
Cr-Commit-Position: refs/heads/master@{#474900}

[modify] https://crrev.com/78f5c551f8255dab868c0f32fb543748d9a0bfca/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/78f5c551f8255dab868c0f32fb543748d9a0bfca/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5
[modify] https://crrev.com/78f5c551f8255dab868c0f32fb543748d9a0bfca/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
[modify] https://crrev.com/78f5c551f8255dab868c0f32fb543748d9a0bfca/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp
[modify] https://crrev.com/78f5c551f8255dab868c0f32fb543748d9a0bfca/third_party/WebKit/Source/core/paint/TextPainterBase.cpp
[modify] https://crrev.com/78f5c551f8255dab868c0f32fb543748d9a0bfca/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/78f5c551f8255dab868c0f32fb543748d9a0bfca/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
Project Member

Comment 29 by bugdroid1@chromium.org, May 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35ced4857d1ca2fb853a7d170186e9173cba91b9

commit 35ced4857d1ca2fb853a7d170186e9173cba91b9
Author: shend <shend@chromium.org>
Date: Fri May 26 05:38:25 2017

Make EImageRendering an enum class.

This patch makes EImageRendering an enum class for better type safety.

BUG= 684966 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2899633002
Cr-Commit-Position: refs/heads/master@{#474926}

[modify] https://crrev.com/35ced4857d1ca2fb853a7d170186e9173cba91b9/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/35ced4857d1ca2fb853a7d170186e9173cba91b9/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/35ced4857d1ca2fb853a7d170186e9173cba91b9/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/35ced4857d1ca2fb853a7d170186e9173cba91b9/third_party/WebKit/Source/core/layout/ImageQualityController.cpp
[modify] https://crrev.com/35ced4857d1ca2fb853a7d170186e9173cba91b9/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/35ced4857d1ca2fb853a7d170186e9173cba91b9/third_party/WebKit/Source/core/layout/svg/SVGLayoutTreeAsText.cpp
[modify] https://crrev.com/35ced4857d1ca2fb853a7d170186e9173cba91b9/third_party/WebKit/Source/core/page/DragController.cpp
[modify] https://crrev.com/35ced4857d1ca2fb853a7d170186e9173cba91b9/third_party/WebKit/Source/core/paint/HTMLCanvasPainter.cpp
[modify] https://crrev.com/35ced4857d1ca2fb853a7d170186e9173cba91b9/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/35ced4857d1ca2fb853a7d170186e9173cba91b9/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
Project Member

Comment 30 by bugdroid1@chromium.org, May 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e96260c1487284932117eb66862f7b47efb61ef5

commit e96260c1487284932117eb66862f7b47efb61ef5
Author: shend <shend@chromium.org>
Date: Fri May 26 06:40:03 2017

Make TextEmphasisMark an enum class.

This patch makes TextEmphasisMark an enum class for better type safety.

BUG= 684966 

Review-Url: https://codereview.chromium.org/2900633003
Cr-Commit-Position: refs/heads/master@{#474944}

[modify] https://crrev.com/e96260c1487284932117eb66862f7b47efb61ef5/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/e96260c1487284932117eb66862f7b47efb61ef5/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/e96260c1487284932117eb66862f7b47efb61ef5/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5
[modify] https://crrev.com/e96260c1487284932117eb66862f7b47efb61ef5/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
[modify] https://crrev.com/e96260c1487284932117eb66862f7b47efb61ef5/third_party/WebKit/Source/core/layout/LayoutInline.cpp
[modify] https://crrev.com/e96260c1487284932117eb66862f7b47efb61ef5/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
[modify] https://crrev.com/e96260c1487284932117eb66862f7b47efb61ef5/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp
[modify] https://crrev.com/e96260c1487284932117eb66862f7b47efb61ef5/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/e96260c1487284932117eb66862f7b47efb61ef5/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/e96260c1487284932117eb66862f7b47efb61ef5/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
Project Member

Comment 33 by bugdroid1@chromium.org, May 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b5744eb7bae3f1d327084a487cb96f858ba4b1e

commit 1b5744eb7bae3f1d327084a487cb96f858ba4b1e
Author: shend <shend@chromium.org>
Date: Tue May 30 06:12:29 2017

Make TextIndentLine an enum class.

This patch makes TextIndentLine an enum class for type safety. The only
change to callers is where TextIndentLine::kEachLine was being used
as a synonym for 'true'. This has been removed with no changes in
behaviour.

BUG= 684966 

Review-Url: https://codereview.chromium.org/2904383002
Cr-Commit-Position: refs/heads/master@{#475438}

[modify] https://crrev.com/1b5744eb7bae3f1d327084a487cb96f858ba4b1e/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
[modify] https://crrev.com/1b5744eb7bae3f1d327084a487cb96f858ba4b1e/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
Project Member

Comment 38 by bugdroid1@chromium.org, Jun 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f456b3c428ad5d71d37612e10336560a81541b56

commit f456b3c428ad5d71d37612e10336560a81541b56
Author: Darren Shen <shend@chromium.org>
Date: Thu Jun 08 10:33:39 2017

Make TextJustify an enum class.

This patch changes platform/text/TextJustify to an enum class for
better type safety.

Bug:  684966 
Change-Id: Ic3b92f4e0b879217f942bb3658dff32f0c3c9c12
Reviewed-on: https://chromium-review.googlesource.com/527954
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477936}
[modify] https://crrev.com/f456b3c428ad5d71d37612e10336560a81541b56/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/f456b3c428ad5d71d37612e10336560a81541b56/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/f456b3c428ad5d71d37612e10336560a81541b56/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp
[modify] https://crrev.com/f456b3c428ad5d71d37612e10336560a81541b56/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/f456b3c428ad5d71d37612e10336560a81541b56/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultSpacing.cpp
[modify] https://crrev.com/f456b3c428ad5d71d37612e10336560a81541b56/third_party/WebKit/Source/platform/text/Character.cpp
[modify] https://crrev.com/f456b3c428ad5d71d37612e10336560a81541b56/third_party/WebKit/Source/platform/text/TextJustify.h
[modify] https://crrev.com/f456b3c428ad5d71d37612e10336560a81541b56/third_party/WebKit/Source/platform/text/TextRun.h
Project Member

Comment 41 by bugdroid1@chromium.org, Jun 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e3878d0623359c7105b2e2f4a7bfba4ab5d506c

commit 4e3878d0623359c7105b2e2f4a7bfba4ab5d506c
Author: Naina Raisinghani <nainar@chromium.org>
Date: Thu Jun 15 02:56:39 2017

Make ObjectFit an enum class and change name to EObjectFit.

This patch makes ObjectFit an enum class for type safety and changes the
name to EObjectFit to match the other enums

BUG= 684966 

Change-Id: I9dfca4307e9af93d60559c2f0bbb0bf6142f0d2f
Reviewed-on: https://chromium-review.googlesource.com/536373
Reviewed-by: Rune Lillesveen <rune@opera.com>
Commit-Queue: Naina Raisinghani <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479587}
[modify] https://crrev.com/4e3878d0623359c7105b2e2f4a7bfba4ab5d506c/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/4e3878d0623359c7105b2e2f4a7bfba4ab5d506c/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/4e3878d0623359c7105b2e2f4a7bfba4ab5d506c/third_party/WebKit/Source/core/layout/LayoutImage.cpp
[modify] https://crrev.com/4e3878d0623359c7105b2e2f4a7bfba4ab5d506c/third_party/WebKit/Source/core/layout/LayoutReplaced.cpp
[modify] https://crrev.com/4e3878d0623359c7105b2e2f4a7bfba4ab5d506c/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/4e3878d0623359c7105b2e2f4a7bfba4ab5d506c/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
Project Member

Comment 42 by bugdroid1@chromium.org, Jun 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0767f272785a630f3045b80c7ef82df267ec400

commit f0767f272785a630f3045b80c7ef82df267ec400
Author: Naina Raisinghani <nainar@chromium.org>
Date: Fri Jun 16 05:25:17 2017

Make ETransformStyle3D an enum class.

This patch makes ETransformStyle3D an enum class for type safety.

BUG= 684966 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2c3552983af7d6e82656cc8305d83edddc3e0b72
Reviewed-on: https://chromium-review.googlesource.com/536539
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479958}
[modify] https://crrev.com/f0767f272785a630f3045b80c7ef82df267ec400/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/f0767f272785a630f3045b80c7ef82df267ec400/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/f0767f272785a630f3045b80c7ef82df267ec400/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/f0767f272785a630f3045b80c7ef82df267ec400/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp
[modify] https://crrev.com/f0767f272785a630f3045b80c7ef82df267ec400/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/f0767f272785a630f3045b80c7ef82df267ec400/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/f0767f272785a630f3045b80c7ef82df267ec400/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/f0767f272785a630f3045b80c7ef82df267ec400/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/f0767f272785a630f3045b80c7ef82df267ec400/third_party/WebKit/Source/core/style/ComputedStyleTest.cpp
Project Member

Comment 44 by bugdroid1@chromium.org, Jun 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59daddb15eae24948399b4982b144fd70324d8b7

commit 59daddb15eae24948399b4982b144fd70324d8b7
Author: Darren Shen <shend@chromium.org>
Date: Fri Jun 16 08:57:39 2017

Make TextOverflow an enum class and change name to ETextOverflow.

This patch makes TextOverflow an enum class for type safety and changes
the name to ETextOverflow to match the other enums.

Bug:  684966 
Change-Id: Ia4a5f4f0dc6e966c5fed6e55d367ea63d0f8aa5d
Reviewed-on: https://chromium-review.googlesource.com/536097
Reviewed-by: nainar <nainar@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479996}
[modify] https://crrev.com/59daddb15eae24948399b4982b144fd70324d8b7/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/59daddb15eae24948399b4982b144fd70324d8b7/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/59daddb15eae24948399b4982b144fd70324d8b7/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/59daddb15eae24948399b4982b144fd70324d8b7/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp
[modify] https://crrev.com/59daddb15eae24948399b4982b144fd70324d8b7/third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp
[modify] https://crrev.com/59daddb15eae24948399b4982b144fd70324d8b7/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/59daddb15eae24948399b4982b144fd70324d8b7/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
Project Member

Comment 45 by bugdroid1@chromium.org, Jun 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93b52f2ebbf04c770661d6152dc3287993e0e448

commit 93b52f2ebbf04c770661d6152dc3287993e0e448
Author: Naina Raisinghani <nainar@chromium.org>
Date: Fri Jun 16 10:06:02 2017

Make TextDecorationStyle an enum class and change name to ETextDecorationStyle.

This patch makes TextDecorationStyle an enum class for type safety and changes the
name to EResize to match the other enums

BUG= 684966 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia3757a254b1fc44dcf1881dab0c46047dd7cd5ec
Reviewed-on: https://chromium-review.googlesource.com/536713
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480007}
[modify] https://crrev.com/93b52f2ebbf04c770661d6152dc3287993e0e448/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/93b52f2ebbf04c770661d6152dc3287993e0e448/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/93b52f2ebbf04c770661d6152dc3287993e0e448/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/93b52f2ebbf04c770661d6152dc3287993e0e448/third_party/WebKit/Source/core/paint/AppliedDecorationPainter.cpp
[modify] https://crrev.com/93b52f2ebbf04c770661d6152dc3287993e0e448/third_party/WebKit/Source/core/paint/TextPainterBase.cpp
[modify] https://crrev.com/93b52f2ebbf04c770661d6152dc3287993e0e448/third_party/WebKit/Source/core/style/AppliedTextDecoration.cpp
[modify] https://crrev.com/93b52f2ebbf04c770661d6152dc3287993e0e448/third_party/WebKit/Source/core/style/AppliedTextDecoration.h
[modify] https://crrev.com/93b52f2ebbf04c770661d6152dc3287993e0e448/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/93b52f2ebbf04c770661d6152dc3287993e0e448/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/93b52f2ebbf04c770661d6152dc3287993e0e448/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
Project Member

Comment 46 by bugdroid1@chromium.org, Jun 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa610e56f512d68bfc416b5c435396f8c3ea7484

commit aa610e56f512d68bfc416b5c435396f8c3ea7484
Author: Naina Raisinghani <nainar@chromium.org>
Date: Fri Jun 16 10:29:59 2017

Make Resize an enum class and change name to EResize.

This patch makes Resize an enum class for type safety and changes the
name to EResize to match the other enums

BUG= 684966 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I29fad6eac63e4129e15a129a51c288350b293558
Reviewed-on: https://chromium-review.googlesource.com/536394
Commit-Queue: nainar <nainar@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480010}
[modify] https://crrev.com/aa610e56f512d68bfc416b5c435396f8c3ea7484/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/aa610e56f512d68bfc416b5c435396f8c3ea7484/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/aa610e56f512d68bfc416b5c435396f8c3ea7484/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
[modify] https://crrev.com/aa610e56f512d68bfc416b5c435396f8c3ea7484/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/aa610e56f512d68bfc416b5c435396f8c3ea7484/third_party/WebKit/Source/core/layout/LayoutIFrame.cpp
[modify] https://crrev.com/aa610e56f512d68bfc416b5c435396f8c3ea7484/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/aa610e56f512d68bfc416b5c435396f8c3ea7484/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/aa610e56f512d68bfc416b5c435396f8c3ea7484/third_party/WebKit/Source/core/paint/ScrollableAreaPainter.cpp
[modify] https://crrev.com/aa610e56f512d68bfc416b5c435396f8c3ea7484/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/aa610e56f512d68bfc416b5c435396f8c3ea7484/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
Project Member

Comment 47 by bugdroid1@chromium.org, Jun 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/820c421dd73ba99b6d054ea6c108ae760227268f

commit 820c421dd73ba99b6d054ea6c108ae760227268f
Author: Darren Shen <shend@chromium.org>
Date: Mon Jun 19 01:29:24 2017

Make DraggableRegionMode an enum class called EDraggableRegionMode.

This patch makes DraggableRegionMode an enum class for type safety and
changes the name to EDraggableRegionMode to match the other enums.

Bug:  684966 
Change-Id: Iea1f2e77bab27bf5a3a11c2bd97c6007add5b9ae
Reviewed-on: https://chromium-review.googlesource.com/536558
Reviewed-by: nainar <nainar@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480326}
[modify] https://crrev.com/820c421dd73ba99b6d054ea6c108ae760227268f/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/820c421dd73ba99b6d054ea6c108ae760227268f/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5
[modify] https://crrev.com/820c421dd73ba99b6d054ea6c108ae760227268f/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
[modify] https://crrev.com/820c421dd73ba99b6d054ea6c108ae760227268f/third_party/WebKit/Source/core/layout/LayoutInline.cpp
[modify] https://crrev.com/820c421dd73ba99b6d054ea6c108ae760227268f/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/820c421dd73ba99b6d054ea6c108ae760227268f/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/820c421dd73ba99b6d054ea6c108ae760227268f/third_party/WebKit/Source/core/style/ComputedStyleConstants.h

Comment 49 by shend@chromium.org, Jul 5 2017

Cc: shend@chromium.org danakj@chromium.org dcheng@chromium.org nainar@chromium.org
 Issue 584543  has been merged into this issue.

Comment 50 by shend@chromium.org, Aug 16 2017 

There are still some left https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/style/ComputedStyleConstants.h

Haven't worked on it recently.

Comment 51 by shend@chromium.org, Sep 20 2017

Labels: -Update-Monthly Update-Quarterly
Project Member

Comment 52 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/364b4e7c096e1b6264e5374e183014671da8777f

commit 364b4e7c096e1b6264e5374e183014671da8777f
Author: Darren Shen <shend@chromium.org>
Date: Tue Oct 03 07:04:27 2017

Make SnapStrictness an enum class.

This patch makes SnapStrictness an enum class for better type safety.

Bug:  684966 
Change-Id: I01e1d97b126d334f1cc2507cba0e59dff628652e
Reviewed-on: https://chromium-review.googlesource.com/689074
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505972}
[modify] https://crrev.com/364b4e7c096e1b6264e5374e183014671da8777f/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/364b4e7c096e1b6264e5374e183014671da8777f/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/364b4e7c096e1b6264e5374e183014671da8777f/third_party/WebKit/Source/core/style/ScrollSnap.h

Comment 53 by shend@chromium.org, Oct 25 2017

Owner: ----
Status: Available (was: Started)
Marking as available since I'm not actively working on this.
Project Member

Comment 55 by bugdroid1@chromium.org, Nov 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/024f8e19d88280b08026f465a3fa00e644ef0b3b

commit 024f8e19d88280b08026f465a3fa00e644ef0b3b
Author: zhuoyu.qian <zhuoyu.qian@samsung.com>
Date: Fri Nov 17 10:55:07 2017

Make SnapAlignment and SnapAxis to be enum class.

This patch makes SnapAlignment and SnapAxis to be enum class for
better type safety.

Bug:  684966 

Signed-off-by: zhuoyu.qian <zhuoyu.qian@samsung.com>
Change-Id: Ied4b9620ff39c426cac362336a904be0865bf725
Reviewed-on: https://chromium-review.googlesource.com/768351
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#517364}
[modify] https://crrev.com/024f8e19d88280b08026f465a3fa00e644ef0b3b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/024f8e19d88280b08026f465a3fa00e644ef0b3b/third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.cpp
[modify] https://crrev.com/024f8e19d88280b08026f465a3fa00e644ef0b3b/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/024f8e19d88280b08026f465a3fa00e644ef0b3b/third_party/WebKit/Source/core/style/ScrollSnap.h
Project Member

Comment 56 by bugdroid1@chromium.org, Dec 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe89744edece775f453daf1ed4ee3348f45a2188

commit fe89744edece775f453daf1ed4ee3348f45a2188
Author: zhuoyu.qian <zhuoyu.qian@samsung.com>
Date: Wed Dec 06 03:12:49 2017

Change ComputedStyle enums to enum classes and rename enumerators

This patch makes EFillAttachment, EFillBox, EFillRepeat and EFillLayerType
to be enum class for better type safety.

Bug:  684966 

Signed-off-by: zhuoyu.qian <zhuoyu.qian@samsung.com>
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1738b905c71a566d7063a8467afbe920f4497509
Reviewed-on: https://chromium-review.googlesource.com/776409
Reviewed-by: nainar <nainar@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521978}
[modify] https://crrev.com/fe89744edece775f453daf1ed4ee3348f45a2188/third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
[modify] https://crrev.com/fe89744edece775f453daf1ed4ee3348f45a2188/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/fe89744edece775f453daf1ed4ee3348f45a2188/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/fe89744edece775f453daf1ed4ee3348f45a2188/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5
[modify] https://crrev.com/fe89744edece775f453daf1ed4ee3348f45a2188/third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp
[modify] https://crrev.com/fe89744edece775f453daf1ed4ee3348f45a2188/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/fe89744edece775f453daf1ed4ee3348f45a2188/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/fe89744edece775f453daf1ed4ee3348f45a2188/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/fe89744edece775f453daf1ed4ee3348f45a2188/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/fe89744edece775f453daf1ed4ee3348f45a2188/third_party/WebKit/Source/core/layout/LayoutImage.cpp
[modify] https://crrev.com/fe89744edece775f453daf1ed4ee3348f45a2188/third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp
[modify] https://crrev.com/fe89744edece775f453daf1ed4ee3348f45a2188/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp
[modify] https://crrev.com/fe89744edece775f453daf1ed4ee3348f45a2188/third_party/WebKit/Source/core/paint/BoxPainterBase.cpp
[modify] https://crrev.com/fe89744edece775f453daf1ed4ee3348f45a2188/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/fe89744edece775f453daf1ed4ee3348f45a2188/third_party/WebKit/Source/core/paint/ViewPainter.cpp
[modify] https://crrev.com/fe89744edece775f453daf1ed4ee3348f45a2188/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/fe89744edece775f453daf1ed4ee3348f45a2188/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/fe89744edece775f453daf1ed4ee3348f45a2188/third_party/WebKit/Source/core/style/FillLayer.cpp
[modify] https://crrev.com/fe89744edece775f453daf1ed4ee3348f45a2188/third_party/WebKit/Source/core/style/FillLayer.h

Comment 57 by nainar@chromium.org, Dec 6 2017

Labels: -Update-Quarterly
Project Member

Comment 58 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa5f67766b4f7cbd2cb389405216d8abd50ddfe4

commit aa5f67766b4f7cbd2cb389405216d8abd50ddfe4
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Thu Dec 07 08:29:40 2017

Change ContentPosition and ContentDistributionType to be enum classes.

This patch makes ContentPosition and ContentDistributionType to be
enum classes for better type safety.

Bug:  684966 

Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: Id316e846b10d1aa5316fab78eb1189ce542a1404
Reviewed-on: https://chromium-review.googlesource.com/810406
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522381}
[modify] https://crrev.com/aa5f67766b4f7cbd2cb389405216d8abd50ddfe4/third_party/WebKit/Source/build/scripts/core/style/templates/ComputedStyleInitialValues.h.tmpl
[modify] https://crrev.com/aa5f67766b4f7cbd2cb389405216d8abd50ddfe4/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/aa5f67766b4f7cbd2cb389405216d8abd50ddfe4/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/aa5f67766b4f7cbd2cb389405216d8abd50ddfe4/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/aa5f67766b4f7cbd2cb389405216d8abd50ddfe4/third_party/WebKit/Source/core/layout/FlexibleBoxAlgorithm.cpp
[modify] https://crrev.com/aa5f67766b4f7cbd2cb389405216d8abd50ddfe4/third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp
[modify] https://crrev.com/aa5f67766b4f7cbd2cb389405216d8abd50ddfe4/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp
[modify] https://crrev.com/aa5f67766b4f7cbd2cb389405216d8abd50ddfe4/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp
[modify] https://crrev.com/aa5f67766b4f7cbd2cb389405216d8abd50ddfe4/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] https://crrev.com/aa5f67766b4f7cbd2cb389405216d8abd50ddfe4/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/aa5f67766b4f7cbd2cb389405216d8abd50ddfe4/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/aa5f67766b4f7cbd2cb389405216d8abd50ddfe4/third_party/WebKit/Source/core/style/StyleContentAlignmentData.h
Project Member

Comment 59 by bugdroid1@chromium.org, Dec 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87a36332e1c779524207c902277faf7f9829f91c

commit 87a36332e1c779524207c902277faf7f9829f91c
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Mon Dec 11 08:58:57 2017

Change OverflowAlignment to be an enum class.

This patch makes OverflowAlignment to be an enum class for better type safety.

Bug:  684966 

Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: I03a7b2083ed19b70316074dd36a52a82114e10df
Reviewed-on: https://chromium-review.googlesource.com/818672
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523059}
[modify] https://crrev.com/87a36332e1c779524207c902277faf7f9829f91c/third_party/WebKit/Source/build/scripts/core/style/templates/ComputedStyleInitialValues.h.tmpl
[modify] https://crrev.com/87a36332e1c779524207c902277faf7f9829f91c/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/87a36332e1c779524207c902277faf7f9829f91c/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/87a36332e1c779524207c902277faf7f9829f91c/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/87a36332e1c779524207c902277faf7f9829f91c/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] https://crrev.com/87a36332e1c779524207c902277faf7f9829f91c/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/87a36332e1c779524207c902277faf7f9829f91c/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/87a36332e1c779524207c902277faf7f9829f91c/third_party/WebKit/Source/core/style/StyleContentAlignmentData.h
[modify] https://crrev.com/87a36332e1c779524207c902277faf7f9829f91c/third_party/WebKit/Source/core/style/StyleSelfAlignmentData.h
Project Member

Comment 60 by bugdroid1@chromium.org, Dec 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/243b284d8b15db9dd8b50b086a0be27551767cb8

commit 243b284d8b15db9dd8b50b086a0be27551767cb8
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Thu Dec 14 02:42:32 2017

Change ItemPosition and ItemPositionType to be enum classes.

This patch makes ItemPosition and ItemPositionType to be enum classes
for better type safety.

Bug:  684966 

Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: Idd1a687d1e8bb07cdf12398fd84045ab7ef3ede3
Reviewed-on: https://chromium-review.googlesource.com/821801
Reviewed-by: nainar <nainar@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523990}
[modify] https://crrev.com/243b284d8b15db9dd8b50b086a0be27551767cb8/third_party/WebKit/Source/build/scripts/core/style/templates/ComputedStyleInitialValues.h.tmpl
[modify] https://crrev.com/243b284d8b15db9dd8b50b086a0be27551767cb8/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/243b284d8b15db9dd8b50b086a0be27551767cb8/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/243b284d8b15db9dd8b50b086a0be27551767cb8/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/243b284d8b15db9dd8b50b086a0be27551767cb8/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
[modify] https://crrev.com/243b284d8b15db9dd8b50b086a0be27551767cb8/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/243b284d8b15db9dd8b50b086a0be27551767cb8/third_party/WebKit/Source/core/layout/BaselineAlignment.h
[modify] https://crrev.com/243b284d8b15db9dd8b50b086a0be27551767cb8/third_party/WebKit/Source/core/layout/FlexibleBoxAlgorithm.cpp
[modify] https://crrev.com/243b284d8b15db9dd8b50b086a0be27551767cb8/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/243b284d8b15db9dd8b50b086a0be27551767cb8/third_party/WebKit/Source/core/layout/LayoutBox.h
[modify] https://crrev.com/243b284d8b15db9dd8b50b086a0be27551767cb8/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp
[modify] https://crrev.com/243b284d8b15db9dd8b50b086a0be27551767cb8/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp
[modify] https://crrev.com/243b284d8b15db9dd8b50b086a0be27551767cb8/third_party/WebKit/Source/core/layout/LayoutFullScreen.h
[modify] https://crrev.com/243b284d8b15db9dd8b50b086a0be27551767cb8/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] https://crrev.com/243b284d8b15db9dd8b50b086a0be27551767cb8/third_party/WebKit/Source/core/layout/LayoutGrid.h
[modify] https://crrev.com/243b284d8b15db9dd8b50b086a0be27551767cb8/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp
[modify] https://crrev.com/243b284d8b15db9dd8b50b086a0be27551767cb8/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/243b284d8b15db9dd8b50b086a0be27551767cb8/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/243b284d8b15db9dd8b50b086a0be27551767cb8/third_party/WebKit/Source/core/style/StyleSelfAlignmentData.h
Project Member

Comment 61 by bugdroid1@chromium.org, Dec 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a12c4b3fa0cb1ee0ce78f6b3726b7f3dc17c3f1

commit 5a12c4b3fa0cb1ee0ce78f6b3726b7f3dc17c3f1
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Fri Dec 15 08:05:24 2017

Make EFillSizeType to be an enum class.

This patch makes EFillSizeType to be an enum class for better type safety.

Bug:  684966 

Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I61fd98a1fd15ae4b1dbbd39bfe68d1776cfb4df1
Reviewed-on: https://chromium-review.googlesource.com/828182
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524350}
[modify] https://crrev.com/5a12c4b3fa0cb1ee0ce78f6b3726b7f3dc17c3f1/third_party/WebKit/Source/core/animation/SizeInterpolationFunctions.cpp
[modify] https://crrev.com/5a12c4b3fa0cb1ee0ce78f6b3726b7f3dc17c3f1/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/5a12c4b3fa0cb1ee0ce78f6b3726b7f3dc17c3f1/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/5a12c4b3fa0cb1ee0ce78f6b3726b7f3dc17c3f1/third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp
[modify] https://crrev.com/5a12c4b3fa0cb1ee0ce78f6b3726b7f3dc17c3f1/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/5a12c4b3fa0cb1ee0ce78f6b3726b7f3dc17c3f1/third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp
[modify] https://crrev.com/5a12c4b3fa0cb1ee0ce78f6b3726b7f3dc17c3f1/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/5a12c4b3fa0cb1ee0ce78f6b3726b7f3dc17c3f1/third_party/WebKit/Source/core/style/FillLayer.cpp
[modify] https://crrev.com/5a12c4b3fa0cb1ee0ce78f6b3726b7f3dc17c3f1/third_party/WebKit/Source/core/style/FillLayer.h
Project Member

Comment 62 by bugdroid1@chromium.org, Dec 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85a9704e84344297dfc26222a6d1dff80fea990c

commit 85a9704e84344297dfc26222a6d1dff80fea990c
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Wed Dec 20 03:35:34 2017

Make BackgroundEdgeOrigin to be an enum class.

This patch makes BackgroundEdgeOrigin to be an enum class for better
type safety.

Bug:  684966 

Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Idd6d55e4cb4f67d844a5ffbea7a47dd5d375c07d
Reviewed-on: https://chromium-review.googlesource.com/830988
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525250}
[modify] https://crrev.com/85a9704e84344297dfc26222a6d1dff80fea990c/third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp
[modify] https://crrev.com/85a9704e84344297dfc26222a6d1dff80fea990c/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/85a9704e84344297dfc26222a6d1dff80fea990c/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/85a9704e84344297dfc26222a6d1dff80fea990c/third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp
[modify] https://crrev.com/85a9704e84344297dfc26222a6d1dff80fea990c/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/85a9704e84344297dfc26222a6d1dff80fea990c/third_party/WebKit/Source/core/style/FillLayer.cpp
[modify] https://crrev.com/85a9704e84344297dfc26222a6d1dff80fea990c/third_party/WebKit/Source/core/style/FillLayer.h
Project Member

Comment 63 by bugdroid1@chromium.org, Jan 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4853213e011c9f5b8bc67f4dd966a3213e71fd87

commit 4853213e011c9f5b8bc67f4dd966a3213e71fd87
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Tue Jan 02 07:14:39 2018

Change BoxSide to be an enum class.

This patch makes BoxSide to be an enum class for better type safety.

Bug:  684966 

Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I871dd622e8b42a980b0d9f4a64b781f2893800e3
Reviewed-on: https://chromium-review.googlesource.com/844297
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526444}
[modify] https://crrev.com/4853213e011c9f5b8bc67f4dd966a3213e71fd87/third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp
[modify] https://crrev.com/4853213e011c9f5b8bc67f4dd966a3213e71fd87/third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp
[modify] https://crrev.com/4853213e011c9f5b8bc67f4dd966a3213e71fd87/third_party/WebKit/Source/core/paint/BoxPainterBase.cpp
[modify] https://crrev.com/4853213e011c9f5b8bc67f4dd966a3213e71fd87/third_party/WebKit/Source/core/paint/CollapsedBorderPainter.cpp
[modify] https://crrev.com/4853213e011c9f5b8bc67f4dd966a3213e71fd87/third_party/WebKit/Source/core/paint/MultiColumnSetPainter.cpp
[modify] https://crrev.com/4853213e011c9f5b8bc67f4dd966a3213e71fd87/third_party/WebKit/Source/core/paint/ObjectPainterBase.cpp
[modify] https://crrev.com/4853213e011c9f5b8bc67f4dd966a3213e71fd87/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/4853213e011c9f5b8bc67f4dd966a3213e71fd87/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
Project Member

Comment 64 by bugdroid1@chromium.org, Jan 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2015e0096b1642bac03bbb8e2551d293b28c866

commit c2015e0096b1642bac03bbb8e2551d293b28c866
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Fri Jan 05 00:40:39 2018

Change EMaskSourceType to be an enum class.

This patch makes EMaskSourceType to be an enum class
for better type safety.

Bug:  684966 

Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I199d12a2428ebb461747612bb7b16493fc49b578
Reviewed-on: https://chromium-review.googlesource.com/848619
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527169}
[modify] https://crrev.com/c2015e0096b1642bac03bbb8e2551d293b28c866/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/c2015e0096b1642bac03bbb8e2551d293b28c866/third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp
[modify] https://crrev.com/c2015e0096b1642bac03bbb8e2551d293b28c866/third_party/WebKit/Source/core/paint/BoxPainterBase.cpp
[modify] https://crrev.com/c2015e0096b1642bac03bbb8e2551d293b28c866/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/c2015e0096b1642bac03bbb8e2551d293b28c866/third_party/WebKit/Source/core/style/FillLayer.cpp
[modify] https://crrev.com/c2015e0096b1642bac03bbb8e2551d293b28c866/third_party/WebKit/Source/core/style/FillLayer.h
Project Member

Comment 67 by bugdroid1@chromium.org, Jan 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fc4092cc78f134f25b054f06395fe9e9a81139a

commit 4fc4092cc78f134f25b054f06395fe9e9a81139a
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Thu Jan 11 01:34:37 2018

Change OffsetRotationType to be an enum class.

This patch makes OffsetRotationType to be an enum class
for better type safety.

Bug:  684966 

Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: I9aa37be5be58fa9ea1b3d1d9b5918f7f271050b2
Reviewed-on: https://chromium-review.googlesource.com/858620
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528525}
[modify] https://crrev.com/4fc4092cc78f134f25b054f06395fe9e9a81139a/third_party/WebKit/Source/core/animation/CSSOffsetRotateInterpolationType.cpp
[modify] https://crrev.com/4fc4092cc78f134f25b054f06395fe9e9a81139a/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/4fc4092cc78f134f25b054f06395fe9e9a81139a/third_party/WebKit/Source/core/css/properties/longhands/OffsetRotateCustom.cpp
[modify] https://crrev.com/4fc4092cc78f134f25b054f06395fe9e9a81139a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/4fc4092cc78f134f25b054f06395fe9e9a81139a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/4fc4092cc78f134f25b054f06395fe9e9a81139a/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
Project Member

Comment 68 by bugdroid1@chromium.org, Jan 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/021c684ece6ff2b8150ac6880656acdae070f211

commit 021c684ece6ff2b8150ac6880656acdae070f211
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Sat Jan 13 03:09:59 2018

Change CSSBoxType to be an enum class.

This patch makes CSSBoxType to be an enum class for better type safety.

Bug:  684966 

Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: I5d356eeff2794ab6fe75781d37490fd7df54657b
Reviewed-on: https://chromium-review.googlesource.com/861591
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529152}
[modify] https://crrev.com/021c684ece6ff2b8150ac6880656acdae070f211/third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp
[modify] https://crrev.com/021c684ece6ff2b8150ac6880656acdae070f211/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/021c684ece6ff2b8150ac6880656acdae070f211/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/021c684ece6ff2b8150ac6880656acdae070f211/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/021c684ece6ff2b8150ac6880656acdae070f211/third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.cpp
[modify] https://crrev.com/021c684ece6ff2b8150ac6880656acdae070f211/third_party/WebKit/Source/core/style/ComputedStyleConstants.h
[modify] https://crrev.com/021c684ece6ff2b8150ac6880656acdae070f211/third_party/WebKit/Source/core/style/ComputedStyleTest.cpp
[modify] https://crrev.com/021c684ece6ff2b8150ac6880656acdae070f211/third_party/WebKit/Source/core/style/ShapeValue.h
Project Member

Comment 69 by bugdroid1@chromium.org, Jan 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1e464ee5657e451adbce753d7ba367547d1c500

commit a1e464ee5657e451adbce753d7ba367547d1c500
Author: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Date: Mon Jan 15 07:19:54 2018

Change TextEmphasisPosition to be an enum class.

This patch makes TextEmphasisPosition to be an enum class for
better type safety.

Bug:  684966 

Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: I1b11eaed7f2cfcf49e9ed8611f2edb83278702b1
Reviewed-on: https://chromium-review.googlesource.com/866278
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529216}
[modify] https://crrev.com/a1e464ee5657e451adbce753d7ba367547d1c500/third_party/WebKit/Source/core/style/ComputedStyleConstants.h

Comment 70 by e...@chromium.org, Dec 13

Status: Fixed (was: Available)
►

Sign in to add a comment