some component updater files are missing build/build_config.h |
|||||||||
Issue description
In order to use conditional compilation, the files must include "build/build_config.h".
Otherwise, code such as the one below will always take the #else branch since OS_WIN is not defined.
bool IsPerUserInstall() {
#if defined(OS_WIN)
base::FilePath exe_path;
PathService::Get(base::FILE_EXE, &exe_path);
return InstallUtil::IsPerUserInstall(exe_path);
#else
return true;
#endif
,
Jan 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96d71e0c6c152a39ee9b452c96428af7cc4520bc commit 96d71e0c6c152a39ee9b452c96428af7cc4520bc Author: sorin <sorin@chromium.org> Date: Wed Jan 25 17:39:11 2017 Include build/build_config.h in all component updater files. All files using conditional compilation must include the build_config, otherwise the platform symbols are not defined. BUG= 684950 Review-Url: https://codereview.chromium.org/2655813002 Cr-Commit-Position: refs/heads/master@{#446050} [modify] https://crrev.com/96d71e0c6c152a39ee9b452c96428af7cc4520bc/chrome/browser/component_updater/chrome_component_updater_configurator.cc [modify] https://crrev.com/96d71e0c6c152a39ee9b452c96428af7cc4520bc/chrome/browser/component_updater/component_updater_utils.cc [modify] https://crrev.com/96d71e0c6c152a39ee9b452c96428af7cc4520bc/components/update_client/update_checker_unittest.cc [modify] https://crrev.com/96d71e0c6c152a39ee9b452c96428af7cc4520bc/components/update_client/updater_state.cc [modify] https://crrev.com/96d71e0c6c152a39ee9b452c96428af7cc4520bc/components/update_client/updater_state_unittest.cc
,
Jan 26 2017
,
Jan 26 2017
,
Jan 26 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 26 2017
This bug requires manual review: We are only 4 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 26 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02cb3e5d0fddfbe903e2a4dd8f8f010d516f8b89 commit 02cb3e5d0fddfbe903e2a4dd8f8f010d516f8b89 Author: Sorin Jianu <sorin@chromium.org> Date: Fri Jan 27 17:05:02 2017 Merged to M57. Include build/build_config.h in all component updater files. All files using conditional compilation must include the build_config, otherwise the platform symbols are not defined. BUG= 684950 Review-Url: https://codereview.chromium.org/2655813002 Cr-Commit-Position: refs/heads/master@{#446050} (cherry picked from commit 96d71e0c6c152a39ee9b452c96428af7cc4520bc) Review-Url: https://codereview.chromium.org/2656713009 . Cr-Commit-Position: refs/branch-heads/2987@{#148} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/02cb3e5d0fddfbe903e2a4dd8f8f010d516f8b89/chrome/browser/component_updater/chrome_component_updater_configurator.cc [modify] https://crrev.com/02cb3e5d0fddfbe903e2a4dd8f8f010d516f8b89/chrome/browser/component_updater/component_updater_utils.cc [modify] https://crrev.com/02cb3e5d0fddfbe903e2a4dd8f8f010d516f8b89/components/update_client/update_checker_unittest.cc [modify] https://crrev.com/02cb3e5d0fddfbe903e2a4dd8f8f010d516f8b89/components/update_client/updater_state.cc [modify] https://crrev.com/02cb3e5d0fddfbe903e2a4dd8f8f010d516f8b89/components/update_client/updater_state_unittest.cc
,
Jan 27 2017
LGTM for merging into M56
,
Jan 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb55e5c0df12ced401f5ccb1309bd3ac7fde0e65 commit fb55e5c0df12ced401f5ccb1309bd3ac7fde0e65 Author: Sorin Jianu <sorin@chromium.org> Date: Fri Jan 27 18:28:30 2017 Include build/build_config.h in all component updater files. All files using conditional compilation must include the build_config, otherwise the platform symbols are not defined. Merged to M56. BUG= 684950 Review-Url: https://codereview.chromium.org/2655813002 Cr-Commit-Position: refs/heads/master@{#446050} (cherry picked from commit 96d71e0c6c152a39ee9b452c96428af7cc4520bc) Review-Url: https://codereview.chromium.org/2658133003 . Cr-Commit-Position: refs/branch-heads/2924@{#878} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/fb55e5c0df12ced401f5ccb1309bd3ac7fde0e65/chrome/browser/component_updater/chrome_component_updater_configurator.cc [modify] https://crrev.com/fb55e5c0df12ced401f5ccb1309bd3ac7fde0e65/chrome/browser/component_updater/component_updater_utils.cc [modify] https://crrev.com/fb55e5c0df12ced401f5ccb1309bd3ac7fde0e65/components/update_client/update_checker_unittest.cc [modify] https://crrev.com/fb55e5c0df12ced401f5ccb1309bd3ac7fde0e65/components/update_client/updater_state.cc [modify] https://crrev.com/fb55e5c0df12ced401f5ccb1309bd3ac7fde0e65/components/update_client/updater_state_unittest.cc |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by grt@chromium.org
, Jan 25 2017