New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684936 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Search for the right obsolete slave builds in CleanUpStage

Project Member Reported by nxia@chromium.org, Jan 25 2017

Issue description

When cancelling the obsolete slave builds in CleanUpStage, search for slave builds with right manifest branch tag and Buildbucket bucket name.
 

Comment 1 by nxia@chromium.org, Jan 31 2017

Cc: akes...@chromium.org
Right now when a master wants to clean up obsolete slave builds, it searches with tag:build_type in chromeos and chromiumos buckets. 

It brings problems:

1) The master build in chromeos.release waterfall also tries to cancel the slave builds in chromeos and chromiumos waterfalls.
2) We can run 3 master builds on chromeos.relase waterfall on different branches at the same time. R57 branch master shouldn't cancel the slaves of R56 branch master. 

Comment 2 by nxia@chromium.org, Jan 31 2017

Cc: dgarr...@chromium.org
dgarrett@ mentioned there would be a plan to launch multiple android-pfq masters. This bug should be fixed before the multiple masters. 
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/911af741692fa4b9ec26bda1a48263ba4d2ec046

commit 911af741692fa4b9ec26bda1a48263ba4d2ec046
Author: Ningning Xia <nxia@chromium.org>
Date: Fri Feb 03 13:15:09 2017

Search obsolete slaves with right buckets and tags in CleanUpStage.

1) Add manifest branch to the slave build Buildbucket tag set.
2) When searching for obsolete slave builds to cancel:
 a) search in the right Buildbucket buckets.
 b) search with the right build tag.

BUG= chromium:684936 
TEST=unit_tests

Change-Id: I0b38b404fbd1af45238dd59633aac4c53304b2e7
Reviewed-on: https://chromium-review.googlesource.com/432998
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/911af741692fa4b9ec26bda1a48263ba4d2ec046/cbuildbot/stages/scheduler_stages.py
[modify] https://crrev.com/911af741692fa4b9ec26bda1a48263ba4d2ec046/cbuildbot/stages/build_stages.py
[modify] https://crrev.com/911af741692fa4b9ec26bda1a48263ba4d2ec046/cbuildbot/stages/build_stages_unittest.py

Comment 4 by nxia@chromium.org, Feb 3 2017

Labels: Hotlist-Fixit cros-infra-fixedit-q117
Status: Fixed (was: Untriaged)

Comment 5 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment