Use |bitmapData| directly for |unPremultipliedBitmap| to spare a copy |
||||
Issue descriptionSteps to reproduce the problem: Use |bitmapData| directly for |unPremultipliedBitmap| to spare a copy. What is the expected behavior? What went wrong? Did this work before? N/A Chrome version: Channel: n/a OS Version: Flash Version:
,
Apr 12 2017
,
May 11 2017
,
Jun 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4419510166945a42be685c344f02db41335c44db commit 4419510166945a42be685c344f02db41335c44db Author: junweifu <junwei.fu@intel.com> Date: Sat Jun 24 19:36:46 2017 ShapeDetection: Remove TODOs and handle null Bitmap case. kN32_SkColorType is used in [1] by default when decoding loaded image because it's an alias for whichever 32bit ARGB format is the "native" form for skia's blitters. so use it if we don't have a swizzle preference for 32bit pixels as commented in [2]. So remove TODOs about supporting other pixel format. Handle the case when BitmapUtils.convertToBitmap() returns null in FaceDetectionImpl. [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp?l=112 [2] https://cs.chromium.org/chromium/src/third_party/skia/include/core/SkImageInfo.h?l=64 BUG= 684921 , 684930 Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Change-Id: Ib353cbd1ffb9c1bd1bdc570f0610b7671ef86639 Reviewed-on: https://chromium-review.googlesource.com/545256 Reviewed-by: Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#482159} [modify] https://crrev.com/4419510166945a42be685c344f02db41335c44db/services/shape_detection/android/java/src/org/chromium/shape_detection/BarcodeDetectionImpl.java [modify] https://crrev.com/4419510166945a42be685c344f02db41335c44db/services/shape_detection/android/java/src/org/chromium/shape_detection/BitmapUtils.java [modify] https://crrev.com/4419510166945a42be685c344f02db41335c44db/services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImpl.java [modify] https://crrev.com/4419510166945a42be685c344f02db41335c44db/services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImplGmsCore.java [modify] https://crrev.com/4419510166945a42be685c344f02db41335c44db/services/shape_detection/android/java/src/org/chromium/shape_detection/TextDetectionImpl.java
,
Jun 27 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mcasas@chromium.org
, Jan 25 2017Components: Blink>ImageCapture
Labels: ShapeDetection