New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684918 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

chromite/cbuildboot/chromeos_config_unittest should have an update option.

Project Member Reported by dgarr...@chromium.org, Jan 25 2017

Issue description

chromeos_config_unittest ensures that config_dump.json and waterfall_layout_dump.txt are up to date, and gives instructions on how to update them if needed.

It would be convenient if it had a new option to just update those files if they are out of date.

 
More details please?
The pre-upload hook already does this. 
Yes, but I would find it very convenient to do this straight from the test (with an extra commandline).

Alternatively, a really, really simple way to run the preupload hooks without trying to upload would help.
Cc: bhthompson@chromium.org
Owner: dgarr...@chromium.org
Status: Started (was: Untriaged)
I'm starting to add --update to the chromite unittest command line.

Whenm I'm done, two commands will update config_dump.json, and waterfall_layout_dump.txt.

  run_tests --update
  cbuildbot/chromeos_config --update

We'll also have an easy hook for other tests to use if they want similar behavior.
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/9b91a54faf07862759ad96829dad94a1971e05ce

commit 9b91a54faf07862759ad96829dad94a1971e05ce
Author: Don Garrett <dgarrett@google.com>
Date: Thu Feb 02 04:27:53 2017

cros_test_lib: Add -u and --update to unittests.

Add --update to all chromite unittests to indicate that generated data
files should be updated. Currently, this can be used to update both
config_dump.json and waterfall_layout_dump.txt.

Both of these commands will update both of those files if needed:
  cbuildbot/run_tests --update
  cbuildbot/chromeos_config_unittest --update

If --update is not present, both tests will still fail if the files in
question are out of date.

BUG= chromium:684918 
TEST=run_tests (with/without -u and with/without modified dump files).

Change-Id: I7e1f1a0c966023ccf507754dea4577638035410a
Reviewed-on: https://chromium-review.googlesource.com/435570
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/9b91a54faf07862759ad96829dad94a1971e05ce/cbuildbot/chromeos_config_unittest.py
[modify] https://crrev.com/9b91a54faf07862759ad96829dad94a1971e05ce/lib/cros_test_lib.py

Labels: cros-infra-fixedit-q117
Status: Fixed (was: Started)

Comment 7 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 8 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment