New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 684903 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

WebglConformance_conformance_uniforms_no_over_optimization_on_uniform_array_12 flaking on Mac Retina FYI bot

Project Member Reported by ajuma@chromium.org, Jan 25 2017

Issue description

Recent flakes:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Release/builds/10300
https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Release/builds/10304

The test is crashing in gpu::gles2::RenderBufferManager::RemoveRenderBuffer:

Crash reason: 0x00000000 / 0x00000000
Crash address: 0x7fff91189f06
Process uptime: 405 seconds

Thread 0 (crashed)
0 libsystem_kernel.dylib + 0x16f06
rax = 0x0000000000000000 rdx = 0x0000000000000000
rcx = 0x00007fff5c26b1c8 rbx = 0x0000000000000006
rsi = 0x0000000000000006 rdi = 0x0000000000000307
rbp = 0x00007fff5c26b1f0 rsp = 0x00007fff5c26b1c8
r8 = 0x0000000000000000 r9 = 0x0000000000989680
r10 = 0x0000000008000000 r11 = 0x0000000000000206
r12 = 0x000000012a39ecf8 r13 = 0x0000000000000000
r14 = 0x00007fff77620000 r15 = 0x000000012a39e000
rip = 0x00007fff91189f06
Found by: given as instruction pointer in context
1 libsystem_c.dylib + 0x5e77f
rbp = 0x00007fff5c26b220 rsp = 0x00007fff5c26b200
rip = 0x00007fff9761477f
Found by: previous frame's frame pointer
2 libsystem_c.dylib + 0x5e6ee
rbp = 0x00007fff5c26b250 rsp = 0x00007fff5c26b230
rip = 0x00007fff976146ee
Found by: previous frame's frame pointer
3 libGPUSupportMercury.dylib + 0x1e5c
rbp = 0x00007fff5c26b300 rsp = 0x00007fff5c26b260
rip = 0x00007fff8b5c9e5c
Found by: previous frame's frame pointer
4 GeForceGLDriver + 0x220dc7
rbp = 0x00007fff5c26b310 rsp = 0x00007fff5c26b310
rip = 0x00007fff9368cdc7
Found by: previous frame's frame pointer
5 libGPUSupportMercury.dylib + 0x3361
rbp = 0x00007fff5c26b360 rsp = 0x00007fff5c26b320
rip = 0x00007fff8b5cb361
Found by: previous frame's frame pointer
6 GeForceGLDriver + 0x314f0c
rbp = 0x00007fff5c26b3a0 rsp = 0x00007fff5c26b370
rip = 0x00007fff93780f0c
Found by: previous frame's frame pointer
7 GeForceGLDriver + 0x314d88
rbp = 0x00007fff5c26b3d0 rsp = 0x00007fff5c26b3b0
rip = 0x00007fff93780d88
Found by: previous frame's frame pointer
8 GLEngine + 0x14ee21
rbp = 0x00007fff5c26b400 rsp = 0x00007fff5c26b3e0
rip = 0x00007fff916b6e21
Found by: previous frame's frame pointer
9 GLEngine + 0x11db4d
rbp = 0x00007fff5c26b430 rsp = 0x00007fff5c26b410
rip = 0x00007fff91685b4d
Found by: previous frame's frame pointer
10 GLEngine + 0x54c81
rbp = 0x00007fff5c26b4d0 rsp = 0x00007fff5c26b440
rip = 0x00007fff915bcc81
Found by: previous frame's frame pointer
11 Chromium Framework!__ZN3gpu5gles212RenderbufferD2Ev + 0x4e
rbp = 0x00007fff5c26b610 rsp = 0x00007fff5c26b4e0
rip = 0x00000001071bf8ae
Found by: previous frame's frame pointer
12 Chromium Framework!__ZN13scoped_refptrIN3gpu5gles212RenderbufferEED2Ev + 0x6d
rbp = 0x00007fff5c26b760 rsp = 0x00007fff5c26b620
rip = 0x00000001070eaf2d
Found by: previous frame's frame pointer
13 Chromium Framework!__ZN3gpu5gles219RenderbufferManager18RemoveRenderbufferEj + 0xed
rbp = 0x00007fff5c26b790 rsp = 0x00007fff5c26b770
rip = 0x00000001071c033d
Found by: previous frame's frame pointer
14 Chromium Framework!__ZN3gpu5gles216GLES2DecoderImpl25DeleteRenderbuffersHelperEiPVKj + 0x3a3
rbp = 0x00007fff5c26b900 rsp = 0x00007fff5c26b7a0
rip = 0x00000001071324e3
Found by: previous frame's frame pointer
15 Chromium Framework!__ZN3gpu5gles216GLES2DecoderImpl34HandleDeleteRenderbuffersImmediateEjPVKv + 0x30
rbp = 0x00007fff5c26b910 rsp = 0x00007fff5c26b910
rip = 0x0000000107108030
Found by: previous frame's frame pointer
16 Chromium Framework!__ZN3gpu5gles216GLES2DecoderImpl14DoCommandsImplILb0EEENS_5error5ErrorEjPVKviPi + 0xf0
rbp = 0x00007fff5c26ba90 rsp = 0x00007fff5c26b920
rip = 0x00000001071388a0
Found by: previous frame's frame pointer
17 Chromium Framework!__ZN3gpu13CommandParser15ProcessCommandsEi + 0x35
rbp = 0x00007fff5c26bab0 rsp = 0x00007fff5c26baa0
rip = 0x00000001070ddc05
Found by: previous frame's frame pointer
18 Chromium Framework!__ZN3gpu15CommandExecutor10PutChangedEv + 0x129
rbp = 0x00007fff5c26bc80 rsp = 0x00007fff5c26bac0
rip = 0x00000001070df1f9
Found by: previous frame's frame pointer
19 Chromium Framework!__ZN3gpu20CommandBufferService5FlushEi + 0x7f
rbp = 0x00007fff5c26bdd0 rsp = 0x00007fff5c26bc90
rip = 0x00000001070de33f
Found by: previous frame's frame pointer
20 Chromium Framework!__ZN3gpu20GpuCommandBufferStub12OnAsyncFlushEijRKNSt3__16vectorIN2ui11LatencyInfoENS1_9allocatorIS4_EEEE + 0x143
rbp = 0x00007fff5c26bf90 rsp = 0x00007fff5c26bde0
rip = 0x00000001073f0553
Found by: previous frame's frame pointer
21 Chromium Framework!__ZN3IPC8MessageTI35GpuCommandBufferMsg_AsyncFlush_MetaNSt3__15tupleIJijNS2_6vectorIN2ui11LatencyInfoENS2_9allocatorIS6_EEEEEEEvE8DispatchIN3gpu20GpuCommandBufferStubESE_vMSE_FvijRKS9_EEEbPKNS_7MessageEPT_PT0_PT1_T2_ + 0x7b
rbp = 0x00007fff5c26c020 rsp = 0x00007fff5c26bfa0
rip = 0x00000001073f02eb
Found by: previous frame's frame pointer
 

Comment 1 by ajuma@chromium.org, Jan 25 2017

Cc: jiawei.s...@intel.com
Looks like this is a test that was added earlier this week: https://github.com/KhronosGroup/WebGL/commit/7444285c126b15faef0768a6d945fcb32b682141

And rolled into chrome yesterday:
https://chromium.googlesource.com/chromium/src.git/+/079ae727092a8011d34ddc6cb3feeb7422bc4a6a

Should we mark this as flaky for now?

Comment 2 by ajuma@chromium.org, Jan 25 2017

Talked to zmo@ offline, going to mark this flaky.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37fb000a077f02ae055468eb95476bd4f0d47232

commit 37fb000a077f02ae055468eb95476bd4f0d47232
Author: ajuma <ajuma@chromium.org>
Date: Wed Jan 25 20:53:35 2017

Mark flaky WebGL conformance test on Mac Retina

This marks
WebglConformance_conformance_uniforms_no_over_optimization_on_uniform_array_12
as flaky on Mac Retina. This test has been flaky every since it was added
yesterday.

TBR=zmo@chromium.org
BUG= 684903 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2658663002
Cr-Commit-Position: refs/heads/master@{#446113}

[modify] https://crrev.com/37fb000a077f02ae055468eb95476bd4f0d47232/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33210a663a5eb7b293939bbd5aa2a4076ce7d191

commit 33210a663a5eb7b293939bbd5aa2a4076ce7d191
Author: ajuma <ajuma@chromium.org>
Date: Thu Jan 26 00:59:29 2017

Mark flaky WebGL conformance test as failure on Mac Retina

This marks
WebglConformance_conformance_uniforms_no_over_optimization_on_uniform_array_12
as Fail since the previous Flaky expectation doesn't seem to
be working.

TBR=zmo@chromium.org
BUG= 684903 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2657863003
Cr-Commit-Position: refs/heads/master@{#446183}

[modify] https://crrev.com/33210a663a5eb7b293939bbd5aa2a4076ce7d191/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6e619bd609e974c1310049d21e1b0100d74a052

commit c6e619bd609e974c1310049d21e1b0100d74a052
Author: ajuma <ajuma@chromium.org>
Date: Thu Jan 26 04:41:16 2017

Fix expectation for WebGL2 conformance test failure on Retina Mac

This moves the expectation for
WebglConformance_conformance_uniforms_no_over_optimization_on_uniform_array_12
from webgl_conformance_expectations.py to webgl2_conformance_expectations.py
where it belongs.

TBR=zmo@chromium.org
BUG= 684903 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2649233009
Cr-Commit-Position: refs/heads/master@{#446227}

[modify] https://crrev.com/c6e619bd609e974c1310049d21e1b0100d74a052/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/c6e619bd609e974c1310049d21e1b0100d74a052/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Comment 6 by enne@chromium.org, Apr 14 2017

Labels: -Pri-1 Pri-2
One flaky test does not seem like a p1.  If you think this is wrong, please change back and assign an owner to fix it.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1733d120eb79e2d8d49b18892e60ee1297f646f7

commit 1733d120eb79e2d8d49b18892e60ee1297f646f7
Author: zmo <zmo@chromium.org>
Date: Thu Jun 08 23:24:48 2017

Update WebGL2 conformance test expectations for Mac bots.

BUG= 598930 , 617290 , 618464 ,630800, 641149 , 643866 , 645298 , 646182 , 654187 , 663188 ,665197, 665656 , 676848 , 679682 , 679684 , 679686 , 679687 , 679689 , 679690 , 679691 , 680278 , 684903 
TEST=mac bots on GPU FYI waterfall
TBR=kbr@chromium.org,kainino@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2931993002
Cr-Commit-Position: refs/heads/master@{#478121}

[modify] https://crrev.com/1733d120eb79e2d8d49b18892e60ee1297f646f7/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Comment 8 by zmo@chromium.org, Jun 9 2017

Status: Fixed (was: Available)
I don't think they are flaky anymore. I could be wrong though.

Sign in to add a comment