New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 684894 link

Starred by 1 user
Status: Fixed
Owner:
█ lushnikov@chromium.org
Last visit 29 days ago
Closed: Jan 2017
Cc:
█ allada@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

[REGRESSION] DevTools: network waterfall sort icon is always visible

Project Member Reported by lushnikov@chromium.org, Jan 25 2017 
Chrome Version       : 56.0.2883.95

1. Open devtools, open network panel
2. Reload page
3. Try to toggle sorting of different columns on network waterfall

Expected: only one sorting icon is visible

Actual: waterfall header always has sorting icon visible
See screenshot. Both "Waterfall" and "Time" have small triangle icon.
Screen Shot 2017-01-25 at 11.23.36 AM.png
49.1 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fad6cb6f585cdfeaccf613a9c310f04260c87c3

commit 4fad6cb6f585cdfeaccf613a9c310f04260c87c3
Author: lushnikov <lushnikov@chromium.org>
Date: Wed Jan 25 02:53:32 2017

DevTools: fix network waterfall sorting icon

This patch:
- hides network waterfall sorting icon if other column is used for sorting
- makes icon crisp on retina

BUG= 684894 
R=dgozman, allada

Review-Url: https://codereview.chromium.org/2652893008
Cr-Commit-Position: refs/heads/master@{#445921}

[modify] https://crrev.com/4fad6cb6f585cdfeaccf613a9c310f04260c87c3/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
[modify] https://crrev.com/4fad6cb6f585cdfeaccf613a9c310f04260c87c3/third_party/WebKit/Source/devtools/front_end/network/networkLogView.css

Comment 2 by lushnikov@chromium.org, Jan 26 2017

Labels: Merge-Request-57
Status: Started (was: Assigned)
It would be nice to merge this to M-57
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 26 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by gov...@chromium.org, Jan 26 2017 

If possible, pls merge your change to M57 branch 2987 before 5:00 PM PT today (Thursday, 01/26) so we can pick it for tomorrow's Dev release.

Comment 5 by allada@chromium.org, Jan 26 2017 

Committing to beta here: https://codereview.chromium.org/2656163002/
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 26 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/260197f0c30569f1aa843393c10a96e9ab957cb8

commit 260197f0c30569f1aa843393c10a96e9ab957cb8
Author: allada <allada@chromium.org>
Date: Thu Jan 26 21:02:59 2017

DevTools: fix network waterfall sorting icon

This patch:
- hides network waterfall sorting icon if other column is used for sorting
- makes icon crisp on retina

BUG= 684894 
R=dgozman, allada

NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2652893008
Cr-Commit-Position: refs/heads/master@{#445921}
(cherry picked from commit 4fad6cb6f585cdfeaccf613a9c310f04260c87c3)

Review-Url: https://codereview.chromium.org/2656163002
Cr-Commit-Position: refs/branch-heads/2987@{#120}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/260197f0c30569f1aa843393c10a96e9ab957cb8/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
[modify] https://crrev.com/260197f0c30569f1aa843393c10a96e9ab957cb8/third_party/WebKit/Source/devtools/front_end/network/networkLogView.css

Comment 7 by durga.behera@chromium.org, Jan 27 2017

Labels: TE-Verified-57.0.2987.13 TE-Verified-M57
Verified the issue on Mac 10.12.2,Win 10 and Ubuntu 14.04 using 57.0.2987.13 and its working fine.

allada@: Could you please update the status to Fixed.
684894_Jan_27.mp4
1.1 MB View Download

Comment 8 by allada@chromium.org, Jan 27 2017

Status: Fixed (was: Started)
►

Sign in to add a comment